Shellcheck; i hovedsak variabel-quoting #123
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Drift/pvv-nixos-config#123
Reference in New Issue
Block a user
Delete Branch "shellcheck"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Kjørt shellcheck og manuell inspeksjon av diverse shellscripts. De fleste endringene er å legge til
""rundt variabler som i teorien kan inneholde mellomrom eller andre rare tegn, f.eks. hvis de er brukerstyrte og ikke er en store-path.Flere ut av disse kan i teorien bli enda sikrere om du bruker
', siden de ikke skal expande noe at runtime. litt nitt@@ -54,2 +54,2 @@mkdir -p $(dirname "${value.certificate}") $(dirname "${value.certificateKey}")if ! ${openssl} x509 -checkend 86400 -noout -in ${value.certificate}mkdir -p "$(dirname "${value.certificate}")" "$(dirname "${value.certificateKey}")"if ! ${openssl} x509 -checkend 86400 -noout -in "${value.certificate}"Consider quoting
${openssl}in case the nix store is located in a path with spaces :3View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.