Drift/pvv-nixos-config
17
6
Fork 1
Code Issues Pull Requests 6 Actions Wiki Activity

Shellcheck; i hovedsak variabel-quoting #123

Merged
oysteikt merged 1 commits from shellcheck into main 2026-05-08 09:35:57 +02:00
Conversation 7 Commits 1 Files Changed 6
+44 -44
felixalb commented 2026-02-08 12:14:15 +01:00
Owner
Copy Link
Copy Source

Kjørt shellcheck og manuell inspeksjon av diverse shellscripts. De fleste endringene er å legge til "" rundt variabler som i teorien kan inneholde mellomrom eller andre rare tegn, f.eks. hvis de er brukerstyrte og ikke er en store-path.

Kjørt shellcheck og manuell inspeksjon av diverse shellscripts. De fleste endringene er å legge til `""` rundt variabler som i teorien kan inneholde mellomrom eller andre rare tegn, f.eks. hvis de er brukerstyrte og ikke er en store-path.
oysteikt commented 2026-02-08 13:40:04 +01:00
Owner
Copy Link
Copy Source

Flere ut av disse kan i teorien bli enda sikrere om du bruker ', siden de ikke skal expande noe at runtime. litt nitt

Flere ut av disse kan i teorien bli enda sikrere om du bruker `'`, siden de ikke skal expande noe at runtime. litt nitt
oysteikt reviewed 2026-02-08 13:58:29 +01:00
modules/snakeoil-certs.nix Outdated
@@ -54,2 +54,2 @@
mkdir -p $(dirname "${value.certificate}") $(dirname "${value.certificateKey}")
if ! ${openssl} x509 -checkend 86400 -noout -in ${value.certificate}
mkdir -p "$(dirname "${value.certificate}")" "$(dirname "${value.certificateKey}")"
if ! ${openssl} x509 -checkend 86400 -noout -in "${value.certificate}"
oysteikt commented 2026-02-08 13:58:29 +01:00
Owner
Copy Link
Copy Source

Consider quoting ${openssl} in case the nix store is located in a path with spaces :3

Consider quoting `${openssl}` in case the nix store is located in a path with spaces :3
oysteikt force-pushed shellcheck from 81b458d59c to 074504a97a 2026-04-23 22:05:01 +02:00 Compare
oysteikt reviewed 2026-04-23 22:11:01 +02:00
hosts/bicep/services/mysql/backup.nix Outdated
@@ -58,3 +58,3 @@
ln -T "$OUT_FILE" "$STATE_DIRECTORY/mysql-dump-latest.sql.zst"
while [ "$(find "$STATE_DIRECTORY" -type f -printf '.' | wc -c)" -gt ${toString (rotations + 1)} ]; do
while [ "$(find "$STATE_DIRECTORY" -type f -printf '.' | wc -c)" -gt "${toString (rotations + 1)}" ]; do
oysteikt commented 2026-04-23 22:11:01 +02:00
Owner
Copy Link
Copy Source

Hurrrrr

Hurrrrr
oysteikt force-pushed shellcheck from 074504a97a to 2a062a6031 2026-04-23 22:11:22 +02:00 Compare
oysteikt approved these changes 2026-04-23 22:12:04 +02:00
oysteikt left a comment
Owner
Copy Link
Copy Source

Ser ut som søppel, meg gustav

Ser ut som søppel, meg gustav
vegardbm commented 2026-04-24 04:42:33 +02:00
Owner
Copy Link
Copy Source

Ser ut som søppel, meg gustav

What did he mean by this?

> Ser ut som søppel, meg gustav What did he mean by this?
oysteikt commented 2026-04-24 10:01:56 +02:00
Owner
Copy Link
Copy Source

LGTM (looks garbage to me), me gusta, litt nitt litt shit, kan sikkert trykke på den store grønne knappen.

LGTM (looks garbage to me), me gusta, <s>litt nitt</s> litt shit, kan sikkert trykke på den store grønne knappen.
oysteikt added 1 commit 2026-05-08 09:31:38 +02:00
Run shellcheck
Eval nix flake / evals (pull_request) Successful in 4m11s
Details
Build topology graph / evals (push) Successful in 2m53s
Details
Eval nix flake / evals (push) Successful in 4m7s
Details
8db3034baf
oysteikt force-pushed shellcheck from 2a062a6031 to 8db3034baf 2026-05-08 09:31:38 +02:00 Compare
oysteikt merged commit 8db3034baf into main 2026-05-08 09:35:57 +02:00
oysteikt deleted branch shellcheck 2026-05-08 09:35:57 +02:00
pederbs commented 2026-05-09 04:18:03 +02:00
Owner
Copy Link
Copy Source

it hurts in my lib.escapeShellArg

it hurts in my `lib.escapeShellArg`
Sign in to join this conversation.
Reviewers
No Reviewers
oysteikt
Labels
Clear labels
art
The issue needs someone to be creative
 backup
big
No, not bug, **big** - this is gonna take a while
 blocked
This issue/PR depends on one or more other issues/PRs
 bug
Something is not working, and it's not the shield hero
 comprehensive first issue
Do this as your first issue, and learn a lot of things
 crash report
Report an oopsie
 disputed
kranglefanter
 documentation
Documentation changes required
 duplicate
This issue or pull request already exists
 enhancement
New feature
 good first issue
Get your hands dirty with a new project here
 logging
networking
TTM4100
 nixos
Requires changes to our nixos setup
 question
More information is needed
 salt
Requires changes to our salt setup
 security
Skommel
 servers n' hardware
Regards hardware, servers or VMs
 simple first issue
Done in nix no time
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adriangl (Adrian Gunnar Lauterer) albertba (Albert Bayazidi) alfhj (Alf Helge Jakobsen) amalieem (Amalie Erdal Mansaker) bjornoka (Bjornar Orjansen Kaarevik) chrisfjo (Christian Fredrik Johnsen) chrivi (Christoffer Viken) danio (Daniel Lovbrotte Olsen) davidk (David Kaasen) dungby (Dung-Bai Yen) eirikwit (Eirik Witterso) felixalb (Felix Albrigtsen) frero (Fredrik Robertsen) jonmro (Jon Martinus Rodtang) jovre (Jo Vassbotn Remvik) karolds (Karoline Dyve Samuelsen) knuta (Knut Auvor Grythe) krisleri (Kristoffer Longva Eriksen) larshhan (Lars Halvor Hansen) olived (Oliver Didriksen-Kolstad) oysteikt (Oystein Kristoffer Tveit) pederbs (Peder Bergebakken Sundt) root (rot) torsteno (Torstein Nordgård-Hansen) vegardbm (Vegard Bieker Matthey) yorinad (Yorin Anne De Jong)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drift/pvv-nixos-config#123
Delete Branch "shellcheck"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?