fbc573d03a
Fix a few problems with the huge mpdconf update. There's alot of shift here, mostly due to word wraps. This, also, improves on uniformity and clarity of the document.
2008-12-24 15:02:01 -08:00
1b5dd452d1
doc: fix "playlistdelete" documentation
...
"playlistdelete" takes a song position, not a song id. There are
no song ids in stored playlists.
2008-12-24 23:54:09 +01:00
1bd3cde062
playlist: fix stored playlist modifications with absolute paths
...
When save_absolute_paths_in_playlists was enabled in mpd.conf, MPD
broke all playlists when manipulated using the "playlistdelete"
command. The reason was that map_directory_child_fs() was used, which
doesn't accept slashes in the file name. Use the new map_uri_fs()
function instead.
2008-12-24 22:04:24 +01:00
a94e59ca21
stored_playlist: fix integer overflow in length estimation
...
With a large maximum playlist length, the integer multiplication
"playlist_max_length * MPD_PATH_MAX" may overflow. Change that to a
division. This was not a dangerous bug, since it was only used for
a quick estimate.
2008-12-24 17:40:41 +01:00
7f98ba24c7
ffmpeg: case AV_NOPTS_VALUE to int64_t
...
The old code casted it to a 32 bit integer, which cut off bits.
AVFormatContext.duration is a int64_t, so use this type.
2008-12-24 11:56:53 +01:00
82ef85a309
ffmpeg: don't assign "0" to pointer
...
Use NULL instead. Found by sparse.
2008-12-24 11:49:37 +01:00
fefd3d6fb7
Makefile.am: fix sparse invocation
...
Added missing includes.
2008-12-24 11:49:09 +01:00
d05c7f898f
added build test script "test.sh"
2008-12-24 11:35:57 +01:00
fc723803a4
mp3: "tag" argument is unused when libid3tag is disabled
...
Add G_GNUC_UNUSED attributes.
2008-12-24 11:07:58 +01:00
4716ef1014
listen: "port" argument is unused when TCP support is disabled
...
Add a G_GNUC_UNUSED attribute.
2008-12-24 11:07:58 +01:00
d66dddb47e
Makefile.am: distribute only real scripts
...
Don't distribute the whole scripts/ directory, because this may
include editor backup files and other temporary files.
2008-12-24 11:01:14 +01:00
51fd7cdfb7
Makefile.am: removed m4/* from EXTRA_DIST
...
The m4 files are automatically included in the distribution.
2008-12-24 10:56:53 +01:00
6260e0c8a0
Makefile.am: don't add directory into EXTRA_DIST
...
Add separate files. This fixes "make distcheck".
2008-12-24 10:50:23 +01:00
136670832c
configure.ac: renamed shout options
...
configure options should use the dash instead of the underscore.
2008-12-24 03:40:00 +01:00
2888ff9bfa
configure.ac: fix --enable-un documentation
...
Unix domain socket support is enabled by default.
2008-12-24 03:32:11 +01:00
7950a6d612
configure.ac: disable the mikmod plugin by default
...
libmikmod seems to be unmaintained, and has several critical bugs
which make MPD crash.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461519
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=476339
Disable the plugin by default to minimize harm. Users should
explicitly enable the mikmod decoder (--enable-mod) if they wish to
have it anyway.
2008-12-24 03:24:23 +01:00
0d9d82a932
pcm_utils: check pcm_convert()==0
...
It is illegal to pass an empty audio buffer around. pcm_resample()
sometimes seems to result in 0 samples, maybe related to
libsamplerate. To work around that problem, add special checks after
both pcm_convert() invocations. Removed the pcm_resample()==0 checks
from pcm_convert().
2008-12-24 03:08:39 +01:00
d2d11d70a8
client: always attempt to flush deferred buffers
...
When a response is very long (e.g. a large playlist > 100k songs),
most of it will end up in the deferred buffers. Filling the deferred
queue is very expensive currently, because a new buffer is allocated
for every client_write() operation. This may lead to long delays, and
the client might give up and disconnect meanwhile. This patch makes
MPD attempt to flush the deferred queue as often as possible, to work
around this problem. Due to the MPD 0.14 code freeze, we should not
optimize the buffering code now.
2008-12-24 03:00:08 +01:00
d96cda95a1
shout: fixed bad error message printout
2008-12-23 18:05:25 +01:00
fe4a9a6d67
Build makefiles after checking available outputs and decoder plugins
...
Move the AC_OUTPUT below the checks. So you nicely see what goes wrong.
2008-12-22 12:02:12 +01:00
3b2a752d0e
Merge branch 'http_buffer_remove' of git://git.musicpd.org/avuton/mpd
2008-12-21 19:40:06 +01:00
bc31d7a0ee
Merge branch 'master' of git://git.musicpd.org/avuton/mpd
...
Conflicts:
doc/mpdconf.example
2008-12-21 19:39:08 +01:00
143b46caf5
Fix AUTHORS UTF-8 compliance.
2008-12-21 06:10:47 -08:00
e75e40085f
Remove obsolete http_buffer* stuff that went away with the new curl backend.
2008-12-20 22:16:02 -08:00
04561b604b
Huge mpdconf update.
...
Over time mpdconf has evolved and has been maintained and contributed to by many different folks at different
times. Try to give it some unity. Attempt to clear up some language and make things crystal clear. Add more
examples. Use tabs when it makes sense. Make better borders. Remove obsolete options. Try to put more defaults
when it makes sense.
2008-12-20 22:09:06 -08:00
cc279f115b
More clarification in the INSTALL file
2008-12-20 19:29:55 -08:00
b1838b4976
Word wrap to 80 char lines
2008-12-20 19:27:02 -08:00
f2aa7c4d15
Start off with a disclaimer about the NEWS file information
2008-12-20 19:20:19 -08:00
d97c7d6aae
Clarify some very messy documentation in the installation.
2008-12-20 19:17:34 -08:00
6821f2b774
Update the text of the GPLv2, this fixes the address and a few other oddities.
2008-12-20 19:02:09 -08:00
a6e981c08d
doc: clarify "user" setting (starting as root / unprivileged)
...
The "user" option does not work if MPD is started by an unprivileged
user.
2008-12-20 17:37:12 +01:00
bfaaf425c2
log: map log level "SECURE" to GLib's "INFO"
...
Make "secure" a log level different from "default". "secure" should be
right between "default" and "verbose". Map "default" to Glib's
"MESSAGE" log level.
2008-12-20 17:26:49 +01:00
5c0c66d676
MPD version 0.14~beta3
2008-12-20 06:49:31 -08:00
c41fa6cf5e
configure.ac: check lame availability before shout_mp3 test
...
If lame was not available, the shout_mp3 plugin was enabled anyway,
and triggered compiler errors.
2008-12-17 17:16:24 +01:00
caf601199b
configure.ac: disable shout when no encoder is found
...
First check if an ecoder plugin is available, then determine whether
to enable the shout output plugin.
2008-12-17 16:57:48 +01:00
213c021eac
Remove useless statement.
2008-12-17 16:49:33 +01:00
5d56b6ced8
player_control: check if errored_song is set
...
getPlayerErrorStr() assumes that pc.errored_song is set when an error
occured. Since the song may have been deleted meanwhile, add a NULL
check.
2008-12-17 16:46:12 +01:00
13192546a8
playlist: clear pc.errored_song on delete
...
When a (remote) song is deleted from the playlist, there may still be
a reference to it in pc.errored_song. Clear this reference.
2008-12-17 16:45:49 +01:00
25c04a97d3
Remove useless computation. After the pthread_cond_wait loop there are at least MIN(od->bufferSize, size) free bytes in the buffer. Thus MIN(od->bufferSize - od->len, size) is always equal to MIN(od->bufferSize, size).
2008-12-17 15:56:43 +01:00
c584d6b087
Remove useless statement, curpos is initialized at the beginning of the loop.
2008-12-17 15:56:43 +01:00
c36a6b0aee
Factor computation.
2008-12-17 15:56:43 +01:00
a4f0c7b457
Use MIN.
2008-12-17 15:56:43 +01:00
df80ae86ee
Call CloseComponent after AudioUnitUninitialize.
2008-12-17 15:56:43 +01:00
f5bbb2b819
man: document Unix domain socket configuration in the manual
...
Additionally, add an example in mpdconf.example.
2008-12-16 21:31:52 +01:00
5aa1afe693
command: reject unsupported URI schemes
...
When a client-specified URI has a scheme which is not supported, do
not try to open it as a local file, but provide a meaningful error
message.
2008-12-16 21:23:29 +01:00
c50115f9a2
ls: added uri_has_scheme()
...
uri_has_scheme() checks if an URI contains the sub string "://", which
makes MPD assume that it is a remote URI.
2008-12-16 21:22:10 +01:00
e0be4400cf
ls: don't return suffix from parent directory name
...
When a file had no file name extension, getSuffix() could return the
extension of the parent directory (if it had one).
2008-12-16 21:22:08 +01:00
b765c62f2f
ls: reimplement getSuffix() with strrchr()
...
The old getSuffix() code was quite wasteful, and can be replaced
completely with strrchr().
2008-12-16 21:20:09 +01:00
d0024c077d
ls: use bool
...
Use the C99 "bool" data type instead of "int".
2008-12-16 21:18:33 +01:00
1d82edc6d3
ls: make printRemoteUrlHandlers() return void
...
printRemoteUrlHandlers() cannot fail, and does not need a return
value.
2008-12-16 21:18:31 +01:00
Avuton Olrich