ff079377f2
wind: Do not use invalid escape sequences
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
a9f21ebdac
roken: Const-qualify sys_errlist
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
db5c8711b4
kuser: Fix error produced by compiling with FORTIFY_SOURCE=2
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
744678eb03
krb5: Use NULL pointer constant
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
0e9e1a4f31
kdc: Make parameter const
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
ffac143401
kdc: Finish incomplete log message
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
9ba687cf22
kdc: Fix log message
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
68b475fa2e
kdc: Finish incomplete warning message
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
079088e543
kdc: Fix incorrect log message
...
‘list.len’ can be equal to zero.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
e8b42d9d42
hx509: Fix incorrect documentation comment
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
bbe9c83b19
hx509: Remove unused variable
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
59f89e4b15
hx509: Avoid misleading error message
...
If ‘keyid’ is an empty string, then the numeric error code that gets
appended to this error message may be mistaken for the key ID. Address
this by not mentioning any ID in such cases.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
df6c33ff1e
hx509: Use NULL pointer constant
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
e9bc20f5da
hcrypto: Fix errors produced by compiling with FORTIFY_SOURCE=2
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:37:56 -05:00
1f88e8c919
wind: Fix code spelling
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
a4b4e982f3
krb5: Fix code spelling
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
7369cbd11c
krb5: Fix spelling of error messages
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
91d54fd4c9
kinit: Fix code spelling
...
This flag has no apparent relation to the process of converting
waterways into canals.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
fbe89adf27
kdc: Fix spelling of error and log messages
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
560c9da844
kdc: Fix code spelling
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
05602c2286
hx509: Fix code spelling
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
ef083a0e2c
hx509: Fix code spelling
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
61bf5009a0
hx509: Fix spelling of error messages
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
d9d3dd448d
hdb: Fix code spelling
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
7cb320b46a
hdb: Fix error messages
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
551f0c32fa
base: Fix code spelling
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-28 21:34:35 -05:00
a3878d3e9d
wind: Deny invalid UTF-8 encodings
...
Codepoints above U+10FFFF and overlong encodings are considered invalid.
Unpaired surrogates are not, as these are known to be generated on
occasion — by Windows, for example.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-08 14:58:21 -06:00
bf25b38c0a
wind: Support UTF-8–encoding non-BMP codepoints
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-08 14:58:21 -06:00
ba63461cd4
wind: Support UTF-16–encoding non-BMP codepoints
...
View with ‘git show -b’.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-08 14:58:21 -06:00
821fac3648
wind: Use portable integer types
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-08 14:58:21 -06:00
db70a76074
wind: Do not perform arithmetic on a NULL pointer
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-08 14:58:21 -06:00
ed798da1f2
wind: Fix documentation comment
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-08 14:58:21 -06:00
d274f0e240
bx509: Test CSRs w/ BasicConstraints in extReq
2023-11-08 14:22:02 -06:00
2ad736a579
hx509: Fix EACCES / ENOMEM confusion
2023-11-08 14:22:02 -06:00
be0d1e68e5
hx509: Add support for CSRs w/ BasicConstraints
2023-11-08 14:22:02 -06:00
0f998cdbc2
ktutil: Avoid even doing arithmetic on res after realloc(res, ...).
...
Under C99, Sec 6.2.4, paragraph 2:
The value of a pointer becomes indeterminate when the object it
points to reaches the end of its lifetime.
`Indeterminate' (3.17.2) includes a trap representation, and any
reference to a trap representation is undefined behaviour. Thus,
after realloc(res, ...) succeeds, any reference to res (or p) is
undefined behaviour.
So, instead of using `p - res` after res has been freed, use the
existing name for the value we know it has now: len. (We could also
use alloced because p == end in this branch, and end = res + alloced,
and p = res + len. Of course, we would have to move it up a line to
before we update alloced to have a different value.)
fix https://github.com/heimdal/heimdal/issues/1164
2023-11-07 14:20:40 -06:00
487ba95669
wind: Don’t use invalid escape sequences
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
a18436d709
roken: Remove excess zeros in literals
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
30e3921ad1
krb5: Fix error condition
...
‘ret’ can only ever be equal to zero.
Found by Coverity (Samba CID 1518754).
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
b1f7a63e41
krb5: Fix error code mapping
...
Found by Coverity (Samba CID 1518726).
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
b0f196880c
krb5: Check result of calling decode_Ticket()
...
Found by Coverity (Samba CID 241005).
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
0334d9e55a
krb5: Check function return values
...
Found by Coverity (Samba CID 240644).
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
e53d594d05
krb5: Check return value of RAND_bytes()
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
62e63b2da6
krb5: Fix unused variable
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
9f05c65981
kdc: Specify client time in FAST inner KRB-ERROR
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
5de5e5f7f6
kdc: Use NULL to assign to pointers
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
f8ba91164c
kdc: Don’t use uninitialized variable
...
The call to free_KDCDHKeyInfo(), further down, could have caused heap
corruption.
Found by Coverity (Samba CID 1544611).
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
6f73fd8206
kdc: Remove pointer cast
...
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
a840986dc0
hx509: Check return value of RAND_bytes()
...
Found by Coverity (Samba CID 1544600).
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
d1b9d2c2f9
hx509: Add missing format specifier
...
Found by Coverity (Samba CID 1544604).
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz >
2023-11-02 20:19:54 -05:00
Joseph Sutton