oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

krb5: Check result of calling decode_Ticket()

Browse Source 
Found by Coverity (Samba CID 241005).

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
This commit is contained in:
Joseph Sutton
2023-10-06 10:32:47 +13:00
committed by Nico Williams
parent 0334d9e55a
commit b0f196880c
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/krb5/build_ap_req.c
View File

@@ -51,7 +51,11 @@ krb5_build_ap_req (krb5_context context,
ap.ap_options.use_session_key = (ap_options & AP_OPTS_USE_SESSION_KEY) > 0;
ap.ap_options.mutual_required = (ap_options & AP_OPTS_MUTUAL_REQUIRED) > 0;
decode_Ticket(cred->ticket.data, cred->ticket.length, &ap.ticket, &len);
ret = decode_Ticket(cred->ticket.data, cred->ticket.length, &ap.ticket, &len);
if (ret)
return ret;
if (cred->ticket.length != len)
krb5_abortx(context, "internal error in ASN.1 encoder");
ap.authenticator.etype = enctype;
ap.authenticator.kvno = NULL;
ap.authenticator.cipher = authenticator;