kadm5: Fix ENOMEM path leak

2022-01-20 12:40:29 -06:00
parent b0fa256521
commit be6305b601
1 changed files with 8 additions and 3 deletions
--- a/lib/kadm5/marshall.c
+++ b/lib/kadm5/marshall.c
@@ -387,9 +387,14 @@ ret_principal_ent(krb5_storage *sp,
                ret = ENOMEM;
                goto out;
            }
-	    CHECK(kadm5_ret_tl_data(sp, tp));
-	    tp->tl_data_next = princ->tl_data;
-	    princ->tl_data = tp;
+	    ret = kadm5_ret_tl_data(sp, tp);
+            if (ret == 0) {
+                tp->tl_data_next = princ->tl_data;
+                princ->tl_data = tp;
+            } else {
+                free(tp);
+                goto out;
+            }
 	}
    }