From be6305b6017499e5f18d9f10db3e00cbe11a69de Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Thu, 20 Jan 2022 12:40:29 -0600 Subject: [PATCH] kadm5: Fix ENOMEM path leak --- lib/kadm5/marshall.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/kadm5/marshall.c b/lib/kadm5/marshall.c index 0583b3eda..9d24233ba 100644 --- a/lib/kadm5/marshall.c +++ b/lib/kadm5/marshall.c @@ -387,9 +387,14 @@ ret_principal_ent(krb5_storage *sp, ret = ENOMEM; goto out; } - CHECK(kadm5_ret_tl_data(sp, tp)); - tp->tl_data_next = princ->tl_data; - princ->tl_data = tp; + ret = kadm5_ret_tl_data(sp, tp); + if (ret == 0) { + tp->tl_data_next = princ->tl_data; + princ->tl_data = tp; + } else { + free(tp); + goto out; + } } }