oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Revert "lib/krb5: re-allow data->length == 0 in krb5_pac_add_buffer()"

Browse Source 
This reverts commit f3301fc94c.
This commit is contained in:
Luke Howard
2022-03-03 10:11:32 +11:00
parent f3301fc94c
commit 89cf441e8d
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/krb5/pac.c
View File

@@ -383,7 +383,7 @@ krb5_pac_add_buffer(krb5_context context, krb5_pac p,
size_t len, offset, header_end, old_end;
uint32_t i;
assert(data->length == 0 || (data->length > 0 && data->data != NULL));
assert(data->length > 0 && data->data != NULL);
len = p->pac->numbuffers;
@@ -433,9 +433,8 @@ krb5_pac_add_buffer(krb5_context context, krb5_pac p,
* copy in new data part
*/
if (data->length != 0)
memcpy((unsigned char *)p->data.data + offset,
data->data, data->length);
memcpy((unsigned char *)p->data.data + offset,
data->data, data->length);
memset((unsigned char *)p->data.data + offset + data->length,
0, p->data.length - offset - data->length);