oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

lib/krb5: re-allow data->length == 0 in krb5_pac_add_buffer()

Browse Source 
PAC_TYPE_CLIENT_CLAIMS_INFO and PAC_TYPE_DEVICE_CLAIMS_INFO are
of zero length unless any claims are actually defined.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
This commit is contained in:
Stefan Metzmacher
2022-02-24 23:32:51 +01:00
committed by Luke Howard
parent df655cecd1
commit f3301fc94c
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/krb5/pac.c
View File

@@ -383,7 +383,7 @@ krb5_pac_add_buffer(krb5_context context, krb5_pac p,
size_t len, offset, header_end, old_end;
uint32_t i;
assert(data->length > 0 && data->data != NULL);
assert(data->length == 0 || (data->length > 0 && data->data != NULL));
len = p->pac->numbuffers;
@@ -433,8 +433,9 @@ krb5_pac_add_buffer(krb5_context context, krb5_pac p,
* copy in new data part
*/
memcpy((unsigned char *)p->data.data + offset,
data->data, data->length);
if (data->length != 0)
memcpy((unsigned char *)p->data.data + offset,
data->data, data->length);
memset((unsigned char *)p->data.data + offset + data->length,
0, p->data.length - offset - data->length);