bekkalokk/gitea: direct non-logged-in users to the explore tab #46

danio · 2024-07-19T21:20:19+02:00

danio commented

2024-07-19 21:20:19 +02:00

This is a much more interesting page rather than trying to sell gitea

didn't test yolo

This is a much more interesting page rather than trying to sell gitea didn't test yolo

danio added 1 commit 2024-07-19 21:20:19 +02:00

8f3013dc00 bekkalokk/gitea: direct non-logged-in users to the explore tab

This is a much more interesting page rather than trying to sell gitea

oysteikt commented

2024-07-28 02:24:34 +02:00

Can we remove "ui.meta".DESCRIPTION then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page

Can we remove `"ui.meta".DESCRIPTION` then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page

felixalb commented

2024-07-28 21:17:19 +02:00

Can we remove "ui.meta".DESCRIPTION then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page

Isn't that field mostly for PWA's and chat/social media embeds?

is the default subheader, but

<meta name="description" content="Bokstavelig talt programvareverkstedet">

is in the head/meta. We can keep the meta-field and expand services.gitea.appName to include an emdash and a subheader, though?

> Can we remove `"ui.meta".DESCRIPTION` then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page Isn't that field mostly for PWA's and chat/social media embeds? ![image](/attachments/af9a08f1-e99f-4052-80c3-92a2d72c9c7b) is the default subheader, but > \<meta name="description" content="Bokstavelig talt programvareverkstedet"\> is in the head/meta. We can keep the meta-field and expand `services.gitea.appName` to include an emdash and a subheader, though?

image.png

106 KiB

felixalb requested review from felixalb 2024-07-28 21:47:23 +02:00

felixalb approved these changes 2024-07-28 21:47:40 +02:00

felixalb commented

2024-07-28 21:49:16 +02:00

I have some funny quotes on mine: 387d6b6a5f/hosts/defiant/services/gitea.nix (L20), but I hope this works as well :)

I have some funny quotes on mine: https://git.feal.no/felixalb/nixos-config/src/commit/387d6b6a5fef57d4bcf3a487d7a5f12b71fe3065/hosts/defiant/services/gitea.nix#L20, but I hope this works as well :)

oysteikt approved these changes 2024-07-28 23:09:18 +02:00

oysteikt merged commit a0a837e26d into main

2024-07-28 23:10:39 +02:00

oysteikt referenced this issue from a commit

2024-07-28 23:10:40 +02:00

Merge pull request 'bekkalokk/gitea: direct non-logged-in users to the explore tab' (!46) from gitea-explore into main

Sign in to join this conversation.

No reviewers