Drift/pvv-nixos-config
Drift/pvv-nixos-config
16
4
Fork 1
Code Issues Pull Requests 6 Actions 1 Wiki Activity

bekkalokk/gitea: direct non-logged-in users to the explore tab #46

Merged
oysteikt merged 1 commits from gitea-explore into main 2024-07-28 23:10:39 +02:00
Conversation 3 Commits 1 Files Changed 1 +1
danio commented 2024-07-19 21:20:19 +02:00
Owner
Copy Link

This is a much more interesting page rather than trying to sell gitea

didn't test yolo

This is a much more interesting page rather than trying to sell gitea didn't test yolo
danio added 1 commit 2024-07-19 21:20:19 +02:00 
This is a much more interesting page rather than trying to sell gitea
oysteikt commented 2024-07-28 02:24:34 +02:00
Owner
Copy Link

Can we remove "ui.meta".DESCRIPTION then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page

Can we remove `"ui.meta".DESCRIPTION` then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page
felixalb commented 2024-07-28 21:17:19 +02:00
Owner
Copy Link

Can we remove "ui.meta".DESCRIPTION then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page

Isn't that field mostly for PWA's and chat/social media embeds?

image

is the default subheader, but

<meta name="description" content="Bokstavelig talt programvareverkstedet">

is in the head/meta. We can keep the meta-field and expand services.gitea.appName to include an emdash and a subheader, though?

> Can we remove `"ui.meta".DESCRIPTION` then, or at least change it to something more fitting of a preview card? It was intended to be the subheader of this page Isn't that field mostly for PWA's and chat/social media embeds? ![image](/attachments/af9a08f1-e99f-4052-80c3-92a2d72c9c7b) is the default subheader, but > \<meta name="description" content="Bokstavelig talt programvareverkstedet"\> is in the head/meta. We can keep the meta-field and expand `services.gitea.appName` to include an emdash and a subheader, though?
image.png
106 KiB
felixalb requested review from felixalb 2024-07-28 21:47:23 +02:00
felixalb approved these changes 2024-07-28 21:47:40 +02:00
felixalb commented 2024-07-28 21:49:16 +02:00
Owner
Copy Link

I have some funny quotes on mine: 387d6b6a5f/hosts/defiant/services/gitea.nix (L20), but I hope this works as well :)

I have some funny quotes on mine: https://git.feal.no/felixalb/nixos-config/src/commit/387d6b6a5fef57d4bcf3a487d7a5f12b71fe3065/hosts/defiant/services/gitea.nix#L20, but I hope this works as well :)
oysteikt approved these changes 2024-07-28 23:09:18 +02:00
oysteikt merged commit a0a837e26d into main 2024-07-28 23:10:39 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
felixalb
oysteikt
Labels
Clear labels
  
art

The issue needs someone to be creative

  
backup

   
big

No, not bug, **big** - this is gonna take a while

  
blocked

This issue/PR depends on one or more other issues/PRs

  
bug

Something is not working, and it's not the shield hero

  
crash report

Report an oopsie

  
disputed

kranglefanter

  
documentation

Documentation changes required

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
good first issue

Get your hands dirty with a new project here

  
logging

   
nixos

Requires changes to our nixos setup

  
question

More information is needed

  
salt

Requires changes to our salt setup

  
security

Skommel

  
servers n' hardware

Regards hardware, servers or VMs

  
wontfix

This won't be fixed

No Label
art
backup
big
blocked
bug
crash report
disputed
documentation
duplicate
enhancement
good first issue
logging
nixos
question
salt
security
servers n' hardware
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Drift/pvv-nixos-config#46
No description provided.
Delete Branch "gitea-explore"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?