Revert "rename input: unstable -> nixpkgs-unstable" #16

danio · 2023-11-05T06:29:15+01:00

danio commented

2023-11-05 06:29:15 +01:00

This reverts commit 3caa66fb64.

Why say many words when few words do trick

Don't actually care that much

This reverts commit 3caa66fb640aa72649fe32c74b5c593cd06b9a75. Why say many words when few words do trick Don't actually care that much

danio added 1 commit 2023-11-05 06:29:16 +01:00

Eval nix flake / evals (push) Successful in 2m38s Details

Eval nix flake / evals (pull_request) Successful in 2m46s Details

8c4fa7dd1c Revert "rename input: unstable -> nixpkgs-unstable"

This reverts commit 3caa66fb64.

Why say many words when few words do trick

oysteikt commented

2023-11-06 02:16:49 +01:00

Sure, we could just name it unstable, but in the current state it creates confusion as you might think the unstable specialArg input refers to unstable pkgs, while it actually refers to the unstable channel. nixpkgs-unstable specifically refers to the channel https://nixos.org/channels/nixpkgs-unstable, and nothing else.

Also, GitHub seems to suggest it's more common among personal configs to use nixpkgs-unstable:

https://github.com/search?q=language%3Anix+inputs.nixpkgs-unstable&type=code (608 at the time of writing)
https://github.com/search?q=language%3Anix+inputs.unstable&type=code (210 at the time of writing)

I'd be more open to namespacing pkgs from nixpkgs-unstable under pkgs.unstable with an overlay, as done here: fe21fa1670/standard/overlays/default.nix (L18-L21), and then rather keep being explicit about the flake input naming.

Sure, we could just name it `unstable`, but in the current state it creates confusion as you might think the `unstable` specialArg input refers to unstable `pkgs`, while it actually refers to the unstable channel. `nixpkgs-unstable` specifically refers to the channel https://nixos.org/channels/nixpkgs-unstable, and nothing else. Also, GitHub seems to suggest it's more common among personal configs to use `nixpkgs-unstable`: - https://github.com/search?q=language%3Anix+inputs.nixpkgs-unstable&type=code (608 at the time of writing) - https://github.com/search?q=language%3Anix+inputs.unstable&type=code (210 at the time of writing) I'd be more open to namespacing `pkgs` from `nixpkgs-unstable` under `pkgs.unstable` with an overlay, as done here: https://github.com/Misterio77/nix-starter-configs/blob/fe21fa16704972126a9660622b8464bd215c7894/standard/overlays/default.nix#L18-L21, and then rather keep being explicit about the flake input naming.

👍 1

danio commented

2023-11-06 02:22:44 +01:00

Sure, we could just name it unstable, but in the current state it creates confusion as you might think the unstable specialArg input refers to unstable pkgs

Im convinced

> Sure, we could just name it unstable, but in the current state it creates confusion as you might think the unstable specialArg input refers to unstable pkgs Im convinced

danio closed this pull request

2023-11-06 02:22:44 +01:00

Eval nix flake / evals (push) Successful in 2m38s

Details

Eval nix flake / evals (pull_request) Successful in 2m46s

Details