Drift/pvv-nixos-config
17
5
Fork 1
Code Issues Pull Requests 6 Actions Wiki Activity

Revert "rename input: unstable -> nixpkgs-unstable" #16

Closed
danio wants to merge 1 commits from disagreemenet into main
pull from: disagreemenet
merge into: Drift:main
Conversation 2 Commits 1 Files Changed 4 +30 -28
danio commented 2023-11-05 06:29:15 +01:00
Owner
Copy Link

This reverts commit 3caa66fb64.

Why say many words when few words do trick

Don't actually care that much

This reverts commit 3caa66fb640aa72649fe32c74b5c593cd06b9a75. Why say many words when few words do trick Don't actually care that much
danio added 1 commit 2023-11-05 06:29:16 +01:00
Revert "rename input: unstable -> nixpkgs-unstable"
All checks were successful
Eval nix flake / evals (push) Successful in 2m38s
Details
Eval nix flake / evals (pull_request) Successful in 2m46s
Details
8c4fa7dd1c 
This reverts commit 3caa66fb64.

Why say many words when few words do trick
oysteikt commented 2023-11-06 02:16:49 +01:00
Owner
Copy Link

Sure, we could just name it unstable, but in the current state it creates confusion as you might think the unstable specialArg input refers to unstable pkgs, while it actually refers to the unstable channel. nixpkgs-unstable specifically refers to the channel https://nixos.org/channels/nixpkgs-unstable, and nothing else.

Also, GitHub seems to suggest it's more common among personal configs to use nixpkgs-unstable:

I'd be more open to namespacing pkgs from nixpkgs-unstable under pkgs.unstable with an overlay, as done here: fe21fa1670/standard/overlays/default.nix (L18-L21), and then rather keep being explicit about the flake input naming.

Sure, we could just name it `unstable`, but in the current state it creates confusion as you might think the `unstable` specialArg input refers to unstable `pkgs`, while it actually refers to the unstable channel. `nixpkgs-unstable` specifically refers to the channel https://nixos.org/channels/nixpkgs-unstable, and nothing else. Also, GitHub seems to suggest it's more common among personal configs to use `nixpkgs-unstable`: - https://github.com/search?q=language%3Anix+inputs.nixpkgs-unstable&type=code (608 at the time of writing) - https://github.com/search?q=language%3Anix+inputs.unstable&type=code (210 at the time of writing) I'd be more open to namespacing `pkgs` from `nixpkgs-unstable` under `pkgs.unstable` with an overlay, as done here: https://github.com/Misterio77/nix-starter-configs/blob/fe21fa16704972126a9660622b8464bd215c7894/standard/overlays/default.nix#L18-L21, and then rather keep being explicit about the flake input naming.
👍 1
danio commented 2023-11-06 02:22:44 +01:00
Author
Owner
Copy Link

Sure, we could just name it unstable, but in the current state it creates confusion as you might think the unstable specialArg input refers to unstable pkgs

Im convinced

> Sure, we could just name it unstable, but in the current state it creates confusion as you might think the unstable specialArg input refers to unstable pkgs Im convinced
danio closed this pull request 2023-11-06 02:22:44 +01:00
All checks were successful
Eval nix flake / evals (push) Successful in 2m38s
Details
Eval nix flake / evals (pull_request) Successful in 2m46s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
art
The issue needs someone to be creative
 backup
big
No, not bug, **big** - this is gonna take a while
 blocked
This issue/PR depends on one or more other issues/PRs
 bug
Something is not working, and it's not the shield hero
 crash report
Report an oopsie
 disputed
kranglefanter
 documentation
Documentation changes required
 duplicate
This issue or pull request already exists
 enhancement
New feature
 good first issue
Get your hands dirty with a new project here
 logging
networking
TTM4100
 nixos
Requires changes to our nixos setup
 question
More information is needed
 salt
Requires changes to our salt setup
 security
Skommel
 servers n' hardware
Regards hardware, servers or VMs
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adriangl albertba alfhj amalieem bjornoka chrisfjo chrivi danio davidk dungby eirikwit felixalb frero jonmro jovre karolds knuta krisleri larshhan oysteikt pederbs root torsteno yorinad
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drift/pvv-nixos-config#16
Delete Branch "disagreemenet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?