Drift/pvv-nixos-config
17
6
Fork 1
Code Issues Pull Requests 10 Actions Wiki Activity

Set up prometheus-phpfpm-exporter for various pools on bekkalokk #159

Merged
oysteikt merged 2 commits from prometheus-phpfpm-exporter into main 2026-07-27 13:58:47 +02:00
Conversation 1 Commits 2 Files Changed 4
+71
oysteikt commented 2026-07-26 11:20:07 +02:00
Owner
Copy Link
Copy Source

Fixes Drift/issues#332

Fixes https://git.pvv.ntnu.no/Drift/issues/issues/332
oysteikt added 2 commits 2026-07-26 11:20:09 +02:00
bekkalokk/prometheus-phpfpm-exporter: init 87240b15a2
ildkule/prometheus/phpfpm: scrape from bekkalokk
Eval nix flake / evals (push) Successful in 7m37s
Details
Eval nix flake / evals (pull_request) Successful in 6m54s
Details
6f65a78933
felixalb approved these changes 2026-07-27 13:02:05 +02:00
felixalb left a comment
Owner
Copy Link
Copy Source

I assume this is tested and working, looks good. Feel free to ignore comments :)

I assume this is tested and working, looks good. Feel free to ignore comments :)
hosts/bekkalokk/services/prometheus-phpfpm-exporter.nix
@@ -0,0 +33,4 @@
};
services.nginx = lib.mkIf cfg.enable {
virtualHosts."www.pvv.ntnu.no" = lib.mkIf config.services.nginx.enable {
felixalb commented 2026-07-27 13:00:00 +02:00
Owner
Copy Link
Copy Source

non-blocking nit: This mkif is erratic behavior that could potentially make troubleshooting more difficult. I don't see any benefit from conditionally changing the configuration, as if nginx is disabled, this is not used for anything anyways.

non-blocking nit: This mkif is erratic behavior that could potentially make troubleshooting more difficult. I don't see any benefit from conditionally changing the configuration, as if nginx is disabled, this is not used for anything anyways.
oysteikt commented 2026-07-27 13:58:26 +02:00
Author
Owner
Copy Link
Copy Source

I'll open a new issue on making a treewide decision about these

I'll open a new issue on making a treewide decision about these
hosts/bekkalokk/services/prometheus-phpfpm-exporter.nix
@@ -0,0 +42,4 @@
proxyPass = "http://localhost:${toString cfg.port}/metrics";
extraConfig = ''
allow 127.0.0.1;
felixalb commented 2026-07-27 13:01:25 +02:00
Owner
Copy Link
Copy Source

non-blocking nit: we might want to go over the repo and replace most of these with 127.0.0.0/8, but this is probably absolutely fine

non-blocking nit: we might want to go over the repo and replace most of these with 127.0.0.0/8, but this is probably absolutely fine
oysteikt commented 2026-07-27 13:58:43 +02:00
Author
Owner
Copy Link
Copy Source

Let's solve these in anothet treewide

Let's solve these in anothet treewide
oysteikt merged commit afc6b3182e into main 2026-07-27 13:58:47 +02:00
oysteikt deleted branch prometheus-phpfpm-exporter 2026-07-27 13:58:48 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
felixalb
Labels
Clear labels
art
The issue needs someone to be creative
 backup
big
No, not bug, **big** - this is gonna take a while
 blocked
This issue/PR depends on one or more other issues/PRs
 bug
Something is not working, and it's not the shield hero
 comprehensive first issue
Do this as your first issue, and learn a lot of things
 crash report
Report an oopsie
 disputed
kranglefanter
 documentation
Documentation changes required
 duplicate
This issue or pull request already exists
 enhancement
New feature
 good first issue
Get your hands dirty with a new project here
 logging
networking
TTM4100
 nixos
Requires changes to our nixos setup
 question
More information is needed
 salt
Requires changes to our salt setup
 security
Skommel
 servers n' hardware
Regards hardware, servers or VMs
 simple first issue
Done in nix no time
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adriangl (Adrian Gunnar Lauterer) albertba (Albert Bayazidi) alfhj (Alf Helge Jakobsen) amalieem (Amalie Erdal Mansaker) bjornoka (Bjornar Orjansen Kaarevik) chrisfjo (Christian Fredrik Johnsen) chrivi (Christoffer Viken) danio (Daniel Lovbrotte Olsen) davidk (David Kaasen) dungby (Dung-Bai Yen) eirikwit (Eirik Witterso) felixalb (Felix Albrigtsen) frero (Fredrik Robertsen) jonmro (Jon Martinus Rodtang) jovre (Jo Vassbotn Remvik) karolds (Karoline Dyve Samuelsen) knuta (Knut Auvor Grythe) krisleri (Kristoffer Longva Eriksen) larshhan (Lars Halvor Hansen) olived (Oliver Didriksen-Kolstad) oysteikt (Oystein Kristoffer Tveit) pederbs (Peder Bergebakken Sundt) root (rot) torsteno (Torstein Nordgård-Hansen) vegardbm (Vegard Bieker Matthey) yorinad (Yorin Anne De Jong)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drift/pvv-nixos-config#159
Delete Branch "prometheus-phpfpm-exporter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?