Drift/pvv-nixos-config
17
6
Fork 1
Code Issues Pull Requests 7 Actions Wiki Activity

modules/python-http-handlers: init #146

Open
oysteikt wants to merge 2 commits from python-http-handlers into main
pull from: python-http-handlers
merge into: Drift:main
Conversation 0 Commits 2 Files Changed 3
+257 -69
oysteikt commented 2026-07-16 11:01:09 +02:00
Owner
Copy Link
Copy Source

Make the socket activated python http handler from gatus' minecraft-checker into a template, and rewrite minecraft-checker to use this template.

Make the socket activated python http handler from gatus' minecraft-checker into a template, and rewrite minecraft-checker to use this template.
oysteikt requested review from felixalb 2026-07-16 11:01:10 +02:00
oysteikt added 2 commits 2026-07-16 11:03:22 +02:00
modules/python-http-handlers: init b78abaab33
ildkule/gatus/minecraft-checker: rewrite to use python-http-handlers module
Eval nix flake / evals (pull_request) Successful in 6m46s
Details
Eval nix flake / evals (push) Successful in 7m1s
Details
ed411cdf6d
oysteikt force-pushed python-http-handlers from 59b020e14d to ed411cdf6d 2026-07-16 11:03:22 +02:00 Compare
felixalb approved these changes 2026-07-16 11:59:53 +02:00
felixalb left a comment
Owner
Copy Link
Copy Source

If this change is tested and working, I think it's fine :)

If this change is tested and working, I think it's fine :)
modules/python-http-handlers.nix
@@ -0,0 +14,4 @@
name = lib.mkOption {
type = lib.types.str;
default = "phh-${name}";
felixalb commented 2026-07-16 11:58:54 +02:00
Owner
Copy Link
Copy Source

Consider using a more descriptive name to help troubleshooting and make it more immediately identifyable, e.g. `gatus-http-handler-${name}" or something

Consider using a more descriptive name to help troubleshooting and make it more immediately identifyable, e.g. `gatus-http-handler-${name}" or something
modules/python-http-handlers.nix
@@ -0,0 +26,4 @@
listenStreams = lib.mkOption {
type = with lib.types; listOf str;
default = [
"/run/phh-${name}.socket"
felixalb commented 2026-07-16 11:58:12 +02:00
Owner
Copy Link
Copy Source

Does this ignore the name option above, and use this naming scheme anyways? If so, why? And if not, will this become /run/phh-phh-name.socket when using the default value in the name option above?

Does this ignore the name option above, and use this naming scheme anyways? If so, why? And if not, will this become `/run/phh-phh-name.socket` when using the default value in the name option above?
modules/python-http-handlers.nix
@@ -0,0 +59,4 @@
'';
};
enableDefaultHardening = lib.mkEnableOption "" // {
felixalb commented 2026-07-16 11:54:51 +02:00
Owner
Copy Link
Copy Source

Should this option exist? If it is not there, users are incentivized to fix the specific option(s) that they are having problems with, rather than just disabling everything

Should this option exist? If it is not there, users are incentivized to fix the specific option(s) that they are having problems with, rather than just disabling everything
modules/python-http-handlers.nix
@@ -0,0 +104,4 @@
description = ''
A list of flake8 rules to ignore while linting the python code.
An opinionated list of bogus rules (according to module author) is provided as default.
felixalb commented 2026-07-16 11:59:24 +02:00
Owner
Copy Link
Copy Source

👀

👀
Some checks are pending
Eval nix flake / evals (pull_request) Successful in 6m46s
Details
Eval nix flake / evals (push) Successful in 7m1s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin python-http-handlers:python-http-handlers
git checkout python-http-handlers
Sign in to join this conversation.
Reviewers
No Reviewers
felixalb
Labels
Clear labels
art
The issue needs someone to be creative
 backup
big
No, not bug, **big** - this is gonna take a while
 blocked
This issue/PR depends on one or more other issues/PRs
 bug
Something is not working, and it's not the shield hero
 comprehensive first issue
Do this as your first issue, and learn a lot of things
 crash report
Report an oopsie
 disputed
kranglefanter
 documentation
Documentation changes required
 duplicate
This issue or pull request already exists
 enhancement
New feature
 good first issue
Get your hands dirty with a new project here
 logging
networking
TTM4100
 nixos
Requires changes to our nixos setup
 question
More information is needed
 salt
Requires changes to our salt setup
 security
Skommel
 servers n' hardware
Regards hardware, servers or VMs
 simple first issue
Done in nix no time
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adriangl (Adrian Gunnar Lauterer) albertba (Albert Bayazidi) alfhj (Alf Helge Jakobsen) amalieem (Amalie Erdal Mansaker) bjornoka (Bjornar Orjansen Kaarevik) chrisfjo (Christian Fredrik Johnsen) chrivi (Christoffer Viken) danio (Daniel Lovbrotte Olsen) davidk (David Kaasen) dungby (Dung-Bai Yen) eirikwit (Eirik Witterso) felixalb (Felix Albrigtsen) frero (Fredrik Robertsen) jonmro (Jon Martinus Rodtang) jovre (Jo Vassbotn Remvik) karolds (Karoline Dyve Samuelsen) knuta (Knut Auvor Grythe) krisleri (Kristoffer Longva Eriksen) larshhan (Lars Halvor Hansen) olived (Oliver Didriksen-Kolstad) oysteikt (Oystein Kristoffer Tveit) pederbs (Peder Bergebakken Sundt) root (rot) torsteno (Torstein Nordgård-Hansen) vegardbm (Vegard Bieker Matthey) yorinad (Yorin Anne De Jong)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Drift/pvv-nixos-config#146
Delete Branch "python-http-handlers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?