427dd81678
client: added assertions on channel!=NULL
...
I'm hunting down a bug where client->channel==NULL during I/O
operations. These new assertions help avoid this kind of bug in the
future.
2009-06-04 08:42:02 +02:00
ed475718e6
decoder_plugin: corrected outdated API documentation
2009-06-04 08:22:43 +02:00
70d7c79546
conf: make config_param.num_block_params unsigned
2009-06-03 06:55:09 +02:00
ddc2694419
conf: eliminated CamelCase
...
Renamed all remaining CamelCase functions.
2009-06-03 06:55:04 +02:00
5c5d39b012
doc: mark the "User's Manual" as incomplete
2009-06-02 21:09:46 +02:00
3483c891dc
doc: added Developer's Manual
...
Just a start...
2009-06-02 21:09:45 +02:00
516e52c67b
doc: added "since MPD version" to commands
...
Document which commands were introduced after MPD 0.13.
2009-06-02 20:47:00 +02:00
9ee53bc76e
player_thread: check pipe size again before exiting
...
When the decoder is finished, break out of the player loop only after
another player.pipe check. We did check the pipe size a few lines
above, but that check was kind of racy.
2009-06-02 08:40:28 +02:00
aa7f5dec87
player_thread: don't leak empty music_chunks
...
When a music_chunk only contains a tag but no PCM data, play_chunk()
returns true without freeing the chunk. The caller now assumes that
the chunk is moved into some music_pipe and does not bother to free it
either.
2009-06-02 08:40:28 +02:00
1800bde303
player_thread: reinitialize music_buffer in !NDEBUG
...
To check for leaked music_chunk objects, free the music buffer on
CLOSE_AUDIO. This invokes an assertion check which ensures that all
chunks have been returned to the buffer.
2009-05-29 23:34:51 +02:00
a90c4e5184
output_all: explicitly return "true" from audio_output_all_play()
...
Instead of returning the local variable "ret" which is always true at
this point, hard-code the "true" return value, because that might be
more readable.
2009-05-29 23:04:45 +02:00
0dedfe7ddc
input/file: log message on error
...
If a file is removed the library, next time mpd will try to play it it
will result in an error 'ERROR: problems decoding some/file.ogg'.
Nothing is written in log files (verbose mode or not)
[mk: append strerror(errno)]
2009-05-28 23:46:19 +02:00
535da8b797
volume: changed "default" to "DISABLED" in switch statement
...
Make gcc warn us if we add a new mixer type, and forget to add a new
"case" line.
2009-05-28 23:39:51 +02:00
eb71b5b8a4
added doc/sticker to .gitignore
2009-05-28 23:38:45 +02:00
68f1aed452
volume: converted volume_mixer_type to an enum
...
Don't use CPP macros when you can use C enums.
2009-05-28 23:37:26 +02:00
a54f14f31d
volume: removed unused macro "VOLUME_MIXER_SOFTWARE_DEFAULT"
2009-05-28 23:34:45 +02:00
4e8208717b
playlist: reset "current song" when playlist ends
...
Commit f78cddb4
2009-05-28 23:23:32 +02:00
6e3bd4f620
Incorrect identifying of --with-tremor option in configure.ac
...
[mk: moved check out of the AC_ARG_WITH block]
2009-05-26 16:16:53 +02:00
a2de0f0fc5
configure.ac: use $FAAD_LIBS in libmp4ff check
...
Append $FAAD_LIBS to $LIBS when detecting libmp4ff. $FAAD_LIBS may
contain an important -L flag.
2009-05-26 16:00:23 +02:00
1d0be2a031
doc: fixed DocBook markup in doc/sticker.xml
...
The old sticker.xml used elements which are not valid in DocBook. Now
that the file is valid, let's add it to $(DOCBOOK_FILES).
2009-05-15 18:54:50 +02:00
46e0b49e71
Makefile.am: added doc/doxygen.conf to $(EXTRA_DIST)
2009-05-15 18:43:22 +02:00
bad2342141
configure.ac: removed the --disable-lametest option
...
The M4 function AM_PATH_LAME (m4/lame.m4) defined a configure flag
named "--disable-lametest". This is redundant with configure.ac's
--disable-lame-encoder, and specifying both options may break the
build. Since AM_PATH_LAME is only called when the encoder plugin is
enabled, we can safely remove that --disable-lametest option.
2009-05-15 18:27:58 +02:00
d8ef153729
music_chunk: added more audio_format_valid() assertions
...
Check the validity of the audio_format during write operations.
2009-05-11 17:25:34 +02:00
1a9a65b23b
music_pipe: added assertion on chunk->audio_format
...
Always assert that the audio format of the new chunk is valid.
2009-05-11 16:33:48 +02:00
7e678d2ba9
latest git, httpd_output_plugin compile fix, mac os x
...
Hello,
While compiling latest git I've received a compile error in the
httpd_output_plugin.
Small patch attached.
Patrik
2009-05-10 21:15:53 +02:00
3ee3375273
Modify version string to post-release version 0.15~git
2009-05-08 03:44:46 -07:00
0af8ea3ace
mpd version 0.15~beta2
2009-05-08 03:44:46 -07:00
7c13249b59
pcm_resample: fixed typo in libsamplerate runtime check
...
The string comparison should be "!= 0", not "== 0". Ouch.
2009-05-07 12:19:01 +02:00
a4c59943d1
player_control: assert that pc.next_song is NULL after seeking
...
The player thread must reset pc.next_song after seeking, even if that
operation has failed. This patch adds an assertion.
2009-05-06 18:46:59 +02:00
438f3547cc
player_control: removed pc.error check from pc_seek()
...
The only pc_seek() caller clears the error, rendering the check
useless. Even if the previous PLAY command resulted in a player
error, this check is not very useful.
2009-05-06 18:46:52 +02:00
3083df5a5f
player_control: renamed playerSeek(), return bool
...
Renamed playerSeek() to pc_seek() to get rid of CamelCase. Convert
the return value to bool.
2009-05-06 18:35:22 +02:00
0935d85c69
tag_id3: added support for the UFID frame
...
If the UFID frame's owner is "http://musicbrainz.org ", assume its
value is the MusicBrainz track id.
2009-05-06 14:42:07 +02:00
feae8b8f68
test/run_encoder: flush the encoder before exiting
2009-05-05 22:51:22 +02:00
4818d38677
httpd_output: save the page generated by encoder_tag()
...
Flush the encoder before calling encoder_tag(). The first page
generated by the encoder after sending the tag will be the new
"header" page, which is sent to all HTTP clients when they connect.
This is a little bit specific to the vorbis encoder, but there are no
other encoders which support tags (yet).
2009-05-05 22:51:17 +02:00
e55e560d4e
httpd_output: moved code to httpd_output_encoder_to_clients()
...
Moved some code from httpd_output_encode_and_play() into separate
functions httpd_output_broadcast_page() and
httpd_output_encoder_to_clients().
2009-05-05 22:43:28 +02:00
9080797025
httpd_output: disable Icy-Metadata when encoder supports tags
...
There's no reason to send both encoder tags and Icy-Metadata to the
client. Let's disable Icy-Metadata when the encoder supports embedded
tags.
2009-05-05 22:41:36 +02:00
ebc1d3516c
vorbis_encoder: start a new stream in tag()
...
When a new tag is set, end the current stream and begin a new one.
Use vorbis_analysis_headerout() to write a full ogg header. This
fixes a problem with icecast: after a song change in MPD, icecast
stops forwarding ogg packets to its clients.
2009-05-05 22:40:51 +02:00
7875072d38
vorbis_encoder: moved code to vorbis_encoder_headerout()
2009-05-05 22:37:13 +02:00
795569208a
httpd_output: assert that tag!=NULL
...
In the tag() method, MPD guarantees that it does not pass tag==NULL.
Converted the runtime check to an assertion.
2009-05-05 22:36:44 +02:00
7dcdb2ce39
archive/zip: pass NULL instead of 0 to zzip_dir_open()
...
The second parameter of zzip_dir_open() is a pointer. Pass the NULL
pointer instead of 0 (with implicit conversion at compile time).
2009-05-04 09:46:15 +02:00
e6ea7ffdcb
Makefile.am: run sparse once with all sources
...
Don't loop over source files, do all checks in one run.
2009-05-04 09:43:05 +02:00
be15a9e4ae
Modify version string to post-release version 0.15~git
2009-04-30 08:07:24 -07:00
0e8a8dadda
mpd version 0.15~beta1
2009-04-30 08:07:24 -07:00
2c7508f72c
Makefile.am: ship DocBook sources even when documentation is disabled
2009-04-30 11:43:19 +02:00
86a9cd82e7
configure: Fix where mikmod was not explicitly disabled.
2009-04-29 03:13:30 -07:00
f9372600b8
configure: Fix where mp4 was not explicitly disabled.
2009-04-29 03:11:14 -07:00
6dde36d683
scripts: Remove mpd.spec, it was always half-baked.
...
Remove mpd.spec and makerpm.sh. It was never used or maintained
and the distributors take care of this kinda thing now anyhow.
2009-04-29 02:43:04 -07:00
e710037760
output_init: added option to disable the hardware mixer
...
Added the per-device option "mixer_enabled" which allows users to
disable the hardware mixer of an audio output.
2009-04-28 20:33:06 +02:00
61b0835512
command: added "sticker delete" command
2009-04-28 20:25:07 +02:00
610940a06d
sticker: added sticker_delete_value()
...
sticker_delete_value() deletes only one value in a sticker, while
the old function sticker_delete() deletes all values.
2009-04-28 20:23:27 +02:00
Max Kellermann