oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

player_thread: don't leak empty music_chunks

Browse Source 
When a music_chunk only contains a tag but no PCM data, play_chunk()
returns true without freeing the chunk.  The caller now assumes that
the chunk is moved into some music_pipe and does not bother to free it
either.
This commit is contained in:
Max Kellermann 2009-06-02 08:37:30 +02:00
parent 1800bde303
commit aa7f5dec87
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/player_thread.c
View File

@ -447,8 +447,10 @@ play_chunk(struct song *song, struct music_chunk *chunk,
}
}
if (chunk->length == 0)
if (chunk->length == 0) {
music_buffer_return(player_buffer, chunk);
return true;
}
pc.elapsed_time = chunk->times;
pc.bit_rate = chunk->bit_rate;