Max Kellermann
|
483b1f51c9
|
DetachedSong: remove parameter names from "defaulted" constructors
Suppresses gcc warnings.
|
2014-01-21 21:06:56 +01:00 |
Max Kellermann
|
ecac7a629e
|
db/upnp: fix empty song URI
Fall back to UPnPDirObject::url if there is no override.
|
2014-01-21 21:02:21 +01:00 |
Max Kellermann
|
21209ff46b
|
DetachedSong: use "default" copy/move constructors
Remove unnecessary explicit code.
|
2014-01-21 20:38:13 +01:00 |
Chase Geigle
|
716bdc36fd
|
pcm/SoxrResampler: Add configurable quality levels
|
2014-01-21 20:35:26 +01:00 |
Max Kellermann
|
4f120f3714
|
PlaylistSong: modify the given song object in-place
Reduce bloat.
|
2014-01-21 00:28:37 +01:00 |
Max Kellermann
|
dd20a3ce7e
|
test: add unit test for playlist_check_translate_song()
|
2014-01-21 00:28:34 +01:00 |
Max Kellermann
|
c727c86245
|
PlaylistSong: remove redundant "secure" check
This has been verified already in the caller.
|
2014-01-21 00:28:32 +01:00 |
Max Kellermann
|
82b4ec22be
|
PlaylistSong: recurse after applying base_uri
Allows applying map_to_relative_path() with base_uri.
|
2014-01-20 23:47:43 +01:00 |
Max Kellermann
|
501f1e6de0
|
PlaylistSong: remove the IsInDatabase() check
No caller passes a database song to this function, but if he does,
this check doesn't make sense.
|
2014-01-20 23:32:03 +01:00 |
Max Kellermann
|
414d5b648c
|
PlaylistSong: don't map relative URI to absolute path
This didn't make sense.
|
2014-01-20 23:31:08 +01:00 |
Max Kellermann
|
a237e7f860
|
CommandLine: show the current git tag and commit id
|
2014-01-20 23:31:08 +01:00 |
Max Kellermann
|
07a3bef25c
|
PlaylistSong: pass reference variables internally
|
2014-01-20 19:57:26 +01:00 |
Max Kellermann
|
2f51285349
|
Merge branch 'v0.18.x'
|
2014-01-20 09:05:36 +01:00 |
Max Kellermann
|
ab9c9068d4
|
Queue: rename struct queue to Queue
Works around a build failure on Solaris because annoyingly, Solaris
reserves the name "queue". This rename was pending anyway.
|
2014-01-20 08:57:46 +01:00 |
Max Kellermann
|
6b4d7d7315
|
Queue: make the constructor "explicit"
|
2014-01-20 08:57:41 +01:00 |
Max Kellermann
|
64465c1318
|
Song: make the "parent" attribute mandatory
The Song class is only used for database songs now. A Song without a
Directory is not possible anymore.
|
2014-01-19 23:16:09 +01:00 |
Max Kellermann
|
a506adea41
|
Directory: use Song::Export()
|
2014-01-19 23:16:08 +01:00 |
Max Kellermann
|
f5ae1ce00b
|
LightSong: new class to be used by DatabasePlugin callbacks
Detach the Song class completely from the public API, only to be used
by SimpleDatabase and the update thread.
|
2014-01-19 17:04:51 +01:00 |
Max Kellermann
|
738d6f1040
|
db/proxy: simplify error handling in GetSong()
Check mpd_response_finish() before using mpd_song. Don't skip this
check even if the mpd_song is non-nullptr.
|
2014-01-19 11:37:42 +01:00 |
Max Kellermann
|
ba372197fb
|
db/simple: make borrowed_song_count "mutable"
Simpler to use than const_cast.
|
2014-01-19 11:23:02 +01:00 |
Max Kellermann
|
bde27ccec3
|
Tag: pack attributes tighter
This saves another 3% memory.
|
2014-01-19 03:11:01 +01:00 |
Max Kellermann
|
d2cf74027c
|
Song: embed the Tag object statically into class Song
Reduces overhead because we need to manage only one memory allocation.
According to valgrind/massif, we save 7%.
|
2014-01-19 02:58:55 +01:00 |
Max Kellermann
|
bc966577ff
|
Song: use the VarSize library
|
2014-01-18 19:24:55 +01:00 |
Max Kellermann
|
fdf4dff561
|
db/upnp: move Tag from UPnPDirObject to Song
The UPnPDirObject is a temporary object, we can move its contents.
This reduces runtime overhead.
|
2014-01-18 19:09:42 +01:00 |
Max Kellermann
|
fab6cbed75
|
db/upnp/Discovery: eliminate attribute "last_seen"
|
2014-01-18 16:28:12 +01:00 |
Max Kellermann
|
051eede1ed
|
db/upnp/Discovery: use monotonic clock instead of time()
|
2014-01-18 16:26:11 +01:00 |
Max Kellermann
|
0696cac50b
|
db/upnp/Discovery: eliminate full copy in getServer()
|
2014-01-18 16:18:51 +01:00 |
Max Kellermann
|
0c2485e86c
|
db/upnp: use getServer() in Visit()
Reduce bloat.
|
2014-01-18 16:13:33 +01:00 |
Max Kellermann
|
7d696a7063
|
db/upnp/Discovery: eliminate Error attribute
Move code to method Start() and add Error& parameters to several
methods.
|
2014-01-18 16:08:30 +01:00 |
Max Kellermann
|
53573e950f
|
db/upnp: remove unnecessary m_superdir nullptr checks
|
2014-01-18 16:02:21 +01:00 |
Max Kellermann
|
1e99983263
|
db/upnp: pass ContentDirectoryService references
|
2014-01-18 15:58:02 +01:00 |
Max Kellermann
|
5409e43fb5
|
db/upnp: cache m_path.back()
|
2014-01-18 15:44:41 +01:00 |
Max Kellermann
|
f33f891c54
|
db/upnp: add UpnpMakeAction() helper function
|
2014-01-18 15:27:54 +01:00 |
Max Kellermann
|
6e55552292
|
db/upnp/ixmlwrap: getFirstElementValue() returns const char *
Eliminate the std::string bloat.
|
2014-01-18 15:01:19 +01:00 |
Max Kellermann
|
e569f82dd3
|
db/upnp: merge duplicate nullptr check
|
2014-01-18 14:44:06 +01:00 |
Max Kellermann
|
1a4940bbda
|
db/upnp: free IXML_Document *request manually
|
2014-01-18 14:38:52 +01:00 |
Max Kellermann
|
22dd3c8048
|
db/upnp/Device: move code to method Parse()
Forward the Error to the caller.
|
2014-01-18 14:29:31 +01:00 |
Max Kellermann
|
04b7648e00
|
db/upnp/Device: use ContentDirectoryDescriptor's move operator
Reduce bloat.
|
2014-01-18 14:26:24 +01:00 |
Max Kellermann
|
be0759d465
|
db/upnp/Discovery: don't copy XML to std::string
Pass "const char *" to Expat.
|
2014-01-18 14:24:38 +01:00 |
Max Kellermann
|
339d939873
|
db/upnp/Discovery: fix memory leak
|
2014-01-18 14:03:18 +01:00 |
Max Kellermann
|
c1950e40e6
|
db/upnp: remove unused typedef DevServIt
|
2014-01-18 13:42:54 +01:00 |
Max Kellermann
|
ad76bad8fd
|
db/upnp: use move operator to assign XML CDATA
Reduce runtime bloat.
|
2014-01-18 13:39:31 +01:00 |
Max Kellermann
|
55737e4ff6
|
db/upnp/Util: trimstring() constructs string from buffer
Reduce overhead by omitting the part of the buffer that consists only
of whitespace.
|
2014-01-18 13:36:50 +01:00 |
Max Kellermann
|
f3b4ddee6c
|
db/upnp/Discovery: free the response body
Memory leak.
|
2014-01-18 13:08:48 +01:00 |
Max Kellermann
|
758b504cf3
|
db/upnp/Discovery: don't copy the response body
Bloat.
|
2014-01-18 13:07:42 +01:00 |
Max Kellermann
|
416f7c2600
|
db/upnp: don't hold mutex while downloading device description
Must not perform blocking I/O while holding a mutex.
|
2014-01-18 13:04:01 +01:00 |
Max Kellermann
|
b9f02f22c4
|
db/upnp: don't use WorkQueue for _ADVERTISEMENT_BYEBYE
Remove the ContentDirectoryDescriptor right away. Reduces bloat.
|
2014-01-18 12:56:35 +01:00 |
Max Kellermann
|
b635610409
|
db/upnp: include cleanup
|
2014-01-18 12:51:25 +01:00 |
Max Kellermann
|
d4d4d6217f
|
db/upnp: don't use LazyDatabase
Now that MPD forks early, this workaround is obsolete.
|
2014-01-18 12:48:28 +01:00 |
Max Kellermann
|
be47320a05
|
Daemon: fork as early as possible
Keep the parent process around until MPD has finished initializing.
This is important for libraries that are allergic to fork(), such as
libupnp.
|
2014-01-18 12:42:30 +01:00 |