oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

lib/ffmpeg/Filter: remove FilterContext destructor

Browse Source 
Fixes potential double-free bugs which currently did not occur because
the destructors happened to be called in the right order.
This commit is contained in:
Max Kellermann
2021-08-24 12:32:44 +02:00
parent ca2439f595
commit a62a35e1db
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/ffmpeg/Filter.hxx
View File

@@ -101,10 +101,10 @@ public:
FilterContext(FilterContext &&src) noexcept FilterContext(FilterContext &&src) noexcept
:context(std::exchange(src.context, nullptr)) {} :context(std::exchange(src.context, nullptr)) {}
~FilterContext() noexcept { /* note: we don't need a destructor calling avfilter_free()
if (context != nullptr) here because the AVFilterGraph owns and frees all the
avfilter_free(context); AVFilterContext instances */
} // TODO: do we really need this wrapper class anymore?
FilterContext &operator=(FilterContext &&src) noexcept { FilterContext &operator=(FilterContext &&src) noexcept {
using std::swap; using std::swap;