lib/ffmpeg/Filter: remove FilterContext destructor

Fixes potential double-free bugs which currently did not occur because
the destructors happened to be called in the right order.
This commit is contained in:
Max Kellermann 2021-08-24 12:32:44 +02:00
parent ca2439f595
commit a62a35e1db
1 changed files with 4 additions and 4 deletions

View File

@ -101,10 +101,10 @@ public:
FilterContext(FilterContext &&src) noexcept
:context(std::exchange(src.context, nullptr)) {}
~FilterContext() noexcept {
if (context != nullptr)
avfilter_free(context);
}
/* note: we don't need a destructor calling avfilter_free()
here because the AVFilterGraph owns and frees all the
AVFilterContext instances */
// TODO: do we really need this wrapper class anymore?
FilterContext &operator=(FilterContext &&src) noexcept {
using std::swap;