oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

Queue: use signed integer instead of G_MAXUINT

Browse Source 
The check for unsigned underflow is fragile and unreliable.
This commit is contained in:
Max Kellermann 2013-01-08 16:33:33 +01:00
parent 6c57047362
commit 8ef87be482
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Queue.cxx
View File

@ -181,7 +181,7 @@ queue::MoveRange(unsigned start, unsigned end, unsigned to)
// If to < start, we need to move start-to items to newend (= end + to - start), starting from to
// This is the same as moving items from start-1 to to (decreasing), with start-1 going to end-1
// We have to iterate in this order to avoid writing over something we haven't yet moved
for (unsigned i = start - 1; i >= to && i != G_MAXUINT; i--)
for (int i = start - 1; i >= int(to); i--)
MoveItemTo(i, i + end - start);
// Copy the original block back in, starting at to.