oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

do not check dc->start after loop

Browse Source 
dc->start cannot be true after the loop, because it was the loop
condition.  dc->start could have been set by another thread between
the while loop and the if, but I suspect this is not the case the
author intended, so we just remove the dc->start check.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7256 09075e82-0dd4-0310-85a5-a0d7c8717e4f
This commit is contained in:
Max Kellermann 2008-04-12 04:12:11 +00:00 committed by Eric Wong
parent e63f388b04
commit 199ea5f2c1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/decode.c
View File

@ -144,7 +144,7 @@ static int waitOnDecode(PlayerControl * pc, DecoderControl * dc,
while (dc->start)
player_wakeup_decoder();
if (dc->start || dc->error != DECODE_ERROR_NOERROR) {
if (dc->error != DECODE_ERROR_NOERROR) {
pc->errored_song = pc->current_song;
pc->error = PLAYER_ERROR_FILE;
quitDecode(pc, dc);