Commit Graph

58 Commits

Author SHA1 Message Date
Nicolas Williams
3b05166332 kadm5: Fix leak in randkey principal 2020-09-07 22:04:59 -05:00
Jeffrey Altman
db859520b4 lib/kadm5: use krb5_enomem() where possible
Change-Id: I487fbc640a8f793f0aa02ef4c94099e09241d616
2018-12-25 16:57:55 -06:00
Roland C. Dowdeswell
4303174a49 Fix signature of hdb_generate_key_set_password()
The change to the signature of hdb_generate_key_set_password() in
Heimdal 7.1 broke API/ABI compatibility with previous releases.  We
fix this by renaming it hdb_generate_key_set_password_with_ks_tuple()
and creating a new hdb_generate_key_set_password() which calls our
new function with zeroes for the added arguments.

Issue #246      https://github.com/heimdal/heimdal/issues/246
2017-01-29 19:40:59 -05:00
Nicolas Williams
649c4824b0 kadm5: fix leak in set_keys 2016-02-29 19:13:12 -06:00
Nicolas Williams
76965a2a14 Add missing initialization of mandatory 2016-02-16 20:49:32 -06:00
Nicolas Williams
b1af99aa81 Fix memleak in lib/kadm5/set_keys.c 2016-02-16 20:49:32 -06:00
Nicolas Williams
417dff03ba Fix trailing whitespace 2011-11-29 14:50:44 -06:00
Roland C. Dowdeswell
af011f57fc Provide server side kadm5_chpass_principal_3() with ks_tuple implementation.
We enable kadm5_chpass_principal_3() in the server side of the
library.  The client kadm5 library calls will still return the
error KAMD5_KS_TUPLE_NO_SUPP.

Signed-off-by: Nicolas Williams <nico@cryptonector.com>
2011-11-29 14:47:37 -06:00
Roland C. Dowdeswell
2f6ad56c46 Reverse order of n_ks_tuple and ks_tuple in hdb_generate_key_set().
Signed-off-by: Nicolas Williams <nico@cryptonector.com>
2011-11-29 14:47:37 -06:00
Nicolas Williams
104bb8ef53 Fix unitialized HDB_extension problem (specifically the mandatory field) 2011-10-31 00:20:05 -05:00
Nicolas Williams
e23a1efdc9 Fixes for updates of KADM5_KVNO but not KEY_DATA and vice-versa.
It turns out that updates of kvno but not key data and vice-versa are
both, allowed and actually done (e.g, in kadmin's ank).  Doing the right
thing in these cases turns out to be a bit tricky, but this commit ought
to do it.
2011-07-22 16:07:10 -05:00
Nicolas Williams
1e14951592 Preserve set_time on historic keysets in kadm5_s_modify_principal() path. 2011-07-22 16:07:10 -05:00
Nicolas Williams
4f5dbf2f81 Two patches from Roland Dowdeswell to make n_keys/new_keys args optional. 2011-07-22 16:07:09 -05:00
Nicolas Williams
c818890dd7 Re-write _kadm5_set_keys2() to handle key history. 2011-07-22 16:07:08 -05:00
Nicolas Williams
6e04b05e9d Initial support for kadm5_randkey_principal_3(), needed by krb5_admin.
NOT TESTED YET.
2011-07-22 16:04:52 -05:00
Love Hornquist Astrand
f5f9014c90 Warning fixes from Christos Zoulas
- shadowed variables
- signed/unsigned confusion
- const lossage
- incomplete structure initializations
- unused code
2011-04-29 20:25:05 -07:00
Love Hornquist Astrand
b4013ca830 [HEIMDAL-646] malloc(0) checks for AIX 2009-10-11 17:33:02 -07:00
Love Hörnquist Åstrand
9ecc9345f6 use calloc to allocate salt
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@24990 ec53bebd-3082-4978-b11e-865c3cabbd6b
2009-03-29 09:03:15 +00:00
Love Hörnquist Åstrand
6937d41a02 remove trailing whitespace
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23815 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 09:21:03 +00:00
Love Hörnquist Åstrand
e172367898 switch to utf8 encoding of all files
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@23814 ec53bebd-3082-4978-b11e-865c3cabbd6b
2008-09-13 08:53:55 +00:00
Love Hörnquist Åstrand
75a6af0377 Set and clear password where appropriate.
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@15888 ec53bebd-3082-4978-b11e-865c3cabbd6b
2005-08-11 13:40:35 +00:00
Love Hörnquist Åstrand
c61ef0d7ab Move keyset parsing and password based keyset generation into hdb.
Requested by Andrew Bartlett <abartlet@samba.org> for hdb-ldb backend


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14297 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-10-11 23:50:25 +00:00
Love Hörnquist Åstrand
cf112007d1 (parse_key_set): do way with static returning (function) static
variable and returned allocated memory
(_kadm5_generate_key_set): free enctypes returned by parse_key_set


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14217 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-09-12 12:08:40 +00:00
Love Hörnquist Åstrand
f0aee06246 Fix memory leak, don't return stack variables
From Andrew Bartlett


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14199 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-09-06 11:39:10 +00:00
Love Hörnquist Åstrand
c9d296148a make all_etypes const and move outside function to avoid returning
data on stack


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14198 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-09-06 11:25:30 +00:00
Love Hörnquist Åstrand
423fef40e4 (_kadm5_generate_key_set): since arcfour-hmac-md5 is without salting,
some people tries to add the string "arcfour-hmac-md5" when they
really should have used "arcfour-hmac-md5:pw-salt", help them and add
glue for that


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14152 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-08-25 15:29:09 +00:00
Love Hörnquist Åstrand
6b07954615 (_kadm5_set_keys_randomly): make sure enctype to copy enctype for des keys
From: Andrew Bartlett <abartlet@samba.org>


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13409 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-02-29 06:12:50 +00:00
Love Hörnquist Åstrand
d420dc5958 (_kadm5_set_*): don't change the kvno, let the callee to that
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@13405 ec53bebd-3082-4978-b11e-865c3cabbd6b
2004-02-29 05:49:29 +00:00
Love Hörnquist Åstrand
1d1e4bc424 (_kadm5_set_keys_randomly): remove dup return
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12574 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-08-17 18:38:16 +00:00
Love Hörnquist Åstrand
599c39e257 use default_keys for the both random keys and password derived keys if
its defined


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12543 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-08-15 16:38:28 +00:00
Love Hörnquist Åstrand
3fef574a4e (make_keys): add aes support
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12402 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-06-25 23:56:58 +00:00
Love Hörnquist Åstrand
356775a1a0 fix off by one in the aes case, pointed out by Ken Raeburn
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12400 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-06-25 23:36:17 +00:00
Love Hörnquist Åstrand
2d2d16d817 (_kadm5_set_keys_randomly): add ETYPE_AES256_CTS_HMAC_SHA1_96 key when
configuried with aes support


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@12185 ec53bebd-3082-4978-b11e-865c3cabbd6b
2003-04-30 17:17:12 +00:00
Johan Danielsson
2dbc6b6ddf fix some problems with previous
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10490 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-08-13 15:12:16 +00:00
Johan Danielsson
85c00b0cfa add easier afs configuration, defaulting to the local realm in lower
case; also try to remove duplicate salts


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@10486 ec53bebd-3082-4978-b11e-865c3cabbd6b
2001-08-13 13:19:39 +00:00
Assar Westerlund
03594ac148 (make_keys): clean-up salting loop and try not to leak memory
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@9197 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-11-15 23:13:30 +00:00
Assar Westerlund
4f94484b76 (free_keys, init_keys): elevate to internal kadm5 functions
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8766 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-22 05:52:33 +00:00
Assar Westerlund
f30bc712c9 (make_keys): also support `[kadmin]use_v4_salt' for backwards
compatability


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8569 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-07-07 16:39:38 +00:00
Johan Danielsson
42641579fd (_kadm5_set_keys): rewrite this to be more easily adaptable to
different salts


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8458 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-06-26 14:22:02 +00:00
Assar Westerlund
5ca9dc1371 (_kadm5_set_keys2): rewrite
(_kadm5_set_keys3): add


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@8064 ec53bebd-3082-4978-b11e-865c3cabbd6b
2000-03-23 23:06:31 +00:00
Assar Westerlund
ed294c6619 (_kadm5_set_keys): make clearer by changing negative to possitive
condition


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7514 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-04 23:11:01 +00:00
Johan Danielsson
c5b916ca6f remove advertising clause
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7464 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-12-02 17:05:13 +00:00
Assar Westerlund
11c284c11e (_kadm5_set_keys_randomly): set enctypes correctly in the copied keys
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7299 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-11-04 01:55:50 +00:00
Assar Westerlund
adea1b4679 (free_keys): free more memory
(_kadm5_set_keys): a little bit more generic
(_kadm5_set_keys_randomly): new function for setting random keys.


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7167 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-17 15:11:57 +00:00
Assar Westerlund
907d81ab5c (_kadm5_set_keys): ignore old keys when setting new ones and always
add 3 DES keys and one 3DES key


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7143 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-14 13:02:06 +00:00
Assar Westerlund
14a833b452 comments
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@7103 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-10-03 20:16:21 +00:00
Assar Westerlund
81d02e26a3 (_kadm5_set_keys2): don't check the recently created memory for NULL
pointers


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6135 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-04 19:58:57 +00:00
Johan Danielsson
5865b0a4a4 remove free
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6100 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-03 17:14:22 +00:00
Johan Danielsson
6a32d5aeba clear mkvno
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6098 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-03 17:10:18 +00:00
Johan Danielsson
97edf08c22 add _kadm5_set_keys2 to sey keys from key_data
git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@6076 ec53bebd-3082-4978-b11e-865c3cabbd6b
1999-05-03 16:40:27 +00:00