oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

Fix memory leak, don't return stack variables

Browse Source 
From Andrew Bartlett


git-svn-id: svn://svn.h5l.se/heimdal/trunk/heimdal@14199 ec53bebd-3082-4978-b11e-865c3cabbd6b
This commit is contained in:
Love Hörnquist Åstrand
2004-09-06 11:39:10 +00:00
parent c9d296148a
commit f0aee06246
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/kadm5/set_keys.c
View File

@@ -129,7 +129,11 @@ parse_key_set(krb5_context context, const char *key,
/* if there is a final string, use it as the string to
salt with, this is mostly useful with null salt for
v4 compat, and a cell name for afs compat */
salt->saltvalue.data = buf[i];
salt->saltvalue.data = strdup(buf[i]);
if (salt->saltvalue.data == NULL) {
krb5_set_error_string(context, "malloc out of memory");
return ENOMEM;
}
salt->saltvalue.length = strlen(buf[i]);
}
}
@@ -291,10 +295,13 @@ _kadm5_generate_key_set(krb5_context context, krb5_principal principal,
if (j == *nkeyset) {
ret = add_enctype_to_key_set(&key_set, nkeyset, enctypes[i],
no_salt ? NULL : &salt);
if (ret)
if (ret) {
krb5_free_salt(context, salt);
goto out;
}
}
}
krb5_free_salt(context, salt);
}
out: