Don't scale SRV weights when none have weight zero

2016-11-13 15:06:40 +11:00
parent ee8b2b4253
commit da8052fefc
1 changed files with 2 additions and 1 deletions
--- a/lib/roken/resolve.c
+++ b/lib/roken/resolve.c
@@ -672,8 +672,9 @@ rk_dns_srv_order(struct rk_dns_reply *r)
 	    if ((*tt)->u.srv->weight == 0)
 		zeros++;
 	}
+	/* With no zeros, add 0 and scale * 1 */
+	sum += zeros ? zeros : zeros++;
 	sum *= zeros;
-	sum += zeros;
 	ee = tt;
 	/* ss is now the first record of this priority and ee is the
           first of the next */