oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

gss: don't provide domain to nsi_probe() in NTLM

Browse Source 
_gss_ntlm_accept_sec_context() does not provide the acceptor domain to
nsi_probe(); for consistency, _gss_ntlm_acquire_cred_from() should do that
same. Providing the acceptor domain was breaking tests.

Note that the Heimdal NTLM implementation is old and has few consumers (Apple
and Samba use their own implementations). Arguably we should merge the Apple
implementation or remove it.
This commit is contained in:
Luke Howard
2019-12-27 20:47:24 +11:00
parent bf14eb29df
commit c510e6d474
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/gssapi/ntlm/acquire_cred.c
View File

@@ -45,7 +45,6 @@ _gss_ntlm_acquire_cred_from(OM_uint32 *min_stat,
OM_uint32 *time_rec)
{
ntlm_name name = (ntlm_name) desired_name;
const char *domain = NULL;
OM_uint32 maj_stat;
ntlm_ctx ctx;
@@ -63,8 +62,7 @@ _gss_ntlm_acquire_cred_from(OM_uint32 *min_stat,
if (maj_stat != GSS_S_COMPLETE)
return maj_stat;
domain = name != NULL ? name->domain : NULL;
ret = (*ctx->server->nsi_probe)(min_stat, ctx->ictx, domain);
ret = (*ctx->server->nsi_probe)(min_stat, ctx->ictx, NULL);
{
gss_ctx_id_t context = (gss_ctx_id_t)ctx;
OM_uint32 junk;