oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

hdb: LDAP_message2entry fix ntPasswordIN leak

Browse Source 
free ntPasswordIN from all exit paths.  Do not leak it.

Change-Id: I90c5240439eefabca4458fe4791eb0de693a50f7
This commit is contained in:
Jeffrey Altman
2016-11-14 16:23:39 -05:00
parent 6ee0e99cf3
commit 95c2940a02
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/hdb/hdb-ldap.c
View File

@@ -1155,7 +1155,6 @@ LDAP_message2entry(krb5_context context, HDB * db, LDAPMessage * msg,
(ent->entry.keys.len + 1) *
sizeof(ent->entry.keys.val[0]));
if (ks == NULL) {
free(ntPasswordIN);
ret = ENOMEM;
krb5_set_error_message(context, ret, "malloc: out of memory");
goto out;
@@ -1166,7 +1165,6 @@ LDAP_message2entry(krb5_context context, HDB * db, LDAPMessage * msg,
ret = krb5_data_alloc (&ent->entry.keys.val[ent->entry.keys.len].key.keyvalue, 16);
if (ret) {
krb5_set_error_message(context, ret, "malloc: out of memory");
free(ntPasswordIN);
ret = ENOMEM;
goto out;
}
@@ -1459,8 +1457,8 @@ LDAP_message2entry(krb5_context context, HDB * db, LDAPMessage * msg,
ret = 0;
out:
if (unparsed_name)
free(unparsed_name);
free(unparsed_name);
free(ntPasswordIN);
if (ret)
hdb_free_entry(context, ent);