oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kadmin: refactor set_random_password

Browse Source 
Obtain the unparsed principal name early so that there is no
risk of memory allocation failure after kadm5_chpass_principal_3()
succeeds.

Change-Id: I389281004826da5752081c2f26127d55e3dc3989
This commit is contained in:
Jeffrey Altman
2022-01-21 00:31:56 -05:00
parent fb52fd1c53
commit 912b20c4d7
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
kadmin/cpw.c
View File

@@ -65,17 +65,17 @@ set_random_password (krb5_principal principal, int keepold)
{
krb5_error_code ret;
char pw[128];
char *princ_name;
random_password (pw, sizeof(pw));
ret = krb5_unparse_name(context, principal, &princ_name);
if (ret)
return ret;
random_password(pw, sizeof(pw));
ret = kadm5_chpass_principal_3(kadm_handle, principal, keepold, 0, NULL, pw);
if (ret == 0) {
char *princ_name;
krb5_unparse_name(context, principal, &princ_name);
if (ret == 0)
printf ("%s's password set to \"%s\"\n", princ_name, pw);
free (princ_name);
}
free(princ_name);
memset_s(pw, sizeof(pw), 0, sizeof(pw));
return ret;
}