oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kadmind: Fix uninitialized heap pointer use (#1051)

Browse Source
This commit is contained in:
Nicolas Williams
2022-12-19 18:06:24 -06:00
parent 8423016920
commit 8f71755d2b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/kadm5/marshall.c
View File

@@ -371,11 +371,11 @@ ret_principal_ent(krb5_storage *sp,
if (mask & KADM5_KEY_DATA) { if (mask & KADM5_KEY_DATA) {
CHECK(krb5_ret_int32(sp, &tmp)); CHECK(krb5_ret_int32(sp, &tmp));
princ->n_key_data = tmp; princ->n_key_data = tmp;
princ->key_data = malloc(princ->n_key_data * sizeof(*princ->key_data)); princ->key_data = calloc(princ->n_key_data, sizeof(*princ->key_data));
if (princ->key_data == NULL && princ->n_key_data != 0) if (princ->key_data == NULL && princ->n_key_data != 0)
return ENOMEM; return ENOMEM;
for(i = 0; i < princ->n_key_data; i++) for(i = 0; i < princ->n_key_data; i++)
ret = kadm5_ret_key_data(sp, &princ->key_data[i]); CHECK(kadm5_ret_key_data(sp, &princ->key_data[i]));
} }
if (mask & KADM5_TL_DATA) { if (mask & KADM5_TL_DATA) {
CHECK(krb5_ret_int32(sp, &tmp)); CHECK(krb5_ret_int32(sp, &tmp));