From 8f71755d2b4d2b51eb9aab98610ed72cca283b3e Mon Sep 17 00:00:00 2001 From: Nicolas Williams Date: Mon, 19 Dec 2022 18:06:24 -0600 Subject: [PATCH] kadmind: Fix uninitialized heap pointer use (#1051) --- lib/kadm5/marshall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/kadm5/marshall.c b/lib/kadm5/marshall.c index 9d24233ba..37c497ba3 100644 --- a/lib/kadm5/marshall.c +++ b/lib/kadm5/marshall.c @@ -371,11 +371,11 @@ ret_principal_ent(krb5_storage *sp, if (mask & KADM5_KEY_DATA) { CHECK(krb5_ret_int32(sp, &tmp)); princ->n_key_data = tmp; - princ->key_data = malloc(princ->n_key_data * sizeof(*princ->key_data)); + princ->key_data = calloc(princ->n_key_data, sizeof(*princ->key_data)); if (princ->key_data == NULL && princ->n_key_data != 0) return ENOMEM; for(i = 0; i < princ->n_key_data; i++) - ret = kadm5_ret_key_data(sp, &princ->key_data[i]); + CHECK(kadm5_ret_key_data(sp, &princ->key_data[i])); } if (mask & KADM5_TL_DATA) { CHECK(krb5_ret_int32(sp, &tmp));