drop hdb_fetch

lib/hdb/common.c

@@ -98,13 +98,6 @@ hdb_value2entry_alias(krb5_context context, krb5_data *value,
     return decode_hdb_entry_alias(value->data, value->length, ent, NULL);
 }
 
-krb5_error_code
-_hdb_fetch(krb5_context context, HDB *db, krb5_const_principal principal,
-	   unsigned flags, hdb_entry_ex *entry)
-{
-    return _hdb_fetch_kvno(context, db, principal, flags & (~HDB_F_KVNO_SPECIFIED), 0, entry);
-}
-
 krb5_error_code
 _hdb_fetch_kvno(krb5_context context, HDB *db, krb5_const_principal principal,
 		unsigned flags, krb5_kvno kvno, hdb_entry_ex *entry)

lib/hdb/db.c

@@ -318,7 +318,6 @@ hdb_db_create(krb5_context context, HDB **db,
     (*db)->hdb_capability_flags = HDB_CAP_F_HANDLE_ENTERPRISE_PRINCIPAL;
     (*db)->hdb_open = DB_open;
     (*db)->hdb_close = DB_close;
-    (*db)->hdb_fetch = _hdb_fetch;
     (*db)->hdb_fetch_kvno = _hdb_fetch_kvno;
     (*db)->hdb_store = _hdb_store;
     (*db)->hdb_remove = _hdb_remove;

lib/hdb/db3.c

@@ -348,7 +348,6 @@ hdb_db_create(krb5_context context, HDB **db,
     (*db)->hdb_capability_flags = HDB_CAP_F_HANDLE_ENTERPRISE_PRINCIPAL;
     (*db)->hdb_open  = DB_open;
     (*db)->hdb_close = DB_close;
-    (*db)->hdb_fetch = _hdb_fetch;
     (*db)->hdb_fetch_kvno = _hdb_fetch_kvno;
     (*db)->hdb_store = _hdb_store;
     (*db)->hdb_remove = _hdb_remove;

lib/hdb/hdb-keytab.c

@@ -221,7 +221,6 @@ hdb_keytab_create(krb5_context context, HDB ** db, const char *arg)
     (*db)->hdb_openp = 0;
     (*db)->hdb_open = hkt_open;
     (*db)->hdb_close = hkt_close;
-    (*db)->hdb_fetch = hkt_fetch;
     (*db)->hdb_fetch_kvno = hkt_fetch_kvno;
     (*db)->hdb_store = hkt_store;
     (*db)->hdb_remove = NULL;

lib/hdb/hdb-ldap.c

@@ -1878,7 +1878,6 @@ hdb_ldap_common(krb5_context context,
     (*db)->hdb_capability_flags = 0;
     (*db)->hdb_open = LDAP_open;
     (*db)->hdb_close = LDAP_close;
-    (*db)->hdb_fetch = LDAP_fetch;
     (*db)->hdb_fetch_kvno = LDAP_fetch_kvno;
     (*db)->hdb_store = LDAP_store;
     (*db)->hdb_remove = LDAP_remove;

lib/hdb/hdb-mitdb.c

@@ -743,7 +743,6 @@ hdb_mdb_create(krb5_context context, HDB **db,
     (*db)->hdb_capability_flags = 0;
     (*db)->hdb_open = mdb_open;
     (*db)->hdb_close = mdb_close;
-    (*db)->hdb_fetch = mdb_fetch;
     (*db)->hdb_fetch_kvno = mdb_fetch_kvno;
     (*db)->hdb_store = mdb_store;
     (*db)->hdb_remove = mdb_remove;

lib/hdb/hdb-sqlite.c

@@ -875,7 +875,6 @@ hdb_sqlite_create(krb5_context context, HDB **db, const char *argument)
     (*db)->hdb_unlock = hdb_sqlite_unlock;
     (*db)->hdb_firstkey = hdb_sqlite_firstkey;
     (*db)->hdb_nextkey = hdb_sqlite_nextkey;
-    (*db)->hdb_fetch = hdb_sqlite_fetch;
     (*db)->hdb_fetch_kvno = hdb_sqlite_fetch_kvno;
     (*db)->hdb_store = hdb_sqlite_store;
     (*db)->hdb_remove = hdb_sqlite_remove;

lib/hdb/hdb.h

@@ -74,7 +74,7 @@ typedef struct hdb_master_key_data *hdb_master_key;
 /**
  * hdb_entry_ex is a wrapper structure around the hdb_entry structure
  * that allows backends to keep a pointer to the backing store, ie in
- * ->hdb_fetch(), so that we the kadmin/kpasswd backend gets around to
+ * ->hdb_fetch_kvno(), so that we the kadmin/kpasswd backend gets around to
  * ->hdb_store(), the backend doesn't need to lookup the entry again.
  */
 
@@ -123,15 +123,6 @@ typedef struct HDB{
      * Free an entry after use.
      */
     void	    (*hdb_free)(krb5_context, struct HDB*, hdb_entry_ex*);
-    /**
-     * Fetch an entry from the backend
-     *
-     * Fetch an entry from the backend, flags are what type of entry
-     * should be fetch: client, server, krbtgt.
-     */
-    krb5_error_code (*hdb_fetch)(krb5_context, struct HDB*,
-				 krb5_const_principal, unsigned, 
-				 hdb_entry_ex*);
     /**
      * Fetch an entry from the backend
      *

lib/hdb/keytab.c

@@ -211,17 +211,10 @@ hdb_get_entry(krb5_context context,
 	goto out2;
     }
     
-    if (*db->hdb_fetch_kvno) {
-	    ret = (*db->hdb_fetch_kvno)(context, db, principal,
-					HDB_F_DECRYPT|HDB_F_KVNO_SPECIFIED|
-					HDB_F_GET_CLIENT|HDB_F_GET_SERVER|HDB_F_GET_KRBTGT,
-					kvno, &ent);
-    } else {
-	    ret = (*db->hdb_fetch)(context, db, principal,
-				   HDB_F_DECRYPT|
-				   HDB_F_GET_CLIENT|HDB_F_GET_SERVER|HDB_F_GET_KRBTGT,
-				   &ent);
-    }
+    ret = (*db->hdb_fetch_kvno)(context, db, principal,
+				HDB_F_DECRYPT|HDB_F_KVNO_SPECIFIED|
+				HDB_F_GET_CLIENT|HDB_F_GET_SERVER|HDB_F_GET_KRBTGT,
+				kvno, &ent);
 
     if(ret == HDB_ERR_NOENTRY) {
 	ret = KRB5_KT_NOTFOUND;

lib/hdb/ndbm.c

@@ -370,7 +370,6 @@ hdb_ndbm_create(krb5_context context, HDB **db,
     (*db)->hdb_capability_flags = HDB_CAP_F_HANDLE_ENTERPRISE_PRINCIPAL;
     (*db)->hdb_open = NDBM_open;
     (*db)->hdb_close = NDBM_close;
-    (*db)->hdb_fetch = _hdb_fetch;
     (*db)->hdb_fetch_kvno = _hdb_fetch_kvno;
     (*db)->hdb_store = _hdb_store;
     (*db)->hdb_remove = _hdb_remove;