oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

hdb: fix leaks in alias handling

Browse Source 
fetch_entry_or_alias() in libhdb failed to free the alias DB value or
principal, causing a leak
This commit is contained in:
Luke Howard
2021-08-05 16:05:45 +10:00
parent 510ee92c11
commit 5a56198161
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/hdb/common.c
View File

@@ -184,11 +184,14 @@ fetch_entry_or_alias(krb5_context context,
} else if (ret == 0 && eoa.element == choice_HDB_EntryOrAlias_alias) {
krb5_data_free(&key);
ret = hdb_principal2key(context, eoa.u.alias.principal, &key);
if (ret == 0)
if (ret == 0) {
krb5_data_free(&value);
ret = db->hdb__get(context, db, key, &value);
}
if (ret == 0)
/* No alias chaining */
ret = hdb_value2entry(context, &value, &entry->entry);
krb5_free_principal(context, eoa.u.alias.principal);
} else if (ret == 0)
ret = ENOTSUP;
if (ret == 0 && enterprise_principal) {