oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

hdb: Tolerate duplicate aliases

Browse Source 
One user had an entry with duplicate aliases.  This happened with an
earlier version of Heimdal.

This commit does not remove the duplicates, but it does tolerate them.
This commit is contained in:
Nicolas Williams
2022-03-23 15:01:06 -05:00
parent d172a8bd79
commit 2f6a276251
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/hdb/common.c
View File

@@ -411,6 +411,8 @@ hdb_remove_aliases(krb5_context context, HDB *db, krb5_data *key)
if (code == 0) {
code = db->hdb__del(context, db, akey);
krb5_data_free(&akey);
if (code == HDB_ERR_NOENTRY)
code = 0;
}
if (code) {
free_HDB_entry(&oldentry);
@@ -446,6 +448,12 @@ hdb_add_aliases(krb5_context context, HDB *db,
if (code == 0) {
code = db->hdb__put(context, db, flags, key, value);
krb5_data_free(&key);
if (code == HDB_ERR_EXISTS)
/*
* Assuming hdb_check_aliases() was called, this must be a
* duplicate in the alias list.
*/
code = 0;
}
krb5_data_free(&value);
if (code)