oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

base: Fix CID 1518898 Resource leak

Browse Source 
Don't leak new_node if invalid node type in heim_path_vcreate()
This commit is contained in:
Luke Howard
2023-01-04 18:14:28 +11:00
committed by Nicolas Williams
parent f2b25c1493
commit 2a594a3bd1
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/base/heimbase.c
View File

@@ -967,16 +967,12 @@ heim_path_vcreate(heim_object_t ptr, size_t size, heim_object_t leaf,
if (node_type == HEIM_TID_DICT) {
ret = heim_dict_set_value(node, path_element, new_node);
heim_release(new_node);
next_node = heim_dict_get_value(node, path_element);
} else if (node_type == HEIM_TID_ARRAY &&
heim_number_get_int(path_element) <= heim_array_get_length(node)) {
ret = heim_array_insert_value(node,
heim_number_get_int(path_element),
new_node);
heim_release(new_node);
next_node = heim_array_get_value(node, idx);
} else {
ret = EINVAL;
@@ -984,6 +980,8 @@ heim_path_vcreate(heim_object_t ptr, size_t size, heim_object_t leaf,
*error = heim_error_create(ret, "Node in path not a "
"container");
}
heim_release(new_node);
if (ret)
goto err;
}