oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

kadmin: add_one_namespace do not leak princ_ent

Browse Source 
princ_ent must be saved to princ.principal early in order to
ensure that it is not leaked.

Change-Id: Ic74b48f434c727401c00e6fdcaecead988fe4263
This commit is contained in:
Jeffrey Altman
2022-01-16 23:42:21 -05:00
parent 54adba6023
commit 231aa68895
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
kadmin/ank.c
View File

@@ -391,6 +391,8 @@ add_one_namespace(const char *name,
ret = krb5_parse_name(context, name, &princ_ent); ret = krb5_parse_name(context, name, &princ_ent);
if (ret) if (ret)
krb5_warn(context, ret, "krb5_parse_name"); krb5_warn(context, ret, "krb5_parse_name");
else
princ.principal = princ_ent;
} }
if (ret != 0) if (ret != 0)
return ret; return ret;
@@ -449,7 +451,6 @@ add_one_namespace(const char *name,
} }
if (ret == 0) { if (ret == 0) {
princ.principal = princ_ent;
mask |= KADM5_PRINCIPAL | KADM5_KVNO; mask |= KADM5_PRINCIPAL | KADM5_KVNO;
ret = set_entry(context, &princ, &mask, ret = set_entry(context, &princ, &mask,