From 231aa688956bda3819386a5335e10b7425bb2d60 Mon Sep 17 00:00:00 2001
From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Sun, 16 Jan 2022 23:42:21 -0500
Subject: [PATCH] kadmin: add_one_namespace do not leak princ_ent

princ_ent must be saved to princ.principal early in order to
ensure that it is not leaked.

Change-Id: Ic74b48f434c727401c00e6fdcaecead988fe4263
---
 kadmin/ank.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kadmin/ank.c b/kadmin/ank.c
index 3683c38ad..f633121c1 100644
--- a/kadmin/ank.c
+++ b/kadmin/ank.c
@@ -391,6 +391,8 @@ add_one_namespace(const char *name,
         ret = krb5_parse_name(context, name, &princ_ent);
         if (ret)
             krb5_warn(context, ret, "krb5_parse_name");
+	else
+	    princ.principal = princ_ent;
     }
     if (ret != 0)
 	return ret;
@@ -449,7 +451,6 @@ add_one_namespace(const char *name,
     }
 
     if (ret == 0) {
-        princ.principal = princ_ent;
         mask |= KADM5_PRINCIPAL | KADM5_KVNO;
 
         ret = set_entry(context, &princ, &mask,