oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

hdb: hdb_ldap_common NULL dereference

Browse Source 
In hdb_ldap_common() the test

  if (search_base == NULL && search_base[0] == '\0')
     error handling ...

must be

  if (search_base == NULL || search_base[0] == '\0')
     error handling ...

Change-Id: I8d876a9c56833431b3c4b582fbb0a8cc7353893d
This commit is contained in:
Jeffrey Altman
2016-11-14 16:33:51 -05:00
parent 95c2940a02
commit 19e8852697
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/hdb/hdb-ldap.c
View File

@@ -1905,7 +1905,7 @@ hdb_ldap_common(krb5_context context,
url = p; url = p;
} }
if (search_base == NULL && search_base[0] == '\0') { if (search_base == NULL || search_base[0] == '\0') {
krb5_set_error_message(context, ENOMEM, "ldap search base not configured"); krb5_set_error_message(context, ENOMEM, "ldap search base not configured");
return ENOMEM; /* XXX */ return ENOMEM; /* XXX */
} }