oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

krb5: check return value in krb5_get[_cache]_next()

Browse Source 
krb5_get_next() and krb5_get_cache_next() do not check for krb5_kcm_call()
returning non-zero before accessing the repsonse data; they only handle the
case where the return value is KRB5_CC_END.

Return immediately if the return value of krb5_kcm_call() is not KRB5_CC_END or
0. This was fixed in the Apple code.
This commit is contained in:
Luke Howard
2021-06-16 12:09:19 +10:00
parent be3a640b69
commit 0452d8c601
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/krb5/kcm.c
View File

@@ -674,7 +674,8 @@ kcm_get_next (krb5_context context,
krb5_storage_free(request);
if (ret == KRB5_CC_END) {
goto again;
}
} else if (ret)
return ret;
ret = krb5_ret_creds(response, creds);
if (ret)
@@ -902,6 +903,8 @@ kcm_get_cache_next(krb5_context context, krb5_cc_cursor cursor, const krb5_cc_op
krb5_storage_free(request);
if (ret == KRB5_CC_END)
goto again;
else if (ret)
return ret;
ret = krb5_ret_stringz(response, &name);
krb5_storage_free(response);