oysteikt/heimdal
0
0
Fork 0
Code Issues 5 Pull Requests Releases Activity

gss: avoid overflow in gss_inquire_cred()

Browse Source 
See #791

Make found a boolean rather than a count of found mechanisms.
This commit is contained in:
Luke Howard
2021-08-06 12:22:09 +10:00
parent 5a56198161
commit 034bc1649d
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/gssapi/mech/gss_inquire_cred.c
View File

@@ -56,7 +56,7 @@ gss_inquire_cred(OM_uint32 *minor_status,
struct _gss_name *name; struct _gss_name *name;
struct _gss_mechanism_name *mn; struct _gss_mechanism_name *mn;
OM_uint32 min_lifetime; OM_uint32 min_lifetime;
int found = 0; int found = FALSE;
int usagemask = 0; int usagemask = 0;
gss_cred_usage_t usage; gss_cred_usage_t usage;
@@ -133,7 +133,7 @@ gss_inquire_cred(OM_uint32 *minor_status,
if (mechanisms) if (mechanisms)
gss_add_oid_set_member(minor_status, gss_add_oid_set_member(minor_status,
mc->gmc_mech_oid, mechanisms); mc->gmc_mech_oid, mechanisms);
found++; found = TRUE;
} }
} else { } else {
HEIM_TAILQ_FOREACH(m, &_gss_mechs, gm_link) { HEIM_TAILQ_FOREACH(m, &_gss_mechs, gm_link) {
@@ -174,7 +174,7 @@ gss_inquire_cred(OM_uint32 *minor_status,
if (mechanisms) if (mechanisms)
gss_add_oid_set_member(minor_status, gss_add_oid_set_member(minor_status,
m->gm_mech_oid, mechanisms); m->gm_mech_oid, mechanisms);
found++; found = TRUE;
} }
} }
@@ -189,7 +189,7 @@ gss_inquire_cred(OM_uint32 *minor_status,
} }
} }
if (found == 0 || min_lifetime == 0) { if (found == FALSE || min_lifetime == 0) {
gss_name_t n = (gss_name_t)name; gss_name_t n = (gss_name_t)name;
if (n) if (n)
gss_release_name(minor_status, &n); gss_release_name(minor_status, &n);