Various fixes for package de/serialization #9

Merged

frero merged 5 commits from various-fixes into hovudgren

2026-05-13 09:31:33 +02:00

oysteikt commented

2026-05-12 13:45:38 +02:00

Owner

These changes should make package de/serialization a bit more robust.

The most important line here is change to recv body, because earlier it would fetch body_size + 2 bytes, but the struct only had space to store the body_size (including the last nullbyte). If I'm reading it correctly, this could've potentially caused an overflow.

Haven't really tested this against a proper RCON server, should probably do so first tihi

These changes should make package de/serialization a bit more robust. The most important line here is change to `recv` body, because earlier it would fetch `body_size + 2` bytes, but the struct only had space to store the `body_size` (including the last nullbyte). If I'm reading it correctly, this could've potentially caused an overflow. Haven't really tested this against a proper RCON server, should probably do so first tihi

oysteikt added 5 commits 2026-05-12 13:45:40 +02:00