Projects/grzegorz-clients
Projects/grzegorz-clients
7
1
Fork 0
Code Issues 1 Pull Requests 1 Wiki Activity

webui: handle playback_pos response with empty contents #13

Merged
oysteikt merged 1 commits from handle-empty-playback-pos-response into master 2024-08-05 21:16:57 +02:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
oysteikt commented 2024-08-04 01:52:11 +02:00
Owner
Copy Link

Compatibility with changes made in 93366593c7. Should have no real effect on the original grzegorz API.

Compatibility with changes made in https://git.pvv.ntnu.no/oysteikt/mpvipc-async/commit/93366593c78819123cb122b322cc245e718d955a. Should have no real effect on the original grzegorz API.
oysteikt added 1 commit 2024-08-04 01:52:11 +02:00
oysteikt requested review from pederbs 2024-08-04 01:52:17 +02:00
pederbs reviewed 2024-08-04 03:56:26 +02:00
grzegorz_clients/remi_ui.py Outdated
@ -295,3 +295,3 @@
playback_pos = None
if playback_pos:
if playback_pos and playback_pos["current"] and playback_pos["total"]:
pederbs commented 2024-08-04 02:43:31 +02:00
Member
Copy Link
			if playback_pos and isinstance(playback_pos, dict) and "current" in playback_pos and "total" in playback_pos:
```suggestion if playback_pos and isinstance(playback_pos, dict) and "current" in playback_pos and "total" in playback_pos: ```
👍 1
pederbs commented 2024-08-04 02:43:51 +02:00
Member
Copy Link

ellers får du KeyError

ellers får du KeyError
pederbs commented 2024-08-04 03:57:09 +02:00
Member
Copy Link

glemte å godkjenne pending comments...

<sup>glemte å godkjenne pending comments...<sup>
oysteikt marked this conversation as resolved
oysteikt force-pushed handle-empty-playback-pos-response from 5d1538b370 to 771275cf84 2024-08-04 13:19:19 +02:00 Compare
pederbs reviewed 2024-08-04 21:09:38 +02:00
grzegorz_clients/remi_ui.py Outdated
@ -298,0 +298,4 @@
playback_pos,
isinstance(playback_pos, dict),
playback_pos["current"],
playback_pos["total"],
pederbs commented 2024-08-04 21:09:38 +02:00
Member
Copy Link

                "current" in playback_pos,
                "total" in playback_pos,

jeg antar at Option betyr keyen er optional, og ikke at verdien er nullable?

``` "current" in playback_pos, "total" in playback_pos, ``` jeg antar at `Option` betyr keyen er optional, og ikke at verdien er nullable?
pederbs commented 2024-08-04 21:11:24 +02:00
Member
Copy Link

hvis både nullable og optional er kansje dette det du trenger

                "current" in playback_pos,
                 "total" in playback_pos,
                 playback_pos["current"] is not None,
                 playback_pos["total"] is not None,
hvis både nullable og optional er kansje dette det du trenger ``` "current" in playback_pos, "total" in playback_pos, playback_pos["current"] is not None, playback_pos["total"] is not None, ```
oysteikt commented 2024-08-04 21:17:46 +02:00
Author
Owner
Copy Link

Option betyr bare nullable. Det er som en haskell Maybe. Serialisert til json med Nones, så eksisterer feltene med verdi null.

`Option` betyr bare nullable. Det er som en haskell `Maybe`. Serialisert til json med `None`s, så eksisterer feltene med verdi `null`.
pederbs commented 2024-08-04 23:51:20 +02:00
Member
Copy Link

👍

:+1:
pederbs marked this conversation as resolved
pederbs reviewed 2024-08-04 23:51:08 +02:00
pederbs left a comment
Member
Copy Link

denne koden kommer til å brekke hvis playback_pos = None, fordi playback_pos["current"] blir eagerly evaluated av kallet til all, som vil kaste en typefeil. Det er bedre på bruke en rekke av and i disse tilfellene fordi de blir short-circuited ved første False

denne koden kommer til å brekke hvis `playback_pos = None`, fordi `playback_pos["current"]` blir eagerly evaluated av kallet til `all`, som vil kaste en typefeil. Det er bedre på bruke en rekke av `and` i disse tilfellene fordi de blir short-circuited ved første `False`
oysteikt force-pushed handle-empty-playback-pos-response from 771275cf84 to 132cabf434 2024-08-05 17:53:20 +02:00 Compare
oysteikt commented 2024-08-05 17:53:38 +02:00
Author
Owner
Copy Link

sjukt. lazy python when

sjukt. lazy python when
oysteikt requested review from pederbs 2024-08-05 17:54:01 +02:00
pederbs approved these changes 2024-08-05 21:00:13 +02:00
oysteikt merged commit cb292a56b1 into master 2024-08-05 21:16:57 +02:00
oysteikt deleted branch handle-empty-playback-pos-response 2024-08-05 21:16:57 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
pederbs
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

  
art

The issue needs someone to be creative

  
big

No, not bug, **big** - this is gonna take a while

  
blocked

This issue/PR depends on one or more other issues/PRs

  
bug

Something is not working, and it's not the shield hero

  
ci-cd

Continuous integrals and continuous derivation

  
crash report

Report an oopsie

  
disputed

Kranglefanter

  
documentation

Documentation changes required

  
duplicate

This issue or pull request already exists

  
feature request

New feature

  
good first issue

Get your hands dirty with a new project here

  
packaging

Relates to distribution of the software

  
question

More information is needed

  
security

Skommel

  
techdebt spring cleaning

The code is smelly 👃

  
testing

Poke it and see if it explodes

  
wontfix

This won't be fixed

No Label
bug
dependencies
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
art
big
blocked
bug
ci-cd
crash report
disputed
documentation
duplicate
feature request
good first issue
packaging
question
security
techdebt spring cleaning
testing
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Projects/grzegorz-clients#13
No description provided.
Delete Branch "handle-empty-playback-pos-response"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?