Grzegorz/crystal-orb
1
1
Fork 0
Code Issues 3 Pull Requests Releases Activity

rewrite to using argparse #2

Merged
bjornoka merged 3 commits from dev into main 2025-03-01 23:01:33 +01:00
Conversation 1 Commits 3 Files Changed 1 +58 -90
bjornoka commented 2025-02-08 23:55:52 +01:00
Owner
Copy Link
No description provided.
bjornoka added 2 commits 2025-02-08 23:55:54 +01:00
Rewrite of cli to using argparse 9d1566c360
Handling for responses with already departed buses 958cdc6ba8
oysteikt reviewed 2025-03-01 13:31:48 +01:00
crystal_orb_cli.py Outdated
@@ -99,0 +86,4 @@
parser.add_argument("-s", "--stop",
help="limit output to only the supplied stop place")
# No argument
oysteikt commented 2025-03-01 13:30:45 +01:00
Owner
Copy Link

The term usage is a bit confusing here, considering argument kinda already refers to a command line argument in this context. Maybe Requiring value and No value, or alternatively With value and Boolean flags would be better candidates for comments?

The term usage is a bit confusing here, considering `argument` kinda already refers to a command line argument in this context. Maybe `Requiring value` and `No value`, or alternatively `With value` and `Boolean flags` would be better candidates for comments?
crystal_orb_cli.py Outdated
@@ -156,0 +118,4 @@
deps = list(filter(lambda d: str(d.line) == args.bus, deps))
if args.to:
deps = list(filter(lambda d: d.towards_midtbyen, deps))
if args.__dict__["from"]: # from is a reserved keyword in python
oysteikt commented 2025-03-01 13:26:39 +01:00
Owner
Copy Link

Consider using

parser.add_argument(
  "-f",
  "--from",
  action="store_true",
  dest="from_",
  help="show only buses going away from town",
)

...

if args.from_:
  ...
Consider using ```python parser.add_argument( "-f", "--from", action="store_true", dest="from_", help="show only buses going away from town", ) ... if args.from_: ... ```
crystal_orb_cli.py Outdated
@@ -156,0 +119,4 @@
if args.to:
deps = list(filter(lambda d: d.towards_midtbyen, deps))
if args.__dict__["from"]: # from is a reserved keyword in python
deps = list(filter(lambda d: not d.towards_midtbyen, deps))
oysteikt commented 2025-03-01 13:28:21 +01:00
Owner
Copy Link

I see these are not really part of the change, but they could be a bit more readable if written as comprehensions

deps = [d for d in deps if not d.towards_midtbyen]
I see these are not really part of the change, but they could be a bit more readable if written as comprehensions ```python deps = [d for d in deps if not d.towards_midtbyen] ```
bjornoka force-pushed dev from 0656b7f2b1 to b756581e35 2025-03-01 22:56:49 +01:00 Compare
bjornoka changed title from WIP: rewrite to using argparse to rewrite to using argparse 2025-03-01 22:57:24 +01:00
bjornoka merged commit e6f97f3bad into main 2025-03-01 23:01:33 +01:00
bjornoka deleted branch dev 2025-03-01 23:01:33 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
oysteikt
Labels
Clear labels
art
Requires some creativity
 big
This is gonna take a while
 blocked
This issue/PR depends on one or more other issues/PRs
 bug
Something brokey
 ci-cd
Continuous integrals and continuous derivation
 crash report
Report an oopsie
 disputed
Kranglefanter
 documentation
Documentation changes required
 duplicate
This issue or pull request already exists
 feature request
good first issue
Get your hands dirty with a new project here
 me gusta
( ͡° ͜ʖ ͡°)
 packaging
question
security
Skommel
 techdebt spring cleaning
The code is smelly 👃
 testing
Poke it and see if it explodes
 ui/ux
User complaints about ergonomics and economics and whatever
 wontfix
Nei, vil ikke
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
aadneto aakvik aalborg aalstad aamotp aarbo aarbogh aardal aarsathe aarsland aase aasgard aasmundf aastabk aasulv aasum aavik abach abbe abe adamcik adland adler admirm adriangl afzal agnetha agulbra ahan ahj aida aidao ailo ainasm aishamh aiw akai akervold akselh alang albertba albertov aleksagg aleksanw aleksawa aleksfl alekskn alem alexanbe alexandk alexanns alexanro alfborge alfheim alfhj alier almaas almelid alsberg ama amalieem ambolt amfolle aminmb ammm amundbk amundg amundt andeb andegg andepete anderaus anderen anderlin anders andersav andersja andersm andersr anderss anderssv andersul andfaer andholst andreaas andreabr andreac andreahan andreahd andreahy andreai andreajo andreakn andreala andreamu andreani andreao andrearn andrearo andreasa andreasd andreasj andreau andreb andrebr andreer andrehag andrehei andrels andremis andrerav andreseh andresen andrew andrfla andrfri andrgarc andrhag andrph andrs anehen aneilert angeliys angelvik anho anishkn anitaash anitahal annabhe annaet annefin annikeoy annom anthony antn antoniml arev arildg arildna arildsat arildto arnebak arneberg arnebl arnehall arnehoeg arnej arnema arner arneso arnfinn arni arnstein arnstekl arnstelj arntf arntj arntovg arntrich arntsc arstad arveha asbjorh asbjorjo asbjornb asbjs asgaut asgeirbj askgf aslakeg aslakg aslakr asmunder asmundg asmundo asoes asphjell astauh astor atgeirr atlas atlel atlep atlesa audunf audunh audunp audunwi aursand austig austvik bakksjo balazsf balchen baltzers bao bardm bardsk barek bartiver bayegan bcd bcnguyen bct becken beide beitnes bendikb benediam bengtdan bengtola benjaben benjamin benoil berge bergea bergerse bergheim bergma bergquis beritm beritrt berland bernhard berntj berntjd berntp berrum bgitv bgrotan bhs bieker bif birkedal bjarnesk bjarno bjarteha bjartka bjelland bjerkeli bjerkhau bjoe bjoflo bjohan bjorgpeg bjorgum bjorlod bjorn bjornart bjorncol bjornein bjornelv bjorneng bjorneru bjornes bjornfro bjorngl bjornhaa bjornhol bjorning bjornlar bjornn bjornoka bjornsen bjornsh bjornson bjorsko bjorstad bkh blix bmt boberg bodda borgarlj borud bos bp bragege brager bragetn brandser brasetvi bratseth bratt breivik bremnes brianj briktw brill broker bronner brotmet bru brygfjel brynjaa buck buro buttings bwalaker byberg camile camillah camillfl camillmg carl carlaa carolisa cat cath chrian chribra chriege chrijon chrischa chrisfjo chrishoh chrisl chrismo christbu christla christte christtg christyo chrisvik chriswg chritell chrivi chrvl cian cifci ck cph crukis cs cthuv dag dageriv dagfinba dagfs daghals dagih dagkrist dagr dagurval dahlberg dahlseng dalseide damhaug danber danielch danielsa danio dankri darrud davidk davidn davidsun davood dean dehnavi deinoff dennisgl dessoula devgun dfkoren dhmyrdal difool dingsoyr dispen dixie djuvslan dog dovland drolsham dungby duong dyret dyrset ecsvihus eddie edgarahi edmundfo edsberg efteland egbr egeberg egilha egiljor egilt ehn eide eielsen einara einarbh einarflo einarnyb einarr einhalv eirikald eirikni eirikref eirikri eirikros eiriksp eiriktve eirikwie eirikwit eirivaa eivindgi eivindhe eivindos eivindp eivindsi eivindsm eivindsy eivindve eivinklo eivinlar eivinlst eivinmik ejr ekb ekbirkt ekremsvi eldrid elenkp eliasaa eliasgg elinfr elinkris elinsynn elisajor ellena ellingst elna emanuelm embh embretse emilga emilh emiltayl emmalei endreb endrs enebakk engelbre engelsen erfani erikad erikane erikaxel erikbi erikboge erike erikft erikga erikgors erikheg erikhoff eriklio erikoest erikref eriksti erikviho erleb erlendbu erlendhl erlendjo erlendso erlendwa erlendwi erlenp erlenv erlinga erlingal erlingbo erlingh erlingt erlinha ermesjo eskild espen espenaf espenamo espenbe espenbuo espeneko espengan espenjor espenlur espenmol espenrj espensa espensn espenso espenste espenw espes evenbruv eveneny evenh evenhunn evenlu evenml evju eyvind eyvindsm fageraas fagerlun faleide farner farup fate faub felixalb fellingh feness fgorseth fidjelan filipko finnag finngun finninde fjelddal fjellska flatberg fledsber flobak floriahc folgero fonnum fore formo forthun frankaa frankja franklan franksh frede fredj fredrih fredrihl fredrils fredrio fredrior fredris fredrre fredrsk frero fresvig friisk frodeheg frodejoh frodelu frodery frodeste frodesto frodevik frodnyg frodo frodsa fromel fuglem fvlarsen gabosnes gad gaksnes galaen gards garfors garsjo gartland gautela gautesv geirbak geirbo geirhe geirhel geirhyn geirkri geirm geirme geirot geirove geirso geirt georgevp ghahrama gidskeha gimme gislee gislesen gisletv gisnas gitea gjendems gjerde gjerding gjerlaug gjestela glaserud glennrub glesaaen gnan godal gombos gomezmor gonnet gormr gotteber graesli graham gran grannas granskog grastvei grimelid grimen grondahl gronvold groo grotli grovli grymeret grytting grytv gsi gudbrand gudmesta guise gulars gulla gullik gunde gunnag gunnarre gunnmari guro gusdal gustavb gustavf ha haakongv haavabj haavard haavasny hafting hageland haheim haip hakonal hakoneid hakongud hakonha hakonhag hakonhal hakonho hakonhum hakont hakonuna hal hallsteo hallum halset halsteis halvard halvorlu hamberg hammar hammer hanche hannemo hans hansbakk hansbohl hanscho hansei hanserfr hansfe hansfu hansgt hansgu hansgust hansjorg hanskria hanskrib hansm hansmary hansorst hanspl hanstb hao haolsen harahu harald haralde haraldhv haraldms haraldv haralesp harals hardeb harg harkesta harstad haskjold hatlevik haugwarb havanor havarasb havarbj havardda havarden havardma havardpe havardsa havardw havare havarmor havarnor havarv hbjoerge hcf hcholm he hebjor hegecp hegg heggenes heia heidit heie heimdal helenh helge helgelf helgeli helgem helgetho helgetor hellemo helliese hembre henan henningg henninss henrikej henrikmo henrikn henrikru henriksa henrikva henrkgr henrolss henryss hep herbjorn hernesg hersoug hessvik heyerdah hez hgs hhande hhansen hholm hiasen hilde hjanbu hjelle hjortas hjulstad hmg hnygaard hoanghuy hoerdt hoiby hoiem hoivik holme holtan hommedal hongve hopenh houeland houmb hovardst hove hovet hovik howard hoyland hoyum hoyvik hr hsairola hsd hstroem hsundt hta htnguyen hugogu hunting hveem hyh idara idarf idavilhe igorai iharkest ihle ilebrekk ilsegv imran imranm inebeate ingar ingeaa ingebf ingefl ingegrel ingekr ingema ingerje ingerld ingevik ingfal ingmundb ingridan ingridch ingridwo ingulf ingunnev ingvarl ingves innvar instanes inx ivanbrox ivarfo ivarh iverjo jabentze jabirali jaceks jacobbl jacobfg jaer jahnarne jakobsve janalexa janborc janbu janeirik janerivi jang janharal janlang jano janol janover janovesk janpetar jantorm janvegar janwa jardarab jarle jarlea jarlejo jarleli jarlerik jarlih jatotal jb jbs jensadne jensberg jensdam jenslien jensm jenswerg jervell jesperno jhf jhofstad jian jih jimv jine jjs jla jlr jnygaard joachbet joachimj joakim joakimb joakimv joaralbe jodahl jodal joern jofo joge joh joha johain johanf johangud johannbh johanno johansam johanslo johanste johnarne johnche johndoe johnja johnkeg johnno johnnyhn jonajha jonandbr jonasbru jonasgb jonashau jonashm jonaslaa jonasr jonaukle jonee jonfinng jonhelge jonhet joniteig jonivar jonkaare jonkrit jonmro jonph jonry jonvidar jorabra joran jorgeer jorgekva jorgelia jorgenba jorgenbo jorgengb jorgenhl jorgenpt jorgenre jorgenru jorgens jorgensa jorgensn jorgensy jorgenv jorgeope jorgerei jorgerh jorgesh jornbalt jornskaa jorunm jorunnbj josk josteif josteih josteitv josteiu jovre jtm jto jukka junero kaaredo kaasin kaiarneg kaihugoh kailaise kailaiva kailasan kair kaiwilli kajetan kalbekke kalle kantun kareblak karevoll karije karimg karineu karingl karlaho karlau karlmort karolds karsteb kasbj kasli kaspesko kathareh kathinka kathinkr katrine katrinro katrintj kayare kayly kayste kaze kel kennetbj kennetgu kennethf kennethm kennetso kentda kenth kenthuev ketilba ketilel kevint khanghyv kietve killingd kim kimam kimasu kimdha kimera kimk kinekver kirkerod kirkhus kiro kirr kjallohl kjd kjekshus kjellaks kjellhoy kjellomd kjellr kjellrg kjerkrei kjetihag kjetihel kjetijor kjetilar kjetilod kjetilof kjolstad kjsv klausod klauss klavenes klemm klovegra kmgodlun kmr kms knausgar knukva knuta knutande knuteivi knutel knuthus knutinh knutjv knutmoe knutpett knutroe knuts knutsiem knutson kolbrek kolla kollstad kolstad kongsvol konstahm kopseng kor korsvoll kovalev kqn kragset krinorm krisgry krishov krisibe krisleri krisn krisni krispet krisskol krist kristerk kristhen kristiag kristiam kristie kristiho kristink kristiod kristito kristjas kristmon kristn kristofd kristoju kristoop kristovm kristree kristrot kristwaa kriu krogdahl krogruf krogsate kroknes kulia kvadrat kvamtro kvasbo kvelstad kvernlan kybkokos kybkokos2 kyrres labee lace lamn langemyh langli lango lardal larehauk larsans larsarne larsbj larsboy larschri larsedin larseie larsell larserm larsers larsevp larsfod larsgua larsh larsha larshand larshelg larshhan larsjh larslru larsnu larspe larsr larssen larssoll larssto larstobi larstoc lasse lasseka laukus laurie lauries laurits lauritz lbj leanh leb lehamre lehre leifan leifchl leifhama leifm leifmk leifo leifrich leifwar leirbakk lejensen lekang leomv leon lesjo levy lexow liadal lian liangzh liene liengs ligu liland liljebac lilleber lilleng lilles limi lindahl lindan lindasor lindbak lindkvis liodden lisajon lisbebo lisebul litleham litsheim litus lium ljosa ljs loen lolien lonnum loo lopen lorentz lottegl lottegr lovmoen lovold lovslett ludvigse luhr lulf lunde lunderen lykkebo lyngaas lyngstad lysgaard madsb madsbern madsho madsop magdalel magnele magnesa magnio magnj magnublo magnugje magnuh magnul magnurei magnusdo magnusga magnushe magnusrk magnuss magnute mail2news mailnews maitramt majatni maland malinkro maltseva manhoang manyil marenksa margarib margrej mariabar mariaj mariaksk marialn marianh mariare mariasto maribro marieri marismes maritama maritek marith maritpe mariufa mariusbu mariushb mariusko marivold markiewi markure markusk markusw markuswh martcl martefo martel martes martheg martibo martiepe martinf martinju martinn martinno martinsl martinsv martirus martista martiste martstr marvik maseide mateustk mathg mathia mathiajb mathias mathiasm mathilie mathiric mathis matiasj matilde matsa matsgora matsjoru matslin matthie matti mattissa maukon mauset maxandre mdreier mehdimm mehus meldahl melheim meling melissay mendoza mettehsj michaeno michaet michalro mikael mikaelg mikal mikaled mikkeleg milch milvang minh minht mjelde mkje mkloster mlh modalsli mohammat mohammed molmann monani monica monicjoh moraus mortebre morteham mortehar mortelil mortelun morteme mortenab mortene mortenkn mortenl mortenmj mortenmo mortenro mortenry mortens mortenwe mortet mortew mortsa moseng mossin mosveen mrbravo mskvam msromero mtr mufridk muhammhm munz musum myhr mylvagan mynors nagaling narve naveed nazanin nch neergaar nelberg nelson neshatn nesheim ngocdand ngocthan nicholge nielsen nielsenl nikolaha nikolaru nilsg nilsga nilsgri nilshau nilsol nims nina ninaknu ninalinn njall njaln nome noone norangsh norasom nordeng nsaa nummedal objarte obrestad oceanev odberg odd oddall oddarns oddbjoh oddbjorr odderi odderik odderikf oddske odinhoff oes ofheggum ohrbom oivindd okloster oksenhol ola olaeld olafb olajacob olapeter olavbr olavs olavsth olb olechrg olechrin oleerikb olegil olegr oleholt olejakk olejohpe olekribu olekvi olemrus olepetr olepett olesk olet olived olsbo oma omenaas omermb opdahl optimus orbekk orjane orjansa orstavik oscar oscarss ostring otadahl oust ovegram ovekp overhold ovstetun oyei oyoy oyskog oysteaar oysteibu oysteigi oysteih oysteikt oysteina oysteine oysteini oysteiur oysteiv oystela oystesk oystestr oystethu oysth oystharb oyvinda oyvindaa oyvindel oyvindkn oyvindmo oyvindro oyving oyvinhha oyvinht oyvinlek oyvinlin oyvins oyvne paaf paalbro pahr paknutse palaanu palho palhoas paljoaki paljoh palkrim pallo palry palt patricm paxbonum pcjuel pearce pederbs pederda pederho pederka pedernot pedro peina peiw per perbje perbli perboge perchrh perezfer perhakon perhov perjarle perjohn perjonen perkrih perme peroi perr perraymo perroe2 persson pes petek peterahj peterl petteha petterei petterfo petterk piafiska pjberg pladsen pllobiun pom pot power prange prometheus-exporter pronstad pstene pvv pyotrk pyrrhael raaness ragnarkj ragnvald rakhmato ramez rand randhol raymondd refnin refsum reidarst reiersen rekdal remi remo reneky rhamm richarah rickardk rickarj ridowu riis rikardb rikardhd rike rikkes risla risvik roara roarkahr roarl roart roberm robertbo robertem robertla roberto robertve roffe rogde rogerand rogerj rogerjon rogerskj roksvaag rolfen rolferr rolfh rolfn rolfsn ronnywa roopann rornes rossgard rosting royal royhenni royhenri rsandnes rsp rstenbro runar runarbel runarj runarjoh runarylv runasand runask runeald runeanm runeberg runefr runeg runegri runehavn runek runekn runenes runesk runeska runesp runeste runholm rydland ryeng rygg rygh rygvold sab sageflat sanctuary sanderby sandergk sandseth sandvar sangar sangeepa santhira sao sarahkj saravo sater satereng scarboro scheen schei schistad schmidt schneide schwenke sebasthg sebastka sedding seime seljelid sen seolsen sergiob sesse setnan shammer shane shansen shazbot shd sigbjonk sigmunau sigmund sigmundo signy sigrissv sigrusk sigurdal sigurdga sigurdno sigurdp sigurse sigveseb sigvetj siljeih simeh simenesp simenfur simira simongli simonj simonjbi sin sindher sindos sindrebe sindreil sindreso sindrhpa sirimah siriml sivmidtu sjn sjonfjel sjovold sjovoll sjurhass skagemo skar skarding skarland skilling skjaeret skjelten skjersli skjoldho skogaas skogstro skomedal skretteb skuland skyttere slj sloreby smb smedvig smestad smg smistad smorgrav sms snerting snh snove snuggeru soelvef sofie sogge solas sollied solmajab solveigs solvejo somaen sondelan sondresb sondresc sondrety sondrhel sondrmik sondroda sondrso sondrtha sonus sorby sos soso sovik spaans spederse spreeman srs ssb ssstolen stadskle stain stalee stalep stava stavik staw stba stefanc stefanhe steffent steffev steina steinage steinak steinaka steinakn steinal steinamo steinara steinare steinarh steinhau steinjak steinjl steinjoa steinl steinlau steinola steinroa steinrs steinsiv steinsli steintor stenbock stenerps stenhaug stenvik stiaje stian stianalm stiankri stianmy stianse stiansjo stiantha stig stighal stiginge stigmov stigove stigpo stigvi stihir stinelie stisa stm storeide storkers storms stornes storvold strumke sturlaj sturleha sundnes sundsdal sunnisko svar svedjan svegla sveinare sveinb sveinfid sveingun sveinhal sveinmb sveinsol sveinugu sveinwem svendsen svenerb svenhab svenn svennico sventy swahn syljua synnovsh syrstad tahe tala talefjel tan tandle tangstad tangvald tanial tarek tarjeia tarjeik tarjeil tathran tawabf tberg tbi tcelind tcgoudoe teg tegdan tegge tengesda terjeand terjebak terjebr terjeeri terjenil terjero terjeros terjesal terjesc terjeto terjkri terland tesdal testbruker2309 testbruker2404 tfheen thaco thammer thangdu theres thomaajo thomafo thomakar thomamn thomasag thomasfh thomasg thomaso thomasod thomasoo thomasq thomasr thomassa thomassk thomasst thomawt thombo thomj thomkjo thorars thorben thorha thorsen thorvan thrane thuam thyl tidemann tih tinderho tirilane titlesta tjerands tjonnas tjosthei tlan tli tmolbach toaster tobben tobiasbj tobiasg tofte toj tom tombre tomhauk tomic tommybo tommyd tommyrsa tomrh tonemol tonesma tonnesla topdal toralft torarnek torarnly torb torbad torberg torbjlan torbjoos torbjot torbjovn torbjs tordr tordtons toream toreb toreber torebu toredale torehau toreid toreide torekol torerit tores toresk toreste torewilh torfer torgeihe torgeiho torgeim torgeira torgeirb torgerk torgrih torgunna torholg torhr toringe toriver torjehoa torkar torkildf torkildl torkri torleifs torleift tormagt tormodg tormodh tormyr tornil tornor torp torr torsetne torsk torsted torstehe torstehu torsteno torsthal torunm torvill tosh tossebro tovehof triujequ troeste trondaas trondat trondbl trondkri trondos tronhaug trons tronseth trulsamu trulsjo trulsknu tryeng trygvei trygvelu trygvrad ttr tubaas tuftin turkey twdahl tyridal tysseng ulfa ulfkri ulflunde vaksdal valentp valvatne van vandvik vardehau vaultwarden vea vedder vegardbm vegarded vegardha vegardkh vegarwe vemundr venaas vengen veronga versvik vetlene vevle vibekel viberg vidaral vidarhol vidaros vidarton vidarv vigfus viggoa vikholt vincent vindvad virsb vistnes vlarsen vsonerud vub vunguyen waagen walberg wale walle wallenti walvik wasim wenhaug wennberg werner wersland westbye wettland wibeken wikshala willa williah williaj williha worlund xinyilu yairk yamenz yaoling yngjoh yngvebj yngves yngvesy yngvetus yorinad zirvap zobel
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Grzegorz/crystal-orb#2
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?