.gitea/workflows/check.yml

@@ -0,0 +1,22 @@
+name: "Run shellcheck on shellscripts"
+on:
+  pull_request:
+  push:
+jobs:
+  check:
+    runs-on: debian-latest
+    steps:
+    - uses: actions/checkout@v6
+
+    - name: Install shellcheck
+      run: apt-get install --update --assume-yes shellcheck
+
+    - name: Run shellcheck on backup.sh
+      # NOTE: We have a lot of variables that are referenced through indirection,
+      #       leading to a lot of false positives for SC2034: "foo appears unused".
+      #       See https://www.shellcheck.net/wiki/SC2034 for more details.
+      run: shellcheck --exclude=SC2034 backup.sh
+
+    - name: Run shellcheck on clean_snapshots.sh
+      run: shellcheck clean_snapshots.sh
+

.gitignore

@@ -1,13 +1,17 @@
 # Ignorer alt som standard
 *
 
-# Inkluder følgende filer i git-repoet
+# Inkluder følgende filer og kataloger i git-repoet
 !/.gitignore
 !/backup.sh
 !/clean_snapshots.sh
 !/ssh_config_backup_targets
 !/homepvv.exclude
 
+!/.gitea/
+!/.gitea/workflows/
+!/.gitea/workflows/*
+
 # Git må kunne se `ssh_extra_keys` mappen, men alt annet inni den skal ignoreres
 !/ssh_extra_keys/
 /ssh_extra_keys/*

clean_snapshots.sh

@@ -8,10 +8,10 @@ export LESSCHARSET=utf-8
 	echo i skallet igjen.
 	echo
 	echo
-	
+
 	zfs list -r -t snapshot -o name,used principal/backupz/homepvv |
-		tail -n +2 | 
-		while read snap size; do 
-			echo zfs destroy $snap \# $size;
+		tail -n +2 |
+		while read -r snap size; do
+			echo zfs destroy "$snap" \# "$size";
 		done
-) # | less -R
+) # | less -R