From a783b5cf5d1d9072c8c37764f3038b25c7c15401 Mon Sep 17 00:00:00 2001 From: h7x4 Date: Sun, 24 May 2026 20:33:04 +0900 Subject: [PATCH 1/2] clean_snapshots.sh: fiks advarsler fra shellcheck --- clean_snapshots.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/clean_snapshots.sh b/clean_snapshots.sh index 2209a9d..d93c0e1 100755 --- a/clean_snapshots.sh +++ b/clean_snapshots.sh @@ -8,10 +8,10 @@ export LESSCHARSET=utf-8 echo i skallet igjen. echo echo - + zfs list -r -t snapshot -o name,used principal/backupz/homepvv | - tail -n +2 | - while read snap size; do - echo zfs destroy $snap \# $size; + tail -n +2 | + while read -r snap size; do + echo zfs destroy "$snap" \# "$size"; done -) # | less -R \ No newline at end of file +) # | less -R -- 2.54.0 From 786462bbcf22c57635152a5855fbc431ba57aec8 Mon Sep 17 00:00:00 2001 From: h7x4 Date: Sun, 24 May 2026 20:34:00 +0900 Subject: [PATCH 2/2] .gitea/workflows/check: legg ved en CI jobb som ser over shellskript --- .gitea/workflows/check.yml | 22 ++++++++++++++++++++++ .gitignore | 6 +++++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 .gitea/workflows/check.yml diff --git a/.gitea/workflows/check.yml b/.gitea/workflows/check.yml new file mode 100644 index 0000000..1323138 --- /dev/null +++ b/.gitea/workflows/check.yml @@ -0,0 +1,22 @@ +name: "Run shellcheck on shellscripts" +on: + pull_request: + push: +jobs: + check: + runs-on: debian-latest + steps: + - uses: actions/checkout@v6 + + - name: Install shellcheck + run: apt-get install --update --assume-yes shellcheck + + - name: Run shellcheck on backup.sh + # NOTE: We have a lot of variables that are referenced through indirection, + # leading to a lot of false positives for SC2034: "foo appears unused". + # See https://www.shellcheck.net/wiki/SC2034 for more details. + run: shellcheck --exclude=SC2034 backup.sh + + - name: Run shellcheck on clean_snapshots.sh + run: shellcheck clean_snapshots.sh + diff --git a/.gitignore b/.gitignore index 1866959..d926197 100644 --- a/.gitignore +++ b/.gitignore @@ -1,13 +1,17 @@ # Ignorer alt som standard * -# Inkluder følgende filer i git-repoet +# Inkluder følgende filer og kataloger i git-repoet !/.gitignore !/backup.sh !/clean_snapshots.sh !/ssh_config_backup_targets !/homepvv.exclude +!/.gitea/ +!/.gitea/workflows/ +!/.gitea/workflows/* + # Git må kunne se `ssh_extra_keys` mappen, men alt annet inni den skal ignoreres !/ssh_extra_keys/ /ssh_extra_keys/* -- 2.54.0