release v0.23.14

Without this, the AMD64 build installs to "lib64/" which then cannot
be found by CURL.

NEWS

@@ -1,3 +1,55 @@
+ver 0.23.14 (2023/10/08)
+* decoder
+  - flac: fix scanning files with non-ASCII names on Windows
+  - mad: fix calculation of LAME peak values
+* mixer
+  - wasapi: fix problem setting volume
+* more libfmt 10 fixes
+* fix auto-detected systemd unit directory
+* Android
+  - require Android 7 or newer
+
+ver 0.23.13 (2023/05/22)
+* input
+  - curl: fix busy loop after connection failed
+  - curl: hide "404" log messages for non-existent ".mpdignore" files
+* archive
+  - zzip: fix crash bug
+* database
+  - simple: reveal hidden songs after deleting containing CUE
+* decoder
+  - ffmpeg: reorder to a lower priority than "gme"
+  - gme: require GME 0.6 or later
+* output
+  - pipewire: fix corruption bug due to missing lock
+* Linux
+  - shut down if parent process dies in --no-daemon mode
+  - determine systemd unit directories via pkg-config
+* support libfmt 10
+
+ver 0.23.12 (2023/01/17)
+* input
+  - curl: require CURL 7.55.0 or later
+* decoder
+  - mad: fix integer underflow with very small files
+* tags
+  - fix crash bug due to race condition
+* output
+  - pipewire: adjust to PipeWire 0.3.64 API change
+* fix build failures with GCC 13
+
+ver 0.23.11 (2022/11/28)
+* database
+  - simple: move default database to ~/.cache/mpd/db from ~/.cache/mpd.db
+  - simple: default "cache_directory" to ~/.cache/mpd/mounts
+* macOS: fix build failure "no archive members specified"
+* Windows
+  - fix crash bug (stack buffer overflow) after I/O errors
+  - fix path traversal bug because backslash was allowed in playlist names
+* Android/Windows
+  - update OpenSSL to 3.0.7
+  - re-enable CURL's verbose error strings
+
 ver 0.23.10 (2022/10/14)
 * storage
   - curl: fix file time stamps

android/AndroidManifest.xml

@@ -2,10 +2,10 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
           package="org.musicpd"
           android:installLocation="auto"
-          android:versionCode="69"
+          android:versionCode="72"
-          android:versionName="0.23.10">
+          android:versionName="0.23.14">
 
-  <uses-sdk android:minSdkVersion="21" android:targetSdkVersion="30"/>
+  <uses-sdk android:minSdkVersion="24" android:targetSdkVersion="30"/>
 
   <uses-feature android:name="android.software.leanback"
                 android:required="false" />

android/build.py

@@ -20,130 +20,13 @@ if not os.path.isdir(ndk_path):
     print("NDK not found in", ndk_path, file=sys.stderr)
     sys.exit(1)
 
-android_abis = {
-    'armeabi-v7a': {
-        'arch': 'arm-linux-androideabi',
-        'ndk_arch': 'arm',
-        'llvm_triple': 'armv7-linux-androideabi',
-        'cflags': '-fpic -mfpu=neon -mfloat-abi=softfp',
-    },
-
-    'arm64-v8a': {
-        'arch': 'aarch64-linux-android',
-        'ndk_arch': 'arm64',
-        'llvm_triple': 'aarch64-linux-android',
-        'cflags': '-fpic',
-    },
-
-    'x86': {
-        'arch': 'i686-linux-android',
-        'ndk_arch': 'x86',
-        'llvm_triple': 'i686-linux-android',
-        'cflags': '-fPIC -march=i686 -mtune=intel -mssse3 -mfpmath=sse -m32',
-    },
-
-    'x86_64': {
-        'arch': 'x86_64-linux-android',
-        'ndk_arch': 'x86_64',
-        'llvm_triple': 'x86_64-linux-android',
-        'cflags': '-fPIC -m64',
-    },
-}
-
-# select the NDK target
-abi_info = android_abis[android_abi]
-arch = abi_info['arch']
-
 # the path to the MPD sources
 mpd_path = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]) or '.', '..'))
 sys.path[0] = os.path.join(mpd_path, 'python')
 
 # output directories
 from build.dirs import lib_path, tarball_path, src_path
-from build.meson import configure as run_meson
+from build.toolchain import AndroidNdkToolchain
-
-arch_path = os.path.join(lib_path, arch)
-build_path = os.path.join(arch_path, 'build')
-
-# build host configuration
-build_arch = 'linux-x86_64'
-
-# set up the NDK toolchain
-
-class AndroidNdkToolchain:
-    def __init__(self, tarball_path, src_path, build_path,
-                 use_cxx):
-        self.tarball_path = tarball_path
-        self.src_path = src_path
-        self.build_path = build_path
-
-        ndk_arch = abi_info['ndk_arch']
-        android_api_level = '21'
-
-        install_prefix = os.path.join(arch_path, 'root')
-
-        self.arch = arch
-        self.actual_arch = arch
-        self.install_prefix = install_prefix
-
-        llvm_path = os.path.join(ndk_path, 'toolchains', 'llvm', 'prebuilt', build_arch)
-        llvm_triple = abi_info['llvm_triple'] + android_api_level
-
-        common_flags = '-Os -g'
-        common_flags += ' ' + abi_info['cflags']
-
-        llvm_bin = os.path.join(llvm_path, 'bin')
-        self.cc = os.path.join(llvm_bin, 'clang')
-        self.cxx = os.path.join(llvm_bin, 'clang++')
-        common_flags += ' -target ' + llvm_triple
-
-        common_flags += ' -fvisibility=hidden -fdata-sections -ffunction-sections'
-
-        self.ar = os.path.join(llvm_bin, 'llvm-ar')
-        self.ranlib = os.path.join(llvm_bin, 'llvm-ranlib')
-        self.nm = os.path.join(llvm_bin, 'llvm-nm')
-        self.strip = os.path.join(llvm_bin, 'llvm-strip')
-
-        self.cflags = common_flags
-        self.cxxflags = common_flags
-        self.cppflags = ' -isystem ' + os.path.join(install_prefix, 'include')
-        self.ldflags = ' -L' + os.path.join(install_prefix, 'lib') + \
-            ' -Wl,--exclude-libs=ALL' + \
-            ' ' + common_flags
-        self.ldflags = common_flags
-        self.libs = ''
-
-        self.is_arm = ndk_arch == 'arm'
-        self.is_armv7 = self.is_arm and 'armv7' in self.cflags
-        self.is_aarch64 = ndk_arch == 'arm64'
-        self.is_windows = False
-
-        libstdcxx_flags = ''
-        libstdcxx_cxxflags = ''
-        libstdcxx_ldflags = ''
-        libstdcxx_libs = '-static-libstdc++'
-
-        if self.is_armv7:
-            # On 32 bit ARM, clang generates no ".eh_frame" section;
-            # instead, the LLVM unwinder library is used for unwinding
-            # the stack after a C++ exception was thrown
-            libstdcxx_libs += ' -lunwind'
-
-        if use_cxx:
-            self.cxxflags += ' ' + libstdcxx_cxxflags
-            self.ldflags += ' ' + libstdcxx_ldflags
-            self.libs += ' ' + libstdcxx_libs
-
-        self.env = dict(os.environ)
-
-        # redirect pkg-config to use our root directory instead of the
-        # default one on the build host
-        import shutil
-        bin_dir = os.path.join(install_prefix, 'bin')
-        os.makedirs(bin_dir, exist_ok=True)
-        self.pkg_config = shutil.copy(os.path.join(mpd_path, 'build', 'pkg-config.sh'),
-                                      os.path.join(bin_dir, 'pkg-config'))
-        self.env['PKG_CONFIG'] = self.pkg_config
 
 # a list of third-party libraries to be used by MPD on Android
 from build.libs import *
@@ -165,13 +48,17 @@ thirdparty_libs = [
 
 # build the third-party libraries
 for x in thirdparty_libs:
-    toolchain = AndroidNdkToolchain(tarball_path, src_path, build_path,
+    toolchain = AndroidNdkToolchain(mpd_path, lib_path,
+                                    tarball_path, src_path,
+                                    ndk_path, android_abi,
                                     use_cxx=x.use_cxx)
     if not x.is_installed(toolchain):
         x.build(toolchain)
 
 # configure and build MPD
-toolchain = AndroidNdkToolchain(tarball_path, src_path, build_path,
+toolchain = AndroidNdkToolchain(mpd_path, lib_path,
+                                tarball_path, src_path,
+                                ndk_path, android_abi,
                                 use_cxx=True)
 
 configure_args += [

doc/conf.py

@@ -38,7 +38,10 @@ author = 'Max Kellermann'
 # built documents.
 #
 # The short X.Y version.
-version = '0.23.10'
+with open('../meson.build') as f:
+    import re
+    version = re.match(r"project\([^\)]*\bversion:\s*'([^']+)'",
+                       f.read(4096)).group(1)
 # The full version, including alpha/beta/rc tags.
 #release = version + '~git'
 
@@ -47,7 +50,7 @@ version = '0.23.10'
 #
 # This is also used if you do content translation via gettext catalogs.
 # Usually you set "language" from the command line for these cases.
-language = None
+language = "en"
 
 # There are two options for replacing |today|: either, you set today to some
 # non-false value, then it is used:

doc/index.rst

@@ -11,6 +11,12 @@ Music Player Daemon
    client
    protocol
 
+.. toctree::
+   :maxdepth: 1
+   :caption: man pages:
+
+   mpd.1
+   mpd.conf.5
 
 Indices and tables
 ==================

doc/mpdconf.example

@@ -181,7 +181,7 @@
 #
 #database {
 #       plugin "simple"
-#       path "~/.local/share/mpd/db
+#       path "~/.local/share/mpd/db"
 #       cache_directory "~/.local/share/mpd/cache"
 #}
 #
@@ -314,6 +314,7 @@ input {
 ##	device		"Digital Audio (S/PDIF) (High Definition Audio Device)" # optional
 #		or
 ##	device		"0"		# optional
+##	mixer_type	"hardware"	# optional
 ## Exclusive mode blocks all other audio source, and get best audio quality without resampling.
 ##	exclusive	"no"		# optional
 ## Enumerate all devices in log.

doc/plugins.rst

@@ -219,8 +219,9 @@ Opens remote files or streams over HTTP using libcurl.
 
 Note that unless overridden by the below settings (e.g. by setting
 them to a blank value), general curl configuration from environment
-variables such as ``http_proxy`` or specified in :file:`~/.curlrc`
+variables such as ``http_proxy`` will be in effect.
-will be in effect.
+
+User name and password are read from an optional :file:`~/.netrc`, :file:`~/.curlrc` is not read.
 
 .. list-table::
    :widths: 20 80
@@ -1114,7 +1115,7 @@ Connect to a `PipeWire <https://pipewire.org/>`_ server.  Requires
    * - **target NAME**
      - Link to the given target.  If not specified, let the PipeWire
        manager select a target.  To get a list of available targets,
-       type ``pw-cli dump short Node``
+       type ``pw-cli ls Node``
    * - **remote NAME**
      - The name of the remote to connect to.  The default is
        ``pipewire-0``.

doc/user.rst

@@ -611,6 +611,11 @@ If ReplayGain is enabled, then the setting ``replaygain_preamp`` is
 set to a value (in dB) between ``-15`` and ``15``.  This is the gain
 applied to songs with ReplayGain tags.
 
+On songs without ReplayGain tags, the setting
+``replaygain_missing_preamp`` is used instead.  If this setting is not
+configured, then no ReplayGain is applied to such songs, and they will
+appear too loud.
+
 ReplayGain is usually implemented with a software volume filter (which
 prevents `Bit-perfect playback`_).  To use a hardware mixer, set
 ``replay_gain_handler`` to ``mixer`` in the ``audio_output`` section
@@ -656,9 +661,11 @@ MPD enables MixRamp if:
 - Cross-fade is enabled
 - :ref:`mixrampdelay <command_mixrampdelay>` is set to a positive
   value, e.g.::
+
     mpc mixrampdelay 1
 - :ref:`mixrampdb <command_mixrampdb>` is set to a reasonable value,
   e.g.::
+
     mpc mixrampdb -17
 - both songs have MixRamp tags
 - both songs have the same audio format (or :ref:`audio_output_format`

meson.build

@@ -1,7 +1,7 @@
 project(
   'mpd',
   ['c', 'cpp'],
-  version: '0.23.10',
+  version: '0.23.14',
   meson_version: '>= 0.56.0',
   default_options: [
     'c_std=c11',
@@ -205,7 +205,6 @@ enable_daemon = not is_windows and not is_android and get_option('daemon')
 conf.set('ENABLE_DAEMON', enable_daemon)
 
 conf.set('HAVE_GETPWNAM_R', compiler.has_function('getpwnam_r'))
-conf.set('HAVE_GETPWUID_R', compiler.has_function('getpwuid_r'))
 conf.set('HAVE_INITGROUPS', compiler.has_function('initgroups'))
 conf.set('HAVE_FNMATCH', compiler.has_function('fnmatch'))
 
@@ -390,6 +389,7 @@ endif
 
 if enable_database
   sources += [
+    'src/storage/StorageState.cxx',
     'src/queue/PlaylistUpdate.cxx',
     'src/command/StorageCommands.cxx',
     'src/command/DatabaseCommands.cxx',

python/build/autotools.py

@@ -1,26 +1,32 @@
 import os.path, subprocess, sys
+from typing import Collection, Iterable, Optional, Sequence, Union
+from collections.abc import Mapping
 
 from build.makeproject import MakeProject
+from .toolchain import AnyToolchain
 
 class AutotoolsProject(MakeProject):
-    def __init__(self, url, md5, installed, configure_args=[],
+    def __init__(self, url: Union[str, Sequence[str]], md5: str, installed: str,
-                 autogen=False,
+                 configure_args: Iterable[str]=[],
-                 autoreconf=False,
+                 autogen: bool=False,
-                 cppflags='',
+                 autoreconf: bool=False,
-                 ldflags='',
+                 per_arch_cflags: Optional[Mapping[str, str]]=None,
-                 libs='',
+                 cppflags: str='',
-                 subdirs=None,
+                 ldflags: str='',
+                 libs: str='',
+                 subdirs: Optional[Collection[str]]=None,
                  **kwargs):
         MakeProject.__init__(self, url, md5, installed, **kwargs)
         self.configure_args = configure_args
         self.autogen = autogen
         self.autoreconf = autoreconf
+        self.per_arch_cflags = per_arch_cflags
         self.cppflags = cppflags
         self.ldflags = ldflags
         self.libs = libs
         self.subdirs = subdirs
 
-    def configure(self, toolchain):
+    def configure(self, toolchain: AnyToolchain) -> str:
         src = self.unpack(toolchain)
         if self.autogen:
             if sys.platform == 'darwin':
@@ -35,27 +41,48 @@ class AutotoolsProject(MakeProject):
 
         build = self.make_build_path(toolchain)
 
+        arch_cflags = ''
+        if self.per_arch_cflags is not None and toolchain.host_triplet is not None:
+            arch_cflags = self.per_arch_cflags.get(toolchain.host_triplet, '')
+
         configure = [
             os.path.join(src, 'configure'),
             'CC=' + toolchain.cc,
             'CXX=' + toolchain.cxx,
-            'CFLAGS=' + toolchain.cflags,
+            'CFLAGS=' + toolchain.cflags + ' ' + arch_cflags,
-            'CXXFLAGS=' + toolchain.cxxflags,
+            'CXXFLAGS=' + toolchain.cxxflags + ' ' + arch_cflags,
             'CPPFLAGS=' + toolchain.cppflags + ' ' + self.cppflags,
             'LDFLAGS=' + toolchain.ldflags + ' ' + self.ldflags,
             'LIBS=' + toolchain.libs + ' ' + self.libs,
             'AR=' + toolchain.ar,
+            'ARFLAGS=' + toolchain.arflags,
             'RANLIB=' + toolchain.ranlib,
             'STRIP=' + toolchain.strip,
-            '--host=' + toolchain.arch,
             '--prefix=' + toolchain.install_prefix,
-            '--enable-silent-rules',
+            '--disable-silent-rules',
-        ] + self.configure_args
+        ]
+
+        if toolchain.host_triplet is not None:
+            configure.append('--host=' + toolchain.host_triplet)
+
+        configure.extend(self.configure_args)
+
+        try:
+            print(configure)
+            subprocess.check_call(configure, cwd=build, env=toolchain.env)
+        except subprocess.CalledProcessError:
+            # dump config.log after a failed configure run
+            try:
+                with open(os.path.join(build, 'config.log')) as f:
+                    sys.stdout.write(f.read())
+            except:
+                pass
+            # re-raise the exception
+            raise
 
-        subprocess.check_call(configure, cwd=build, env=toolchain.env)
         return build
 
-    def _build(self, toolchain):
+    def _build(self, toolchain: AnyToolchain) -> None:
         build = self.configure(toolchain)
         if self.subdirs is not None:
             for subdir in self.subdirs:

python/build/cmake.py

@@ -1,17 +1,21 @@
 import os
+import re
 import subprocess
+from typing import cast, Optional, Sequence, TextIO, Union
+from collections.abc import Mapping
 
 from build.project import Project
+from .toolchain import AnyToolchain
 
-def __write_cmake_compiler(f, language, compiler):
+def __write_cmake_compiler(f: TextIO, language: str, compiler: str) -> None:
     s = compiler.split(' ', 1)
     if len(s) == 2:
         print(f'set(CMAKE_{language}_COMPILER_LAUNCHER {s[0]})', file=f)
         compiler = s[1]
     print(f'set(CMAKE_{language}_COMPILER {compiler})', file=f)
 
-def __write_cmake_toolchain_file(f, toolchain):
+def __write_cmake_toolchain_file(f: TextIO, toolchain: AnyToolchain) -> None:
-    if '-darwin' in toolchain.actual_arch:
+    if toolchain.is_darwin:
         cmake_system_name = 'Darwin'
     elif toolchain.is_windows:
         cmake_system_name = 'Windows'
@@ -20,67 +24,99 @@ def __write_cmake_toolchain_file(f, toolchain):
 
     f.write(f"""
 set(CMAKE_SYSTEM_NAME {cmake_system_name})
-set(CMAKE_SYSTEM_PROCESSOR {toolchain.actual_arch.split('-', 1)[0]})
+set(CMAKE_SYSTEM_PROCESSOR {toolchain.host_triplet.split('-', 1)[0]})
 
-set(CMAKE_C_COMPILER_TARGET {toolchain.actual_arch})
+set(CMAKE_C_COMPILER_TARGET {toolchain.host_triplet})
-set(CMAKE_CXX_COMPILER_TARGET {toolchain.actual_arch})
+set(CMAKE_CXX_COMPILER_TARGET {toolchain.host_triplet})
 
-set(CMAKE_C_FLAGS "{toolchain.cflags} {toolchain.cppflags}")
+set(CMAKE_C_FLAGS_INIT "{toolchain.cflags} {toolchain.cppflags}")
-set(CMAKE_CXX_FLAGS "{toolchain.cxxflags} {toolchain.cppflags}")
+set(CMAKE_CXX_FLAGS_INIT "{toolchain.cxxflags} {toolchain.cppflags}")
 """)
     __write_cmake_compiler(f, 'C', toolchain.cc)
     __write_cmake_compiler(f, 'CXX', toolchain.cxx)
 
-def configure(toolchain, src, build, args=()):
+    if cmake_system_name == 'Darwin':
-    cross_args = []
+        # On macOS, cmake forcibly adds an "-isysroot" flag even if
+        # one is already present in the flags variable; this breaks
+        # cross-compiling for iOS, and can be worked around by setting
+        # the CMAKE_OSX_SYSROOT variable
+        # (https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html).
+        m = re.search(r'-isysroot +(\S+)', toolchain.cflags)
+        if m:
+            sysroot = m.group(1)
+
+            print(f'set(CMAKE_OSX_SYSROOT {sysroot})', file=f)
+
+            # search libraries and headers only in the sysroot, not on
+            # the build host
+            f.write(f"""
+set(CMAKE_FIND_ROOT_PATH "{toolchain.install_prefix};{sysroot}")
+set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
+set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
+""")
+
+def configure(toolchain: AnyToolchain, src: str, build: str, args: list[str]=[], env: Optional[Mapping[str, str]]=None) -> None:
+    cross_args: list[str] = []
 
     if toolchain.is_windows:
-        cross_args.append('-DCMAKE_RC_COMPILER=' + toolchain.windres)
+        cross_args.append('-DCMAKE_RC_COMPILER=' + cast(str, toolchain.windres))
-
-    # Several targets need a sysroot to prevent pkg-config from
-    # looking for libraries on the build host (TODO: fix this
-    # properly); but we must not do that on Android because the NDK
-    # has a sysroot already
-    if '-android' not in toolchain.actual_arch and '-darwin' not in toolchain.actual_arch:
-        cross_args.append('-DCMAKE_SYSROOT=' + toolchain.install_prefix)
-
-    os.makedirs(build, exist_ok=True)
-    cmake_toolchain_file = os.path.join(build, 'cmake_toolchain_file')
-    with open(cmake_toolchain_file, 'w') as f:
-        __write_cmake_toolchain_file(f, toolchain)
 
     configure = [
         'cmake',
         src,
 
-        '-DCMAKE_TOOLCHAIN_FILE=' + cmake_toolchain_file,
-
         '-DCMAKE_INSTALL_PREFIX=' + toolchain.install_prefix,
         '-DCMAKE_BUILD_TYPE=release',
 
         '-GNinja',
     ] + cross_args + args
 
-    subprocess.check_call(configure, env=toolchain.env, cwd=build)
+    if toolchain.host_triplet is not None:
+        # cross-compiling: write a toolchain file
+        os.makedirs(build, exist_ok=True)
+
+        # Several targets need a sysroot to prevent pkg-config from
+        # looking for libraries on the build host (TODO: fix this
+        # properly); but we must not do that on Android because the NDK
+        # has a sysroot already
+        if not toolchain.is_android and not toolchain.is_darwin:
+            cross_args.append('-DCMAKE_SYSROOT=' + toolchain.install_prefix)
+
+        cmake_toolchain_file = os.path.join(build, 'cmake_toolchain_file')
+        with open(cmake_toolchain_file, 'w') as f:
+            __write_cmake_toolchain_file(f, toolchain)
+
+        configure.append('-DCMAKE_TOOLCHAIN_FILE=' + cmake_toolchain_file)
+
+    if env is None:
+        env = toolchain.env
+    else:
+        env = {**toolchain.env, **env}
+
+    print(configure)
+    subprocess.check_call(configure, env=env, cwd=build)
 
 class CmakeProject(Project):
-    def __init__(self, url, md5, installed, configure_args=[],
+    def __init__(self, url: Union[str, Sequence[str]], md5: str, installed: str,
-                 windows_configure_args=[],
+                 configure_args: list[str]=[],
+                 windows_configure_args: list[str]=[],
+                 env: Optional[Mapping[str, str]]=None,
                  **kwargs):
         Project.__init__(self, url, md5, installed, **kwargs)
         self.configure_args = configure_args
         self.windows_configure_args = windows_configure_args
+        self.env = env
 
-    def configure(self, toolchain):
+    def configure(self, toolchain: AnyToolchain) -> str:
         src = self.unpack(toolchain)
         build = self.make_build_path(toolchain)
         configure_args = self.configure_args
         if toolchain.is_windows:
             configure_args = configure_args + self.windows_configure_args
-        configure(toolchain, src, build, configure_args)
+        configure(toolchain, src, build, configure_args, self.env)
         return build
 
-    def _build(self, toolchain):
+    def _build(self, toolchain: AnyToolchain) -> None:
         build = self.configure(toolchain)
-        subprocess.check_call(['ninja', 'install'],
+        subprocess.check_call(['ninja', '-v', 'install'],
                               cwd=build, env=toolchain.env)

python/build/download.py

@@ -1,12 +1,50 @@
-from build.verify import verify_file_digest
+from typing import Sequence, Union
 import os
+import sys
 import urllib.request
 
-def download_and_verify(url, md5, parent_path):
+from .verify import verify_file_digest
+
+def __to_string_sequence(x: Union[str, Sequence[str]]) -> Sequence[str]:
+    if isinstance(x, str):
+        return (x,)
+    else:
+        return x
+
+def __get_any(x: Union[str, Sequence[str]]) -> str:
+    if isinstance(x, str):
+        return x
+    else:
+        return x[0]
+
+def __download_one(url: str, path: str) -> None:
+    print("download", url)
+    urllib.request.urlretrieve(url, path)
+
+def __download(urls: Sequence[str], path: str) -> None:
+    for url in urls[:-1]:
+        try:
+            __download_one(url, path)
+            return
+        except:
+            print("download error:", sys.exc_info()[0])
+    __download_one(urls[-1], path)
+
+def __download_and_verify_to(urls: Sequence[str], md5: str, path: str) -> None:
+    __download(urls, path)
+    if not verify_file_digest(path, md5):
+        raise RuntimeError("Digest mismatch")
+
+def download_basename(urls: Union[str, Sequence[str]]) -> str:
+    return os.path.basename(__get_any(urls))
+
+def download_and_verify(urls: Union[str, Sequence[str]], md5: str, parent_path: str) -> str:
     """Download a file, verify its MD5 checksum and return the local path."""
 
+    base = download_basename(urls)
+
     os.makedirs(parent_path, exist_ok=True)
-    path = os.path.join(parent_path, os.path.basename(url))
+    path = os.path.join(parent_path, base)
 
     try:
         if verify_file_digest(path, md5): return path
@@ -16,11 +54,6 @@ def download_and_verify(url, md5, parent_path):
 
     tmp_path = path + '.tmp'
 
-    print("download", url)
+    __download_and_verify_to(__to_string_sequence(urls), md5, tmp_path)
-    urllib.request.urlretrieve(url, tmp_path)
-    if not verify_file_digest(tmp_path, md5):
-        os.unlink(tmp_path)
-        raise RuntimeError("Digest mismatch")
-
     os.rename(tmp_path, path)
     return path

python/build/libs.py

@@ -29,8 +29,8 @@ libogg = CmakeProject(
 )
 
 opus = AutotoolsProject(
-    'https://archive.mozilla.org/pub/opus/opus-1.3.1.tar.gz',
+    'https://downloads.xiph.org/releases/opus/opus-1.4.tar.gz',
-    '65b58e1e25b2a114157014736a3d9dfeaad8d41be1c8179866f144a2fb44ff9d',
+    'c9b32b4253be5ae63d1ff16eea06b94b5f0f2951b7a02aceef58e3a3ce49c51f',
     'lib/libopus.a',
     [
         '--disable-shared', '--enable-static',
@@ -43,8 +43,8 @@ opus = AutotoolsProject(
 )
 
 flac = AutotoolsProject(
-    'http://downloads.xiph.org/releases/flac/flac-1.4.0.tar.xz',
+    'http://downloads.xiph.org/releases/flac/flac-1.4.3.tar.xz',
-    'af41c0733c93c237c3e52f64dd87e3b0d9af38259f1c7d11e8cbf583c48c2506',
+    '6c58e69cd22348f441b861092b825e591d0b822e106de6eb0ee4d05d27205b70',
     'lib/libFLAC.a',
     [
         '--disable-shared', '--enable-static',
@@ -57,8 +57,9 @@ flac = AutotoolsProject(
 )
 
 zlib = ZlibProject(
-    'http://zlib.net/zlib-1.2.13.tar.xz',
+    ('http://zlib.net/zlib-1.3.tar.xz',
-    'd14c38e313afc35a9a8760dadf26042f51ea0f5d154b0630a31da0540107fb98',
+     'https://github.com/madler/zlib/releases/download/v1.3/zlib-1.3.tar.xz'),
+    '8a9ba2898e1d0d774eca6ba5b4627a11e5588ba85c8851336eb38de4683050a7',
     'lib/libz.a',
 )
 
@@ -111,6 +112,7 @@ libmodplug = AutotoolsProject(
     [
         '--disable-shared', '--enable-static',
     ],
+    patches='src/lib/modplug/patches',
 )
 
 libopenmpt = AutotoolsProject(
@@ -131,17 +133,14 @@ libopenmpt = AutotoolsProject(
 )
 
 wildmidi = CmakeProject(
-    'https://codeload.github.com/Mindwerks/wildmidi/tar.gz/wildmidi-0.4.4',
+    'https://github.com/Mindwerks/wildmidi/releases/download/wildmidi-0.4.5/wildmidi-0.4.5.tar.gz',
-    '6f267c8d331e9859906837e2c197093fddec31829d2ebf7b958cf6b7ae935430',
+    'd5e7bef00a7aa47534a53d43b1265f8d3d27f6a28e7f563c1cdf02ff4fa35b99',
     'lib/libWildMidi.a',
     [
         '-DBUILD_SHARED_LIBS=OFF',
         '-DWANT_PLAYER=OFF',
         '-DWANT_STATIC=ON',
     ],
-    base='wildmidi-wildmidi-0.4.4',
-    name='wildmidi',
-    version='0.4.4',
 )
 
 gme = CmakeProject(
@@ -152,13 +151,13 @@ gme = CmakeProject(
         '-DBUILD_SHARED_LIBS=OFF',
         '-DENABLE_UBSAN=OFF',
         '-DZLIB_INCLUDE_DIR=OFF',
-        '-DSDL2_DIR=OFF',
+        '-DCMAKE_DISABLE_FIND_PACKAGE_SDL2=ON',
     ],
 )
 
 ffmpeg = FfmpegProject(
-    'http://ffmpeg.org/releases/ffmpeg-5.1.2.tar.xz',
+    'http://ffmpeg.org/releases/ffmpeg-6.0.tar.xz',
-    '619e706d662c8420859832ddc259cd4d4096a48a2ce1eefd052db9e440eef3dc',
+    '57be87c22d9b49c112b6d24bc67d42508660e6b718b3db89c44e47e289137082',
     'lib/libavcodec.a',
     [
         '--disable-shared', '--enable-static',
@@ -176,13 +175,16 @@ ffmpeg = FfmpegProject(
         '--disable-pixelutils',
         '--disable-network',
         '--disable-encoders',
+        '--disable-hwaccels',
         '--disable-muxers',
         '--disable-protocols',
         '--disable-devices',
         '--disable-filters',
         '--disable-v4l2_m2m',
 
+        '--disable-sdl2',
         '--disable-vulkan',
+        '--disable-xlib',
 
         '--disable-parser=bmp',
         '--disable-parser=cavsvideo',
@@ -196,17 +198,22 @@ ffmpeg = FfmpegProject(
         '--disable-parser=h263',
         '--disable-parser=h264',
         '--disable-parser=hevc',
+        '--disable-parser=jpeg2000',
         '--disable-parser=mjpeg',
         '--disable-parser=mlp',
         '--disable-parser=mpeg4video',
         '--disable-parser=mpegvideo',
         '--disable-parser=opus',
+        '--disable-parser=qoi',
+        '--disable-parser=rv30',
+        '--disable-parser=rv40',
         '--disable-parser=vc1',
         '--disable-parser=vp3',
         '--disable-parser=vp8',
         '--disable-parser=vp9',
         '--disable-parser=png',
         '--disable-parser=pnm',
+        '--disable-parser=webp',
         '--disable-parser=xma',
 
         '--disable-demuxer=aqtitle',
@@ -222,6 +229,42 @@ ffmpeg = FfmpegProject(
         '--disable-demuxer=h264',
         '--disable-demuxer=ico',
         '--disable-demuxer=image2',
+        '--disable-demuxer=image2pipe',
+        '--disable-demuxer=image_bmp_pipe',
+        '--disable-demuxer=image_cri_pipe',
+        '--disable-demuxer=image_dds_pipe',
+        '--disable-demuxer=image_dpx_pipe',
+        '--disable-demuxer=image_exr_pipe',
+        '--disable-demuxer=image_gem_pipe',
+        '--disable-demuxer=image_gif_pipe',
+        '--disable-demuxer=image_j2k_pipe',
+        '--disable-demuxer=image_jpeg_pipe',
+        '--disable-demuxer=image_jpegls_pipe',
+        '--disable-demuxer=image_jpegxl_pipe',
+        '--disable-demuxer=image_pam_pipe',
+        '--disable-demuxer=image_pbm_pipe',
+        '--disable-demuxer=image_pcx_pipe',
+        '--disable-demuxer=image_pfm_pipe',
+        '--disable-demuxer=image_pgm_pipe',
+        '--disable-demuxer=image_pgmyuv_pipe',
+        '--disable-demuxer=image_pgx_pipe',
+        '--disable-demuxer=image_phm_pipe',
+        '--disable-demuxer=image_photocd_pipe',
+        '--disable-demuxer=image_pictor_pipe',
+        '--disable-demuxer=image_png_pipe',
+        '--disable-demuxer=image_ppm_pipe',
+        '--disable-demuxer=image_psd_pipe',
+        '--disable-demuxer=image_qdraw_pipe',
+        '--disable-demuxer=image_qoi_pipe',
+        '--disable-demuxer=image_sgi_pipe',
+        '--disable-demuxer=image_sunrast_pipe',
+        '--disable-demuxer=image_svg_pipe',
+        '--disable-demuxer=image_tiff_pipe',
+        '--disable-demuxer=image_vbn_pipe',
+        '--disable-demuxer=image_webp_pipe',
+        '--disable-demuxer=image_xbm_pipe',
+        '--disable-demuxer=image_xpm_pipe',
+        '--disable-demuxer=image_xwd_pipe',
         '--disable-demuxer=jacosub',
         '--disable-demuxer=lrc',
         '--disable-demuxer=microdvd',
@@ -244,6 +287,7 @@ ffmpeg = FfmpegProject(
         '--disable-demuxer=tedcaptions',
         '--disable-demuxer=vobsub',
         '--disable-demuxer=vplayer',
+        '--disable-demuxer=webm_dash_manifest',
         '--disable-demuxer=webvtt',
         '--disable-demuxer=yuv4mpegpipe',
 
@@ -273,78 +317,179 @@ ffmpeg = FfmpegProject(
         '--disable-decoder=qdmc',
 
         # disable lots of image and video codecs
+        '--disable-decoder=acelp_kelvin',
+        '--disable-decoder=agm',
+        '--disable-decoder=aic',
+        '--disable-decoder=alias_pix',
+        '--disable-decoder=ansi',
+        '--disable-decoder=apng',
+        '--disable-decoder=arbc',
+        '--disable-decoder=argo',
         '--disable-decoder=ass',
         '--disable-decoder=asv1',
         '--disable-decoder=asv2',
-        '--disable-decoder=apng',
+        '--disable-decoder=aura',
+        '--disable-decoder=aura2',
         '--disable-decoder=avrn',
         '--disable-decoder=avrp',
+        '--disable-decoder=avui',
+        '--disable-decoder=ayuv',
         '--disable-decoder=bethsoftvid',
+        '--disable-decoder=bfi',
         '--disable-decoder=bink',
+        '--disable-decoder=bintext',
+        '--disable-decoder=bitpacked',
         '--disable-decoder=bmp',
         '--disable-decoder=bmv_video',
+        '--disable-decoder=brender_pix',
+        '--disable-decoder=c93',
         '--disable-decoder=cavs',
         '--disable-decoder=ccaption',
         '--disable-decoder=cdgraphics',
+        '--disable-decoder=cdtoons',
+        '--disable-decoder=cdxl',
+        '--disable-decoder=cfhd',
+        '--disable-decoder=cinepak',
         '--disable-decoder=clearvideo',
+        '--disable-decoder=cljr',
+        '--disable-decoder=cllc',
+        '--disable-decoder=cpia',
+        '--disable-decoder=cscd',
+        '--disable-decoder=cyuv',
+        '--disable-decoder=dds',
         '--disable-decoder=dirac',
+        '--disable-decoder=dnxhd',
+        '--disable-decoder=dpx',
         '--disable-decoder=dsicinvideo',
         '--disable-decoder=dvbsub',
         '--disable-decoder=dvdsub',
         '--disable-decoder=dvvideo',
+        '--disable-decoder=dxa',
+        '--disable-decoder=dxtory',
+        '--disable-decoder=dxv',
+        '--disable-decoder=eacmv',
+        '--disable-decoder=eamad',
+        '--disable-decoder=eatgq',
+        '--disable-decoder=eatgv',
+        '--disable-decoder=eatqi',
+        '--disable-decoder=eightbps',
+        '--disable-decoder=escape124',
+        '--disable-decoder=escape130',
         '--disable-decoder=exr',
         '--disable-decoder=ffv1',
         '--disable-decoder=ffvhuff',
         '--disable-decoder=ffwavesynth',
+        '--disable-decoder=fic',
+        '--disable-decoder=fits',
+        '--disable-decoder=flashsv',
+        '--disable-decoder=flashsv2',
         '--disable-decoder=flic',
         '--disable-decoder=flv',
+        '--disable-decoder=fmvc',
         '--disable-decoder=fraps',
+        '--disable-decoder=fourxm',
+        '--disable-decoder=frwu',
+        '--disable-decoder=g2m',
+        '--disable-decoder=gdv',
+        '--disable-decoder=gem',
         '--disable-decoder=gif',
         '--disable-decoder=h261',
         '--disable-decoder=h263',
         '--disable-decoder=h263i',
         '--disable-decoder=h263p',
         '--disable-decoder=h264',
+        '--disable-decoder=hap',
         '--disable-decoder=hevc',
         '--disable-decoder=hnm4_video',
         '--disable-decoder=hq_hqa',
         '--disable-decoder=hqx',
+        '--disable-decoder=huffyuv',
+        '--disable-decoder=hymt',
         '--disable-decoder=idcin',
+        '--disable-decoder=idf',
         '--disable-decoder=iff_ilbm',
+        '--disable-decoder=imm4',
         '--disable-decoder=indeo2',
         '--disable-decoder=indeo3',
         '--disable-decoder=indeo4',
         '--disable-decoder=indeo5',
         '--disable-decoder=interplay_video',
+        '--disable-decoder=ipu',
         '--disable-decoder=jacosub',
         '--disable-decoder=jpeg2000',
         '--disable-decoder=jpegls',
+        '--disable-decoder=jv',
+        '--disable-decoder=kgv1',
+        '--disable-decoder=kmvc',
+        '--disable-decoder=lagarith',
+        '--disable-decoder=loco',
+        '--disable-decoder=lscr',
+        '--disable-decoder=m101',
+        '--disable-decoder=magicyuv',
+        '--disable-decoder=mdec',
         '--disable-decoder=microdvd',
         '--disable-decoder=mimic',
         '--disable-decoder=mjpeg',
         '--disable-decoder=mmvideo',
         '--disable-decoder=mpl2',
+        '--disable-decoder=mobiclip',
         '--disable-decoder=motionpixels',
+        '--disable-decoder=movtext',
         '--disable-decoder=mpeg1video',
         '--disable-decoder=mpeg2video',
         '--disable-decoder=mpeg4',
         '--disable-decoder=mpegvideo',
+        '--disable-decoder=msa1',
         '--disable-decoder=mscc',
         '--disable-decoder=msmpeg4_crystalhd',
         '--disable-decoder=msmpeg4v1',
         '--disable-decoder=msmpeg4v2',
         '--disable-decoder=msmpeg4v3',
+        '--disable-decoder=msp2',
+        '--disable-decoder=msrle',
+        '--disable-decoder=mss1',
         '--disable-decoder=msvideo1',
         '--disable-decoder=mszh',
+        '--disable-decoder=mts2',
+        '--disable-decoder=mv30',
         '--disable-decoder=mvc1',
         '--disable-decoder=mvc2',
+        '--disable-decoder=mvdv',
+        '--disable-decoder=mvha',
+        '--disable-decoder=mwsc',
+        '--disable-decoder=notchlc',
+        '--disable-decoder=nuv',
         '--disable-decoder=on2avc',
         '--disable-decoder=paf_video',
+        '--disable-decoder=pam',
+        '--disable-decoder=pbm',
+        '--disable-decoder=pcx',
+        '--disable-decoder=pgm',
+        '--disable-decoder=pgmyuv',
+        '--disable-decoder=pgssub',
+        '--disable-decoder=pgx',
+        '--disable-decoder=phm',
+        '--disable-decoder=photocd',
         '--disable-decoder=png',
+        '--disable-decoder=pictor',
+        '--disable-decoder=pixlet',
+        '--disable-decoder=pjs',
+        '--disable-decoder=ppm',
+        '--disable-decoder=prores',
+        '--disable-decoder=prosumer',
+        '--disable-decoder=psd',
+        '--disable-decoder=ptx',
         '--disable-decoder=qdraw',
+        '--disable-decoder=qoi',
         '--disable-decoder=qpeg',
+        '--disable-decoder=qtrle',
         '--disable-decoder=rawvideo',
+        '--disable-decoder=r10k',
+        '--disable-decoder=r210',
+        '--disable-decoder=rasc',
         '--disable-decoder=realtext',
+        '--disable-decoder=rl2',
+        '--disable-decoder=rpza',
         '--disable-decoder=roq',
         '--disable-decoder=roq_dpcm',
         '--disable-decoder=rscc',
@@ -353,53 +498,122 @@ ffmpeg = FfmpegProject(
         '--disable-decoder=rv30',
         '--disable-decoder=rv40',
         '--disable-decoder=sami',
+        '--disable-decoder=sanm',
+        '--disable-decoder=scpr',
+        '--disable-decoder=screenpresso',
+        '--disable-decoder=sga',
+        '--disable-decoder=sgi',
+        '--disable-decoder=sgirle',
         '--disable-decoder=sheervideo',
+        '--disable-decoder=simbiosis_imx',
+        '--disable-decoder=smc',
         '--disable-decoder=snow',
+        '--disable-decoder=speedhq',
+        '--disable-decoder=srgc',
         '--disable-decoder=srt',
+        '--disable-decoder=ssa',
         '--disable-decoder=stl',
         '--disable-decoder=subrip',
         '--disable-decoder=subviewer',
         '--disable-decoder=subviewer1',
+        '--disable-decoder=sunrast',
         '--disable-decoder=svq1',
         '--disable-decoder=svq3',
+        '--disable-decoder=targa',
+        '--disable-decoder=targa_y216',
+        '--disable-decoder=text',
         '--disable-decoder=tiff',
         '--disable-decoder=tiertexseqvideo',
+        '--disable-decoder=tmv',
         '--disable-decoder=truemotion1',
         '--disable-decoder=truemotion2',
         '--disable-decoder=truemotion2rt',
+        '--disable-decoder=tscc',
+        '--disable-decoder=tscc2',
         '--disable-decoder=twinvq',
+        '--disable-decoder=txd',
+        '--disable-decoder=ulti',
         '--disable-decoder=utvideo',
+        '--disable-decoder=v210',
+        '--disable-decoder=v210x',
+        '--disable-decoder=v308',
+        '--disable-decoder=v408',
+        '--disable-decoder=v410',
+        '--disable-decoder=vb',
+        '--disable-decoder=vble',
+        '--disable-decoder=vbn',
         '--disable-decoder=vc1',
+        '--disable-decoder=vcr1',
         '--disable-decoder=vmdvideo',
+        '--disable-decoder=vmnc',
         '--disable-decoder=vp3',
         '--disable-decoder=vp5',
         '--disable-decoder=vp6',
         '--disable-decoder=vp7',
         '--disable-decoder=vp8',
         '--disable-decoder=vp9',
+        '--disable-decoder=vplayer',
         '--disable-decoder=vqa',
         '--disable-decoder=webvtt',
+        '--disable-decoder=wcmv',
         '--disable-decoder=wmv1',
         '--disable-decoder=wmv2',
         '--disable-decoder=wmv3',
+        '--disable-decoder=wnv1',
+        '--disable-decoder=wrapped_avframe',
+        '--disable-decoder=xan_wc3',
+        '--disable-decoder=xan_wc4',
+        '--disable-decoder=xbin',
+        '--disable-decoder=xbm',
+        '--disable-decoder=xface',
+        '--disable-decoder=xl',
+        '--disable-decoder=xpm',
+        '--disable-decoder=xsub',
+        '--disable-decoder=xwd',
+        '--disable-decoder=y41p',
+        '--disable-decoder=ylc',
+        '--disable-decoder=yop',
         '--disable-decoder=yuv4',
+        '--disable-decoder=zero12v',
+        '--disable-decoder=zerocodec',
+        '--disable-decoder=zlib',
+        '--disable-decoder=zmbv',
+
+        '--disable-bsf=av1_frame_merge',
+        '--disable-bsf=av1_frame_split',
+        '--disable-bsf=av1_metadata',
+        '--disable-bsf=dts2pts',
+        '--disable-bsf=h264_metadata',
+        '--disable-bsf=h264_mp4toannexb',
+        '--disable-bsf=h264_redundant_pps',
+        '--disable-bsf=hevc_metadata',
+        '--disable-bsf=hevc_mp4toannexb',
+        '--disable-bsf=mjpeg2jpeg',
+        '--disable-bsf=opus_metadata',
+        '--disable-bsf=pgs_frame_merge',
+        '--disable-bsf=text2movsub',
+        '--disable-bsf=vp9_metadata',
+        '--disable-bsf=vp9_raw_reorder',
+        '--disable-bsf=vp9_superframe',
+        '--disable-bsf=vp9_superframe_split',
     ],
 )
 
 openssl = OpenSSLProject(
-    'https://www.openssl.org/source/openssl-3.0.5.tar.gz',
+    ('https://www.openssl.org/source/openssl-3.1.3.tar.gz',
-    'aa7d8d9bef71ad6525c55ba11e5f4397889ce49c2c9349dcea6d3e4f0b024a7a',
+     'https://artfiles.org/openssl.org/source/openssl-3.1.3.tar.gz'),
+    'f0316a2ebd89e7f2352976445458689f80302093788c466692fb2a188b2eacf6',
     'include/openssl/ossl_typ.h',
 )
 
 curl = CmakeProject(
-    'https://curl.se/download/curl-7.85.0.tar.xz',
+    ('https://curl.se/download/curl-8.2.1.tar.xz',
-    '88b54a6d4b9a48cb4d873c7056dcba997ddd5b7be5a2d537a4acb55c20b04be6',
+     'https://github.com/curl/curl/releases/download/curl-8_2_1/curl-8.2.1.tar.xz'),
+    'dd322f6bd0a20e6cebdfd388f69e98c3d183bed792cf4713c8a7ef498cba4894',
     'lib/libcurl.a',
     [
         '-DBUILD_CURL_EXE=OFF',
         '-DBUILD_SHARED_LIBS=OFF',
-        '-DCURL_DISABLE_VERBOSE_STRINGS=ON',
         '-DCURL_DISABLE_LDAP=ON',
         '-DCURL_DISABLE_TELNET=ON',
         '-DCURL_DISABLE_DICT=ON',
@@ -451,7 +665,7 @@ jack = JackProject(
 )
 
 boost = BoostProject(
-    'https://boostorg.jfrog.io/artifactory/main/release/1.80.0/source/boost_1_80_0.tar.bz2',
+    'https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.bz2',
-    '1e19565d82e43bc59209a168f5ac899d3ba471d55c7610c677d4ccf2c9c500c0',
+    '71feeed900fbccca04a3b4f2f84a7c217186f28a940ed8b7ed4725986baf99fa',
     'include/boost/version.hpp',
 )

python/build/makeproject.py

@@ -1,28 +1,35 @@
-import subprocess
+import subprocess, multiprocessing
+from typing import Optional, Sequence, Union
 
 from build.project import Project
+from .toolchain import AnyToolchain
 
 class MakeProject(Project):
-    def __init__(self, url, md5, installed,
+    def __init__(self, url: Union[str, Sequence[str]], md5: str, installed: str,
-                 install_target='install',
+                 install_target: str='install',
                  **kwargs):
         Project.__init__(self, url, md5, installed, **kwargs)
         self.install_target = install_target
 
-    def get_simultaneous_jobs(self):
+    def get_simultaneous_jobs(self) -> int:
-        return 12
+        try:
+            # use twice as many simultaneous jobs as we have CPU cores
+            return multiprocessing.cpu_count() * 2
+        except NotImplementedError:
+            # default to 12, if multiprocessing.cpu_count() is not implemented
+            return 12
 
-    def get_make_args(self, toolchain):
+    def get_make_args(self, toolchain: AnyToolchain) -> list[str]:
         return ['--quiet', '-j' + str(self.get_simultaneous_jobs())]
 
-    def get_make_install_args(self, toolchain):
+    def get_make_install_args(self, toolchain: AnyToolchain) -> list[str]:
         return ['--quiet', self.install_target]
 
-    def make(self, toolchain, wd, args):
+    def make(self, toolchain: AnyToolchain, wd: str, args: list[str]) -> None:
-        subprocess.check_call(['/usr/bin/make'] + args,
+        subprocess.check_call(['make'] + args,
                               cwd=wd, env=toolchain.env)
 
-    def build_make(self, toolchain, wd, install=True):
+    def build_make(self, toolchain: AnyToolchain, wd: str, install: bool=True) -> None:
         self.make(toolchain, wd, self.get_make_args(toolchain))
         if install:
             self.make(toolchain, wd, self.get_make_install_args(toolchain))

python/build/meson.py

@@ -1,9 +1,17 @@
-import os.path, subprocess, sys
+import os
+import subprocess
 import platform
+from typing import Optional, Sequence, Union
 
 from build.project import Project
+from .toolchain import AnyToolchain
 
-def make_cross_file(toolchain):
+def __no_ccache(cmd: str) -> str:
+    if cmd.startswith('ccache '):
+        cmd = cmd[7:]
+    return cmd
+
+def make_cross_file(toolchain: AnyToolchain) -> str:
     if toolchain.is_windows:
         system = 'windows'
         windres = "windres = '%s'" % toolchain.windres
@@ -22,7 +30,7 @@ def make_cross_file(toolchain):
         cpu = 'arm64-v8a'
     else:
         cpu_family = 'x86'
-        if 'x86_64' in toolchain.arch:
+        if 'x86_64' in toolchain.host_triplet:
             cpu = 'x86_64'
         else:
             cpu = 'i686'
@@ -37,8 +45,8 @@ def make_cross_file(toolchain):
     with open(path, 'w') as f:
         f.write(f"""
 [binaries]
-c = '{toolchain.cc}'
+c = '{__no_ccache(toolchain.cc)}'
-cpp = '{toolchain.cxx}'
+cpp = '{__no_ccache(toolchain.cxx)}'
 ar = '{toolchain.ar}'
 strip = '{toolchain.strip}'
 pkgconfig = '{toolchain.pkg_config}'
@@ -55,7 +63,7 @@ pkgconfig = '{toolchain.pkg_config}'
 root = '{toolchain.install_prefix}'
 """)
 
-        if 'android' in toolchain.arch:
+        if toolchain.is_android:
             f.write("""
 # Keep Meson from executing Android-x86 test binariees
 needs_exe_wrapper = true
@@ -79,21 +87,23 @@ endian = '{endian}'
 """)
     return path
 
-def configure(toolchain, src, build, args=()):
+def configure(toolchain: AnyToolchain, src: str, build: str, args: list[str]=[]) -> None:
-    cross_file = make_cross_file(toolchain)
     configure = [
-        'meson',
+        'meson', 'setup',
-        src, build,
+        build, src,
 
         '--prefix', toolchain.install_prefix,
 
         '--buildtype', 'plain',
 
         '--default-library=static',
-
-        '--cross-file', cross_file,
     ] + args
 
+    if toolchain.host_triplet is not None:
+        # cross-compiling: write a cross-file
+        cross_file = make_cross_file(toolchain)
+        configure.append(f'--cross-file={cross_file}')
+
     env = toolchain.env.copy()
 
     # Meson 0.54 requires the BOOST_ROOT environment variable
@@ -102,18 +112,19 @@ def configure(toolchain, src, build, args=()):
     subprocess.check_call(configure, env=env)
 
 class MesonProject(Project):
-    def __init__(self, url, md5, installed, configure_args=[],
+    def __init__(self, url: Union[str, Sequence[str]], md5: str, installed: str,
+                 configure_args: list[str]=[],
                  **kwargs):
         Project.__init__(self, url, md5, installed, **kwargs)
         self.configure_args = configure_args
 
-    def configure(self, toolchain):
+    def configure(self, toolchain: AnyToolchain) -> str:
         src = self.unpack(toolchain)
         build = self.make_build_path(toolchain)
         configure(toolchain, src, build, self.configure_args)
         return build
 
-    def _build(self, toolchain):
+    def _build(self, toolchain: AnyToolchain) -> None:
         build = self.configure(toolchain)
-        subprocess.check_call(['ninja', 'install'],
+        subprocess.check_call(['ninja', '-v', 'install'],
                               cwd=build, env=toolchain.env)

python/build/openssl.py

@@ -1,13 +1,15 @@
 import subprocess
+from typing import Optional, Sequence, Union
 
 from build.makeproject import MakeProject
+from .toolchain import AnyToolchain
 
 class OpenSSLProject(MakeProject):
-    def __init__(self, url, md5, installed,
+    def __init__(self, url: Union[str, Sequence[str]], md5: str, installed: str,
                  **kwargs):
         MakeProject.__init__(self, url, md5, installed, install_target='install_dev', **kwargs)
 
-    def get_make_args(self, toolchain):
+    def get_make_args(self, toolchain: AnyToolchain) -> list[str]:
         return MakeProject.get_make_args(self, toolchain) + [
             'CC=' + toolchain.cc,
             'CFLAGS=' + toolchain.cflags,
@@ -17,45 +19,60 @@ class OpenSSLProject(MakeProject):
             'build_libs',
         ]
 
-    def get_make_install_args(self, toolchain):
+    def get_make_install_args(self, toolchain: AnyToolchain) -> list[str]:
         # OpenSSL's Makefile runs "ranlib" during installation
         return MakeProject.get_make_install_args(self, toolchain) + [
             'RANLIB=' + toolchain.ranlib,
         ]
 
-    def _build(self, toolchain):
+    def _build(self, toolchain: AnyToolchain) -> None:
         src = self.unpack(toolchain, out_of_tree=False)
 
         # OpenSSL has a weird target architecture scheme with lots of
         # hard-coded architectures; this table translates between our
-        # "toolchain_arch" (HOST_TRIPLET) and the OpenSSL target
+        # host triplet and the OpenSSL target
         openssl_archs = {
             # not using "android-*" because those OpenSSL targets want
             # to know where the SDK is, but our own build scripts
             # prepared everything already to look like a regular Linux
             # build
-            'arm-linux-androideabi': 'linux-generic32',
+            'armv7a-linux-androideabi': 'linux-generic32',
             'aarch64-linux-android': 'linux-aarch64',
             'i686-linux-android': 'linux-x86-clang',
             'x86_64-linux-android': 'linux-x86_64-clang',
 
-            # Kobo
+            # generic Linux
             'arm-linux-gnueabihf': 'linux-generic32',
 
             # Windows
             'i686-w64-mingw32': 'mingw',
             'x86_64-w64-mingw32': 'mingw64',
+
+            # Apple
+            'x86_64-apple-darwin': 'darwin64-x86_64-cc',
+            'aarch64-apple-darwin': 'darwin64-arm64-cc',
         }
 
-        openssl_arch = openssl_archs[toolchain.arch]
+        configure = [
+            './Configure',
+            'no-shared',
+            'no-module',
+            'no-engine',
+            'no-static-engine',
+            'no-async',
+            'no-tests',
+            'no-makedepend',
+            '--libdir=lib', # no "lib64" on amd64, please
+            '--prefix=' + toolchain.install_prefix,
+        ]
 
-        subprocess.check_call(['./Configure',
+        if toolchain.is_windows:
-                               'no-shared',
+            # workaround for build failures
-                               'no-module', 'no-engine', 'no-static-engine',
+            configure.append('no-asm')
-                               'no-async',
+
-                               'no-tests',
+        if toolchain.host_triplet is not None:
-                               'no-asm', # "asm" causes build failures on Windows
+            configure.append(openssl_archs[toolchain.host_triplet])
-                               openssl_arch,
+            configure.append(f'--cross-compile-prefix={toolchain.host_triplet}-')
-                               '--prefix=' + toolchain.install_prefix],
+
-                              cwd=src, env=toolchain.env)
+        subprocess.check_call(configure, cwd=src, env=toolchain.env)
         self.build_make(toolchain, src)

python/build/project.py

@@ -1,26 +1,30 @@
 import os, shutil
 import re
+from typing import cast, BinaryIO, Optional, Sequence, Union
 
-from build.download import download_and_verify
+from build.download import download_basename, download_and_verify
 from build.tar import untar
 from build.quilt import push_all
+from .toolchain import AnyToolchain
 
 class Project:
-    def __init__(self, url, md5, installed, name=None, version=None,
+    def __init__(self, url: Union[str, Sequence[str]], md5: str, installed: str,
-                 base=None,
+                 name: Optional[str]=None, version: Optional[str]=None,
-                 patches=None,
+                 base: Optional[str]=None,
+                 patches: Optional[str]=None,
                  edits=None,
-                 use_cxx=False):
+                 use_cxx: bool=False):
         if base is None:
-            basename = os.path.basename(url)
+            basename = download_basename(url)
             m = re.match(r'^(.+)\.(tar(\.(gz|bz2|xz|lzma))?|zip)$', basename)
-            if not m: raise
+            if not m: raise RuntimeError('Could not identify tarball name: ' + basename)
             self.base = m.group(1)
         else:
             self.base = base
 
         if name is None or version is None:
             m = re.match(r'^([-\w]+)-(\d[\d.]*[a-z]?[\d.]*(?:-(?:alpha|beta)\d+)?)(\+.*)?$', self.base)
+            if not m: raise RuntimeError('Could not identify tarball name: ' + self.base)
             if name is None: name = m.group(1)
             if version is None: version = m.group(2)
 
@@ -38,10 +42,10 @@ class Project:
         self.edits = edits
         self.use_cxx = use_cxx
 
-    def download(self, toolchain):
+    def download(self, toolchain: AnyToolchain) -> str:
         return download_and_verify(self.url, self.md5, toolchain.tarball_path)
 
-    def is_installed(self, toolchain):
+    def is_installed(self, toolchain: AnyToolchain) -> bool:
         tarball = self.download(toolchain)
         installed = os.path.join(toolchain.install_prefix, self.installed)
         tarball_mtime = os.path.getmtime(tarball)
@@ -50,13 +54,13 @@ class Project:
         except FileNotFoundError:
             return False
 
-    def unpack(self, toolchain, out_of_tree=True):
+    def unpack(self, toolchain: AnyToolchain, out_of_tree: bool=True) -> str:
         if out_of_tree:
             parent_path = toolchain.src_path
         else:
             parent_path = toolchain.build_path
-        path = untar(self.download(toolchain), parent_path, self.base)
+        path = untar(self.download(toolchain), parent_path, self.base,
-
+                     lazy=out_of_tree and self.patches is None)
         if self.patches is not None:
             push_all(toolchain, path, self.patches)
 
@@ -71,8 +75,10 @@ class Project:
 
         return path
 
-    def make_build_path(self, toolchain):
+    def make_build_path(self, toolchain: AnyToolchain, lazy: bool=False) -> str:
         path = os.path.join(toolchain.build_path, self.base)
+        if lazy and os.path.isdir(path):
+            return path
         try:
             shutil.rmtree(path)
         except FileNotFoundError:
@@ -80,5 +86,5 @@ class Project:
         os.makedirs(path, exist_ok=True)
         return path
 
-    def build(self, toolchain):
+    def build(self, toolchain: AnyToolchain) -> None:
         self._build(toolchain)

python/build/quilt.py

@@ -1,9 +1,12 @@
 import subprocess
+from typing import Union
 
-def run_quilt(toolchain, cwd, patches_path, *args):
+from .toolchain import AnyToolchain
+
+def run_quilt(toolchain: AnyToolchain, cwd: str, patches_path: str, *args: str) -> None:
     env = dict(toolchain.env)
     env['QUILT_PATCHES'] = patches_path
     subprocess.check_call(['quilt'] + list(args), cwd=cwd, env=env)
 
-def push_all(toolchain, src_path, patches_path):
+def push_all(toolchain: AnyToolchain, src_path: str, patches_path: str) -> None:
     run_quilt(toolchain, src_path, patches_path, 'push', '-a')

python/build/tar.py

@@ -1,14 +1,17 @@
 import os, shutil, subprocess
 
-def untar(tarball_path, parent_path, base):
+def untar(tarball_path: str, parent_path: str, base: str,
+          lazy: bool=False) -> str:
     path = os.path.join(parent_path, base)
+    if lazy and os.path.isdir(path):
+        return path
     try:
         shutil.rmtree(path)
     except FileNotFoundError:
         pass
     os.makedirs(parent_path, exist_ok=True)
     try:
-        subprocess.check_call(['/bin/tar', 'xfC', tarball_path, parent_path])
+        subprocess.check_call(['tar', 'xfC', tarball_path, parent_path])
     except FileNotFoundError:
         import tarfile
         tar = tarfile.open(tarball_path)

python/build/toolchain.py

@@ -0,0 +1,175 @@
+import os.path
+import shutil
+from typing import Union
+
+android_abis = {
+    'armeabi-v7a': {
+        'arch': 'armv7a-linux-androideabi',
+        'ndk_arch': 'arm',
+        'cflags': '-fpic -mfpu=neon -mfloat-abi=softfp',
+    },
+
+    'arm64-v8a': {
+        'arch': 'aarch64-linux-android',
+        'ndk_arch': 'arm64',
+        'cflags': '-fpic',
+    },
+
+    'x86': {
+        'arch': 'i686-linux-android',
+        'ndk_arch': 'x86',
+        'cflags': '-fPIC -march=i686 -mtune=intel -mssse3 -mfpmath=sse -m32',
+    },
+
+    'x86_64': {
+        'arch': 'x86_64-linux-android',
+        'ndk_arch': 'x86_64',
+        'cflags': '-fPIC -m64',
+    },
+}
+
+class AndroidNdkToolchain:
+    def __init__(self, top_path: str, lib_path: str,
+                 tarball_path: str, src_path: str,
+                 ndk_path: str, android_abi: str,
+                 use_cxx):
+        # build host configuration
+        build_arch = 'linux-x86_64'
+
+        # select the NDK target
+        abi_info = android_abis[android_abi]
+        host_triplet = abi_info['arch']
+
+        arch_path = os.path.join(lib_path, host_triplet)
+
+        self.tarball_path = tarball_path
+        self.src_path = src_path
+        self.build_path = os.path.join(arch_path, 'build')
+
+        ndk_arch = abi_info['ndk_arch']
+        android_api_level = '24'
+
+        install_prefix = os.path.join(arch_path, 'root')
+
+        self.host_triplet = host_triplet
+        self.install_prefix = install_prefix
+
+        llvm_path = os.path.join(ndk_path, 'toolchains', 'llvm', 'prebuilt', build_arch)
+        llvm_triple = host_triplet + android_api_level
+
+        common_flags = '-Os -g'
+        common_flags += ' ' + abi_info['cflags']
+
+        llvm_bin = os.path.join(llvm_path, 'bin')
+        self.cc = os.path.join(llvm_bin, 'clang')
+        self.cxx = os.path.join(llvm_bin, 'clang++')
+        common_flags += ' -target ' + llvm_triple
+
+        common_flags += ' -fvisibility=hidden -fdata-sections -ffunction-sections'
+
+        self.ar = os.path.join(llvm_bin, 'llvm-ar')
+        self.arflags = 'rcs'
+        self.ranlib = os.path.join(llvm_bin, 'llvm-ranlib')
+        self.nm = os.path.join(llvm_bin, 'llvm-nm')
+        self.strip = os.path.join(llvm_bin, 'llvm-strip')
+
+        self.cflags = common_flags
+        self.cxxflags = common_flags
+        self.cppflags = ' -isystem ' + os.path.join(install_prefix, 'include')
+        self.ldflags = ' -L' + os.path.join(install_prefix, 'lib') + \
+            ' -Wl,--exclude-libs=ALL' + \
+            ' ' + common_flags
+        self.ldflags = common_flags
+        self.libs = ''
+
+        self.is_arm = ndk_arch == 'arm'
+        self.is_armv7 = self.is_arm and 'armv7' in self.cflags
+        self.is_aarch64 = ndk_arch == 'arm64'
+        self.is_windows = False
+        self.is_android = True
+        self.is_darwin = False
+
+        libstdcxx_flags = ''
+        libstdcxx_cxxflags = ''
+        libstdcxx_ldflags = ''
+        libstdcxx_libs = '-static-libstdc++'
+
+        if self.is_armv7:
+            # On 32 bit ARM, clang generates no ".eh_frame" section;
+            # instead, the LLVM unwinder library is used for unwinding
+            # the stack after a C++ exception was thrown
+            libstdcxx_libs += ' -lunwind'
+
+        if use_cxx:
+            self.cxxflags += ' ' + libstdcxx_cxxflags
+            self.ldflags += ' ' + libstdcxx_ldflags
+            self.libs += ' ' + libstdcxx_libs
+
+        self.env = dict(os.environ)
+
+        # redirect pkg-config to use our root directory instead of the
+        # default one on the build host
+        bin_dir = os.path.join(install_prefix, 'bin')
+        os.makedirs(bin_dir, exist_ok=True)
+        self.pkg_config = shutil.copy(os.path.join(top_path, 'build', 'pkg-config.sh'),
+                                      os.path.join(bin_dir, 'pkg-config'))
+        self.env['PKG_CONFIG'] = self.pkg_config
+
+class MingwToolchain:
+    def __init__(self, top_path: str,
+                 toolchain_path, host_triplet, x64: bool,
+                 tarball_path, src_path, build_path, install_prefix):
+        self.host_triplet = host_triplet
+        self.tarball_path = tarball_path
+        self.src_path = src_path
+        self.build_path = build_path
+        self.install_prefix = install_prefix
+
+        toolchain_bin = os.path.join(toolchain_path, 'bin')
+        self.cc = os.path.join(toolchain_bin, host_triplet + '-gcc')
+        self.cxx = os.path.join(toolchain_bin, host_triplet + '-g++')
+        self.ar = os.path.join(toolchain_bin, host_triplet + '-ar')
+        self.arflags = 'rcs'
+        self.ranlib = os.path.join(toolchain_bin, host_triplet + '-ranlib')
+        self.nm = os.path.join(toolchain_bin, host_triplet + '-nm')
+        self.strip = os.path.join(toolchain_bin, host_triplet + '-strip')
+        self.windres = os.path.join(toolchain_bin, host_triplet + '-windres')
+
+        common_flags = '-O2 -g'
+
+        if not x64:
+            # enable SSE support which is required for LAME
+            common_flags += ' -march=pentium3'
+
+        self.cflags = common_flags
+        self.cxxflags = common_flags
+        self.cppflags = '-isystem ' + os.path.join(install_prefix, 'include') + \
+                        ' -DWINVER=0x0600 -D_WIN32_WINNT=0x0600'
+        self.ldflags = '-L' + os.path.join(install_prefix, 'lib') + \
+                       ' -static-libstdc++ -static-libgcc'
+        self.libs = ''
+
+        # Explicitly disable _FORTIFY_SOURCE because it is broken with
+        # mingw.  This prevents some libraries such as libFLAC to
+        # enable it.
+        self.cppflags += ' -D_FORTIFY_SOURCE=0'
+
+        self.is_arm = host_triplet.startswith('arm')
+        self.is_armv7 = self.is_arm and 'armv7' in self.cflags
+        self.is_aarch64 = host_triplet == 'aarch64'
+        self.is_windows = 'mingw32' in host_triplet
+        self.is_android = False
+        self.is_darwin = False
+
+        self.env = dict(os.environ)
+
+        # redirect pkg-config to use our root directory instead of the
+        # default one on the build host
+        import shutil
+        bin_dir = os.path.join(install_prefix, 'bin')
+        os.makedirs(bin_dir, exist_ok=True)
+        self.pkg_config = shutil.copy(os.path.join(top_path, 'build', 'pkg-config.sh'),
+                                      os.path.join(bin_dir, 'pkg-config'))
+        self.env['PKG_CONFIG'] = self.pkg_config
+
+AnyToolchain = Union[AndroidNdkToolchain, MingwToolchain]

python/build/verify.py

@@ -1,6 +1,7 @@
 import hashlib
+from typing import cast, Any, BinaryIO
 
-def feed_file(h, f):
+def feed_file(h: Any, f: BinaryIO) -> None:
     """Feed data read from an open file into the hashlib instance."""
 
     while True:
@@ -10,20 +11,20 @@ def feed_file(h, f):
             break
         h.update(data)
 
-def feed_file_path(h, path):
+def feed_file_path(h: Any, path: str) -> None:
     """Feed data read from a file (to be opened by this function) into the hashlib instance."""
 
     with open(path, 'rb') as f:
         feed_file(h, f)
 
-def file_digest(algorithm, path):
+def file_digest(algorithm: Any, path: str) -> str:
     """Calculate the digest of a file and return it in hexadecimal notation."""
 
     h = algorithm()
     feed_file_path(h, path)
-    return h.hexdigest()
+    return cast(str, h.hexdigest())
 
-def guess_digest_algorithm(digest):
+def guess_digest_algorithm(digest: str) -> Any:
     l = len(digest)
     if l == 32:
         return hashlib.md5
@@ -36,7 +37,7 @@ def guess_digest_algorithm(digest):
     else:
         return None
 
-def verify_file_digest(path, expected_digest):
+def verify_file_digest(path: str, expected_digest: str) -> bool:
     """Verify the digest of a file, and return True if the digest matches with the given expected digest."""
 
     algorithm = guess_digest_algorithm(expected_digest)

python/build/zlib.py

@@ -1,22 +1,34 @@
-import os.path, subprocess
+import subprocess
+from typing import Optional, Sequence, Union
 
-from build.project import Project
+from build.makeproject import MakeProject
+from .toolchain import AnyToolchain
 
-class ZlibProject(Project):
+class ZlibProject(MakeProject):
-    def __init__(self, url, md5, installed,
+    def __init__(self, url: Union[str, Sequence[str]], md5: str, installed: str,
                  **kwargs):
-        Project.__init__(self, url, md5, installed, **kwargs)
+        MakeProject.__init__(self, url, md5, installed, **kwargs)
 
-    def _build(self, toolchain):
+    def get_make_args(self, toolchain: AnyToolchain) -> list[str]:
+        return MakeProject.get_make_args(self, toolchain) + [
+            'CC=' + toolchain.cc + ' ' + toolchain.cppflags + ' ' + toolchain.cflags,
+            'CPP=' + toolchain.cc + ' -E ' + toolchain.cppflags,
+            'AR=' + toolchain.ar,
+            'ARFLAGS=' + toolchain.arflags,
+            'RANLIB=' + toolchain.ranlib,
+            'LDSHARED=' + toolchain.cc + ' -shared',
+            'libz.a'
+        ]
+
+    def get_make_install_args(self, toolchain: AnyToolchain) -> list[str]:
+        return [
+            'RANLIB=' + toolchain.ranlib,
+            self.install_target
+        ]
+
+    def _build(self, toolchain: AnyToolchain) -> None:
         src = self.unpack(toolchain, out_of_tree=False)
 
-        subprocess.check_call(['/usr/bin/make', '--quiet',
+        subprocess.check_call(['./configure', '--prefix=' + toolchain.install_prefix, '--static'],
-            '-f', 'win32/Makefile.gcc',
+                              cwd=src, env=toolchain.env)
-            'PREFIX=' + toolchain.arch + '-',
+        self.build_make(toolchain, src)
-            '-j12',
-            'install',
-            'INCLUDE_PATH='+ os.path.join(toolchain.install_prefix, 'include'),
-            'LIBRARY_PATH=' + os.path.join(toolchain.install_prefix, 'lib'),
-            'BINARY_PATH=' + os.path.join(toolchain.install_prefix, 'bin'),
-            ],
-            cwd=src, env=toolchain.env)

src/CommandLine.cxx

@@ -352,12 +352,16 @@ ParseCommandLine(int argc, char **argv, CommandLineOptions &options,
 			break;
 
 		case OPTION_NO_DAEMON:
+#ifdef ENABLE_DAEMON
 			options.daemon = false;
+#endif
 			break;
 
 #ifdef __linux__
 		case OPTION_SYSTEMD:
+#ifdef ENABLE_DAEMON
 			options.daemon = false;
+#endif
 			options.systemd = true;
 			break;
 #endif

src/CommandLine.hxx

@@ -20,11 +20,18 @@
 #ifndef MPD_COMMAND_LINE_HXX
 #define MPD_COMMAND_LINE_HXX
 
+#include "config.h" // for ENABLE_DAEMON
+
 struct ConfigData;
 
 struct CommandLineOptions {
 	bool kill = false;
+
+#ifdef ENABLE_DAEMON
 	bool daemon = true;
+#else
+	static constexpr bool daemon = false;
+#endif
 
 #ifdef __linux__
 	bool systemd = false;

src/Main.cxx

@@ -482,7 +482,10 @@ MainConfigured(const CommandLineOptions &options,
 #ifndef ANDROID
 	setup_log_output();
 
-	const ScopeSignalHandlersInit signal_handlers_init(instance);
+	const ScopeSignalHandlersInit signal_handlers_init{
+		instance,
+		options.daemon,
+	};
 #endif
 
 	instance.io_thread.Start();

src/PlaylistFile.cxx

@@ -81,6 +81,9 @@ spl_valid_name(const char *name_utf8)
 	 */
 
 	return std::strchr(name_utf8, '/') == nullptr &&
+#ifdef _WIN32
+		std::strchr(name_utf8, '\\') == nullptr &&
+#endif
 		std::strchr(name_utf8, '\n') == nullptr &&
 		std::strchr(name_utf8, '\r') == nullptr;
 }

src/RemoteTagCache.hxx

@@ -28,7 +28,11 @@
 #include <boost/intrusive/list.hpp>
 #include <boost/intrusive/unordered_set.hpp>
 
+#include <array>
+#include <functional>
+#include <memory>
 #include <string>
+#include <utility>
 
 class RemoteTagCacheHandler;
 

src/SongPrint.cxx

@@ -24,6 +24,7 @@
 #include "TagPrint.hxx"
 #include "client/Response.hxx"
 #include "fs/Traits.hxx"
+#include "lib/fmt/AudioFormatFormatter.hxx"
 #include "time/ChronoUtil.hxx"
 #include "util/StringBuffer.hxx"
 #include "util/UriUtil.hxx"
@@ -93,7 +94,7 @@ song_print_info(Response &r, const LightSong &song, bool base) noexcept
 		time_print(r, "Last-Modified", song.mtime);
 
 	if (song.audio_format.IsDefined())
-		r.Fmt(FMT_STRING("Format: {}\n"), ToString(song.audio_format));
+		r.Fmt(FMT_STRING("Format: {}\n"), song.audio_format);
 
 	tag_print_values(r, song.tag);
 
@@ -116,7 +117,7 @@ song_print_info(Response &r, const DetachedSong &song, bool base) noexcept
 		time_print(r, "Last-Modified", song.GetLastModified());
 
 	if (const auto &f = song.GetAudioFormat(); f.IsDefined())
-		r.Fmt(FMT_STRING("Format: {}\n"), ToString(f));
+		r.Fmt(FMT_STRING("Format: {}\n"), f);
 
 	tag_print_values(r, song.GetTag());
 

src/SongSave.cxx

@@ -63,6 +63,9 @@ song_save(BufferedOutputStream &os, const Song &song)
 	if (song.audio_format.IsDefined())
 		os.Format("Format: %s\n", ToString(song.audio_format).c_str());
 
+	if (song.in_playlist)
+		os.Write("InPlaylist: yes\n");
+
 	if (!IsNegative(song.mtime))
 		os.Format(SONG_MTIME ": %li\n",
 			  (long)std::chrono::system_clock::to_time_t(song.mtime));
@@ -86,7 +89,7 @@ song_save(BufferedOutputStream &os, const DetachedSong &song)
 
 DetachedSong
 song_load(LineReader &file, const char *uri,
-	  std::string *target_r)
+	  std::string *target_r, bool *in_playlist_r)
 {
 	DetachedSong song(uri);
 
@@ -132,6 +135,9 @@ song_load(LineReader &file, const char *uri,
 
 			song.SetStartTime(SongTime::FromMS(start_ms));
 			song.SetEndTime(SongTime::FromMS(end_ms));
+		} else if (StringIsEqual(line, "InPlaylist")) {
+			if (in_playlist_r != nullptr)
+				*in_playlist_r = StringIsEqual(value, "yes");
 		} else {
 			throw FormatRuntimeError("unknown line in db: %s", line);
 		}

src/SongSave.hxx

@@ -44,6 +44,6 @@ song_save(BufferedOutputStream &os, const DetachedSong &song);
  */
 DetachedSong
 song_load(LineReader &file, const char *uri,
-	  std::string *target_r=nullptr);
+	  std::string *target_r=nullptr, bool *in_playlist_r=nullptr);
 
 #endif

src/StateFileConfig.cxx

@@ -32,7 +32,7 @@ StateFileConfig::StateFileConfig(const ConfigData &config)
 {
 #ifdef ANDROID
 	if (path.IsNull()) {
-		const auto cache_dir = GetUserCacheDir();
+		const auto cache_dir = GetAppCacheDir();
 		if (cache_dir.IsNull())
 			return;
 

src/TagPrint.cxx

@@ -35,8 +35,9 @@ tag_print_types(Response &r) noexcept
 }
 
 void
-tag_print(Response &r, TagType type, StringView value) noexcept
+tag_print(Response &r, TagType type, StringView _value) noexcept
 {
+	const std::string_view value{_value};
 	r.Fmt(FMT_STRING("{}: {}\n"), tag_item_names[type], value);
 }
 

src/TimePrint.cxx

@@ -36,5 +36,5 @@ time_print(Response &r, const char *name,
 		return;
 	}
 
-	r.Fmt(FMT_STRING("{}: {}\n"), name, s);
+	r.Fmt(FMT_STRING("{}: {}\n"), name, s.c_str());
 }

src/archive/plugins/meson.build

@@ -22,6 +22,10 @@ if libzzip_dep.found()
   found_archive_plugin = true
 endif
 
+if not found_archive_plugin
+  subdir_done()
+endif
+
 archive_plugins = static_library(
   'archive_plugins',
   archive_plugins_sources,

src/command/DatabaseCommands.cxx

@@ -41,6 +41,8 @@
 #include <memory>
 #include <vector>
 
+#include <limits.h> // for UINT_MAX
+
 CommandResult
 handle_listfiles_db(Client &client, Response &r, const char *uri)
 {

src/command/FileCommands.cxx

@@ -100,10 +100,6 @@ handle_listfiles_local(Response &r, Path path_fs)
 	return CommandResult::OK;
 }
 
-#if defined(_WIN32) && GCC_CHECK_VERSION(4,6)
-#pragma GCC diagnostic pop
-#endif
-
 gcc_pure
 static bool
 IsValidName(const StringView s) noexcept
@@ -130,7 +126,8 @@ public:
 	explicit PrintCommentHandler(Response &_response) noexcept
 		:NullTagHandler(WANT_PAIR), response(_response) {}
 
-	void OnPair(StringView key, StringView value) noexcept override {
+	void OnPair(StringView _key, StringView _value) noexcept override {
+		const std::string_view key{_key}, value{_value};
 		if (IsValidName(key) && IsValidValue(value))
 			response.Fmt(FMT_STRING("{}: {}\n"), key, value);
 	}

src/command/PlayerCommands.cxx

@@ -28,6 +28,7 @@
 #include "Partition.hxx"
 #include "Instance.hxx"
 #include "IdleFlags.hxx"
+#include "lib/fmt/AudioFormatFormatter.hxx"
 #include "util/StringBuffer.hxx"
 #include "util/ScopeExit.hxx"
 #include "util/Exception.hxx"
@@ -185,7 +186,7 @@ handle_status(Client &client, [[maybe_unused]] Request args, Response &r)
 
 		if (player_status.audio_format.IsDefined())
 			r.Fmt(FMT_STRING(COMMAND_STATUS_AUDIO ": {}\n"),
-			      ToString(player_status.audio_format));
+			      player_status.audio_format);
 	}
 
 #ifdef ENABLE_DATABASE

src/command/StorageCommands.cxx

@@ -83,10 +83,6 @@ handle_listfiles_storage(Response &r, StorageDirectoryReader &reader)
 	}
 }
 
-#if defined(_WIN32) && GCC_CHECK_VERSION(4,6)
-#pragma GCC diagnostic pop
-#endif
-
 CommandResult
 handle_listfiles_storage(Response &r, Storage &storage, const char *uri)
 {

src/db/Configured.cxx

@@ -24,6 +24,7 @@
 #include "config/Param.hxx"
 #include "config/Block.hxx"
 #include "fs/AllocatedPath.hxx"
+#include "fs/FileSystem.hxx"
 #include "fs/StandardDirectory.hxx"
 #include "util/RuntimeError.hxx"
 
@@ -51,17 +52,30 @@ CreateConfiguredDatabase(const ConfigData &config,
 	} else {
 		/* if there is no override, use the cache directory */
 
-		const AllocatedPath cache_dir = GetUserCacheDir();
+		const AllocatedPath cache_dir = GetAppCacheDir();
 		if (cache_dir.IsNull())
 			return nullptr;
 
-		const auto db_file = cache_dir / Path::FromFS(PATH_LITERAL("mpd.db"));
+		const auto db_file = cache_dir / Path::FromFS(PATH_LITERAL("db"));
 		auto db_file_utf8 = db_file.ToUTF8();
 		if (db_file_utf8.empty())
 			return nullptr;
 
 		ConfigBlock block;
 		block.AddBlockParam("path", std::move(db_file_utf8), -1);
+
+		{
+			const auto mounts_dir = cache_dir
+				/ Path::FromFS(PATH_LITERAL("mounts"));
+			CreateDirectoryNoThrow(mounts_dir);
+
+			if (auto mounts_dir_utf8 = mounts_dir.ToUTF8();
+			    !mounts_dir_utf8.empty())
+				block.AddBlockParam("cache_directory",
+						    std::move(mounts_dir_utf8),
+						    -1);
+		}
+
 		return DatabaseGlobalInit(main_event_loop, io_event_loop,
 					  listener, block);
 	}

src/db/plugins/simple/Directory.cxx

@@ -126,6 +126,18 @@ Directory::LookupTargetSong(std::string_view _target) noexcept
 	return lr.directory->FindSong(lr.rest);
 }
 
+void
+Directory::ClearInPlaylist() noexcept
+{
+	assert(holding_db_lock());
+
+	for (auto &child : children)
+		child.ClearInPlaylist();
+
+	for (auto &song : songs)
+		song.in_playlist = false;
+}
+
 void
 Directory::PruneEmpty() noexcept
 {

src/db/plugins/simple/Directory.hxx

@@ -287,6 +287,14 @@ public:
 	 */
 	SongPtr RemoveSong(Song *song) noexcept;
 
+	/**
+	 * Recursively walk through the whole tree and set all
+	 * `Song::in_playlist` fields to `false`.
+	 *
+	 * Caller must lock the #db_mutex.
+	 */
+	void ClearInPlaylist() noexcept;
+
 	/**
 	 * Caller must lock the #db_mutex.
 	 */

src/db/plugins/simple/DirectorySave.cxx

@@ -168,12 +168,14 @@ directory_load(LineReader &file, Directory &directory)
 				throw FormatRuntimeError("Duplicate song '%s'", name);
 
 			std::string target;
+			bool in_playlist = false;
 			auto detached_song = song_load(file, name,
-						       &target);
+						       &target, &in_playlist);
 
 			auto song = std::make_unique<Song>(std::move(detached_song),
 							   directory);
 			song->target = std::move(target);
+			song->in_playlist = in_playlist;
 
 			directory.AddSong(std::move(song));
 		} else if ((p = StringAfterPrefix(line, PLAYLIST_META_BEGIN))) {

src/db/update/Archive.cxx

@@ -51,6 +51,15 @@ LockFindSong(Directory &directory, std::string_view name) noexcept
 	return directory.FindSong(name);
 }
 
+[[gnu::pure]]
+static bool
+IsAcceptableFilename(std::string_view name) noexcept
+{
+	return !name.empty() &&
+		/* newlines cannot be represented in MPD's protocol */
+		name.find('\n') == name.npos;
+}
+
 void
 UpdateWalk::UpdateArchiveTree(ArchiveFile &archive, Directory &directory,
 			      const char *name) noexcept
@@ -58,6 +67,9 @@ UpdateWalk::UpdateArchiveTree(ArchiveFile &archive, Directory &directory,
 	const char *tmp = std::strchr(name, '/');
 	if (tmp) {
 		const std::string_view child_name(name, tmp - name);
+		if (!IsAcceptableFilename(child_name))
+			return;
+
 		//add dir is not there already
 		Directory *subdir = LockMakeChild(directory, child_name);
 		subdir->device = DEVICE_INARCHIVE;
@@ -65,11 +77,8 @@ UpdateWalk::UpdateArchiveTree(ArchiveFile &archive, Directory &directory,
 		//create directories first
 		UpdateArchiveTree(archive, *subdir, tmp + 1);
 	} else {
-		if (StringIsEmpty(name)) {
+		if (!IsAcceptableFilename(name))
-			LogWarning(update_domain,
-				   "archive returned directory only");
 			return;
-		}
 
 		//add file
 		Song *song = LockFindSong(directory, name);

src/db/update/Walk.cxx

@@ -531,6 +531,7 @@ UpdateWalk::Walk(Directory &root, const char *path, bool discard) noexcept
 
 	{
 		const ScopeDatabaseLock protect;
+		root.ClearInPlaylist();
 		PurgeDanglingFromPlaylists(root);
 	}
 

src/decoder/DecoderList.cxx

@@ -114,11 +114,11 @@ constexpr const struct DecoderPlugin *decoder_plugins[] = {
 #ifdef ENABLE_ADPLUG
 	&adplug_decoder_plugin,
 #endif
-#ifdef ENABLE_FFMPEG
-	&ffmpeg_decoder_plugin,
-#endif
 #ifdef ENABLE_GME
 	&gme_decoder_plugin,
+#endif
+#ifdef ENABLE_FFMPEG
+	&ffmpeg_decoder_plugin,
 #endif
 	&pcm_decoder_plugin,
 	nullptr

src/decoder/plugins/FlacCommon.cxx

@@ -30,7 +30,7 @@
 
 bool
 FlacDecoder::Initialize(unsigned sample_rate, unsigned bits_per_sample,
-			unsigned channels, FLAC__uint64 total_frames)
+			unsigned channels, FLAC__uint64 total_frames) noexcept
 {
 	assert(!initialized);
 	assert(!unsupported);
@@ -60,7 +60,7 @@ FlacDecoder::Initialize(unsigned sample_rate, unsigned bits_per_sample,
 }
 
 inline void
-FlacDecoder::OnStreamInfo(const FLAC__StreamMetadata_StreamInfo &stream_info)
+FlacDecoder::OnStreamInfo(const FLAC__StreamMetadata_StreamInfo &stream_info) noexcept
 {
 	if (initialized)
 		return;
@@ -72,7 +72,7 @@ FlacDecoder::OnStreamInfo(const FLAC__StreamMetadata_StreamInfo &stream_info)
 }
 
 inline void
-FlacDecoder::OnVorbisComment(const FLAC__StreamMetadata_VorbisComment &vc)
+FlacDecoder::OnVorbisComment(const FLAC__StreamMetadata_VorbisComment &vc) noexcept
 {
 	ReplayGainInfo rgi;
 	if (flac_parse_replay_gain(rgi, vc))
@@ -86,7 +86,7 @@ FlacDecoder::OnVorbisComment(const FLAC__StreamMetadata_VorbisComment &vc)
 }
 
 void
-FlacDecoder::OnMetadata(const FLAC__StreamMetadata &metadata)
+FlacDecoder::OnMetadata(const FLAC__StreamMetadata &metadata) noexcept
 {
 	if (unsupported)
 		return;
@@ -106,7 +106,7 @@ FlacDecoder::OnMetadata(const FLAC__StreamMetadata &metadata)
 }
 
 inline bool
-FlacDecoder::OnFirstFrame(const FLAC__FrameHeader &header)
+FlacDecoder::OnFirstFrame(const FLAC__FrameHeader &header) noexcept
 {
 	if (unsupported)
 		return false;
@@ -139,7 +139,7 @@ FlacDecoder::GetDeltaPosition(const FLAC__StreamDecoder &sd)
 FLAC__StreamDecoderWriteStatus
 FlacDecoder::OnWrite(const FLAC__Frame &frame,
 		     const FLAC__int32 *const buf[],
-		     FLAC__uint64 nbytes)
+		     FLAC__uint64 nbytes) noexcept
 {
 	if (!initialized && !OnFirstFrame(frame.header))
 		return FLAC__STREAM_DECODER_WRITE_STATUS_ABORT;

src/decoder/plugins/FlacCommon.hxx

@@ -65,20 +65,21 @@ struct FlacDecoder : public FlacInput {
 	 */
 	ConstBuffer<void> chunk = nullptr;
 
-	FlacDecoder(DecoderClient &_client, InputStream &_input_stream)
+	FlacDecoder(DecoderClient &_client,
+		    InputStream &_input_stream) noexcept
 		:FlacInput(_input_stream, &_client) {}
 
 	/**
 	 * Wrapper for DecoderClient::Ready().
 	 */
 	bool Initialize(unsigned sample_rate, unsigned bits_per_sample,
-			unsigned channels, FLAC__uint64 total_frames);
+			unsigned channels, FLAC__uint64 total_frames) noexcept;
 
-	void OnMetadata(const FLAC__StreamMetadata &metadata);
+	void OnMetadata(const FLAC__StreamMetadata &metadata) noexcept;
 
 	FLAC__StreamDecoderWriteStatus OnWrite(const FLAC__Frame &frame,
 					       const FLAC__int32 *const buf[],
-					       FLAC__uint64 nbytes);
+					       FLAC__uint64 nbytes) noexcept;
 
 	/**
 	 * Calculate the delta (in bytes) between the last frame and
@@ -87,8 +88,8 @@ struct FlacDecoder : public FlacInput {
 	FLAC__uint64 GetDeltaPosition(const FLAC__StreamDecoder &sd);
 
 private:
-	void OnStreamInfo(const FLAC__StreamMetadata_StreamInfo &stream_info);
+	void OnStreamInfo(const FLAC__StreamMetadata_StreamInfo &stream_info) noexcept;
-	void OnVorbisComment(const FLAC__StreamMetadata_VorbisComment &vc);
+	void OnVorbisComment(const FLAC__StreamMetadata_VorbisComment &vc) noexcept;
 
 	/**
 	 * This function attempts to call DecoderClient::Ready() in case there
@@ -97,7 +98,7 @@ private:
 	 * providing the STREAMINFO block from the beginning of the file
 	 * (e.g. when seeking with SqueezeBox Server).
 	 */
-	bool OnFirstFrame(const FLAC__FrameHeader &header);
+	bool OnFirstFrame(const FLAC__FrameHeader &header) noexcept;
 };
 
 #endif /* _FLAC_COMMON_H */

src/decoder/plugins/FlacDecoderPlugin.cxx

@@ -24,6 +24,7 @@
 #include "lib/xiph/FlacMetadataChain.hxx"
 #include "OggCodec.hxx"
 #include "input/InputStream.hxx"
+#include "input/LocalOpen.hxx"
 #include "fs/Path.hxx"
 #include "fs/NarrowPath.hxx"
 #include "Log.hxx"
@@ -32,7 +33,8 @@
 #error libFLAC is too old
 #endif
 
-static void flacPrintErroredState(FLAC__StreamDecoderState state)
+static void
+flacPrintErroredState(FLAC__StreamDecoderState state) noexcept
 {
 	switch (state) {
 	case FLAC__STREAM_DECODER_SEARCH_FOR_METADATA:
@@ -53,8 +55,9 @@ static void flacPrintErroredState(FLAC__StreamDecoderState state)
 	LogError(flac_domain, FLAC__StreamDecoderStateString[state]);
 }
 
-static void flacMetadata([[maybe_unused]] const FLAC__StreamDecoder * dec,
+static void
-			 const FLAC__StreamMetadata * block, void *vdata)
+flacMetadata([[maybe_unused]] const FLAC__StreamDecoder * dec,
+	     const FLAC__StreamMetadata * block, void *vdata) noexcept
 {
 	auto &fd = *(FlacDecoder *)vdata;
 	fd.OnMetadata(*block);
@@ -62,29 +65,45 @@ static void flacMetadata([[maybe_unused]] const FLAC__StreamDecoder * dec,
 
 static FLAC__StreamDecoderWriteStatus
 flac_write_cb(const FLAC__StreamDecoder *dec, const FLAC__Frame *frame,
-	      const FLAC__int32 *const buf[], void *vdata)
+	      const FLAC__int32 *const buf[], void *vdata) noexcept
 {
 	auto &fd = *(FlacDecoder *)vdata;
 	return fd.OnWrite(*frame, buf, fd.GetDeltaPosition(*dec));
 }
 
 static bool
-flac_scan_file(Path path_fs, TagHandler &handler)
+flac_scan_file(Path path_fs, TagHandler &handler) noexcept {
-{
 	FlacMetadataChain chain;
-	if (!chain.Read(NarrowPath(path_fs))) {
+	const bool succeed = [&chain, &path_fs]() noexcept {
+		// read by NarrowPath
+		if (chain.Read(NarrowPath(path_fs))) {
+			return true;
+		}
+		if (std::is_same_v<Path::value_type, char> ||
+		    chain.GetStatus() != FLAC__METADATA_CHAIN_STATUS_ERROR_OPENING_FILE) {
+			return false;
+		}
+		// read by InputStream
+		Mutex mutex;
+		auto is = OpenLocalInputStream(path_fs, mutex);
+		if (is && chain.Read(*is)) {
+			return true;
+		}
+		return false;
+	}();
+
+	if (!succeed) {
 		FmtDebug(flac_domain,
 			 "Failed to read FLAC tags: {}",
 			 chain.GetStatusString());
 		return false;
 	}
-
 	chain.Scan(handler);
 	return true;
 }
 
 static bool
-flac_scan_stream(InputStream &is, TagHandler &handler)
+flac_scan_stream(InputStream &is, TagHandler &handler) noexcept
 {
 	FlacMetadataChain chain;
 	if (!chain.Read(is)) {
@@ -102,7 +121,7 @@ flac_scan_stream(InputStream &is, TagHandler &handler)
  * Some glue code around FLAC__stream_decoder_new().
  */
 static FlacStreamDecoder
-flac_decoder_new()
+flac_decoder_new() noexcept
 {
 	FlacStreamDecoder sd;
 	if(!FLAC__stream_decoder_set_metadata_respond(sd.get(), FLAC__METADATA_TYPE_VORBIS_COMMENT))
@@ -113,7 +132,7 @@ flac_decoder_new()
 }
 
 static bool
-flac_decoder_initialize(FlacDecoder *data, FLAC__StreamDecoder *sd)
+flac_decoder_initialize(FlacDecoder *data, FLAC__StreamDecoder *sd) noexcept
 {
 	if (!FLAC__stream_decoder_process_until_end_of_metadata(sd)) {
 		if (FLAC__stream_decoder_get_state(sd) != FLAC__STREAM_DECODER_END_OF_STREAM)
@@ -231,7 +250,7 @@ flac_decoder_loop(FlacDecoder *data, FLAC__StreamDecoder *flac_dec)
 }
 
 static FLAC__StreamDecoderInitStatus
-stream_init_oggflac(FLAC__StreamDecoder *flac_dec, FlacDecoder *data)
+stream_init_oggflac(FLAC__StreamDecoder *flac_dec, FlacDecoder *data) noexcept
 {
 	return FLAC__stream_decoder_init_ogg_stream(flac_dec,
 						    FlacInput::Read,
@@ -246,7 +265,7 @@ stream_init_oggflac(FLAC__StreamDecoder *flac_dec, FlacDecoder *data)
 }
 
 static FLAC__StreamDecoderInitStatus
-stream_init_flac(FLAC__StreamDecoder *flac_dec, FlacDecoder *data)
+stream_init_flac(FLAC__StreamDecoder *flac_dec, FlacDecoder *data) noexcept
 {
 	return FLAC__stream_decoder_init_stream(flac_dec,
 						FlacInput::Read,
@@ -261,7 +280,8 @@ stream_init_flac(FLAC__StreamDecoder *flac_dec, FlacDecoder *data)
 }
 
 static FLAC__StreamDecoderInitStatus
-stream_init(FLAC__StreamDecoder *flac_dec, FlacDecoder *data, bool is_ogg)
+stream_init(FLAC__StreamDecoder *flac_dec, FlacDecoder *data,
+	    bool is_ogg) noexcept
 {
 	return is_ogg
 		? stream_init_oggflac(flac_dec, data)
@@ -307,7 +327,7 @@ flac_decode(DecoderClient &client, InputStream &input_stream)
 }
 
 static bool
-oggflac_init([[maybe_unused]] const ConfigBlock &block)
+oggflac_init([[maybe_unused]] const ConfigBlock &block) noexcept
 {
 	return !!FLAC_API_SUPPORTS_OGG_FLAC;
 }

src/decoder/plugins/FlacInput.cxx

@@ -22,12 +22,11 @@
 #include "../DecoderAPI.hxx"
 #include "input/InputStream.hxx"
 #include "Log.hxx"
-#include "util/Compiler.h"
 
 #include <exception>
 
-FLAC__StreamDecoderReadStatus
+inline FLAC__StreamDecoderReadStatus
-FlacInput::Read(FLAC__byte buffer[], size_t *bytes)
+FlacInput::Read(FLAC__byte buffer[], size_t *bytes) noexcept
 {
 	size_t r = decoder_read(client, input_stream, (void *)buffer, *bytes);
 	*bytes = r;
@@ -44,8 +43,8 @@ FlacInput::Read(FLAC__byte buffer[], size_t *bytes)
 	return FLAC__STREAM_DECODER_READ_STATUS_CONTINUE;
 }
 
-FLAC__StreamDecoderSeekStatus
+inline FLAC__StreamDecoderSeekStatus
-FlacInput::Seek(FLAC__uint64 absolute_byte_offset)
+FlacInput::Seek(FLAC__uint64 absolute_byte_offset) noexcept
 {
 	if (!input_stream.IsSeekable())
 		return FLAC__STREAM_DECODER_SEEK_STATUS_UNSUPPORTED;
@@ -59,8 +58,8 @@ FlacInput::Seek(FLAC__uint64 absolute_byte_offset)
 	}
 }
 
-FLAC__StreamDecoderTellStatus
+inline FLAC__StreamDecoderTellStatus
-FlacInput::Tell(FLAC__uint64 *absolute_byte_offset)
+FlacInput::Tell(FLAC__uint64 *absolute_byte_offset) noexcept
 {
 	if (!input_stream.IsSeekable())
 		return FLAC__STREAM_DECODER_TELL_STATUS_UNSUPPORTED;
@@ -69,8 +68,8 @@ FlacInput::Tell(FLAC__uint64 *absolute_byte_offset)
 	return FLAC__STREAM_DECODER_TELL_STATUS_OK;
 }
 
-FLAC__StreamDecoderLengthStatus
+inline FLAC__StreamDecoderLengthStatus
-FlacInput::Length(FLAC__uint64 *stream_length)
+FlacInput::Length(FLAC__uint64 *stream_length) noexcept
 {
 	if (!input_stream.KnownSize())
 		return FLAC__STREAM_DECODER_LENGTH_STATUS_UNSUPPORTED;
@@ -79,8 +78,8 @@ FlacInput::Length(FLAC__uint64 *stream_length)
 	return FLAC__STREAM_DECODER_LENGTH_STATUS_OK;
 }
 
-FLAC__bool
+inline FLAC__bool
-FlacInput::Eof()
+FlacInput::Eof() noexcept
 {
 	return (client != nullptr &&
 		client->GetCommand() != DecoderCommand::NONE &&
@@ -88,8 +87,8 @@ FlacInput::Eof()
 		input_stream.LockIsEOF();
 }
 
-void
+inline void
-FlacInput::Error(FLAC__StreamDecoderErrorStatus status)
+FlacInput::Error(FLAC__StreamDecoderErrorStatus status) noexcept
 {
 	if (client == nullptr ||
 	    client->GetCommand() != DecoderCommand::STOP)
@@ -100,7 +99,7 @@ FlacInput::Error(FLAC__StreamDecoderErrorStatus status)
 FLAC__StreamDecoderReadStatus
 FlacInput::Read([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
 		FLAC__byte buffer[], size_t *bytes,
-		void *client_data)
+		void *client_data) noexcept
 {
 	auto *i = (FlacInput *)client_data;
 
@@ -109,7 +108,7 @@ FlacInput::Read([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
 
 FLAC__StreamDecoderSeekStatus
 FlacInput::Seek([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
-		FLAC__uint64 absolute_byte_offset, void *client_data)
+		FLAC__uint64 absolute_byte_offset, void *client_data) noexcept
 {
 	auto *i = (FlacInput *)client_data;
 
@@ -118,7 +117,7 @@ FlacInput::Seek([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
 
 FLAC__StreamDecoderTellStatus
 FlacInput::Tell([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
-		FLAC__uint64 *absolute_byte_offset, void *client_data)
+		FLAC__uint64 *absolute_byte_offset, void *client_data) noexcept
 {
 	auto *i = (FlacInput *)client_data;
 
@@ -127,7 +126,7 @@ FlacInput::Tell([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
 
 FLAC__StreamDecoderLengthStatus
 FlacInput::Length([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
-		  FLAC__uint64 *stream_length, void *client_data)
+		  FLAC__uint64 *stream_length, void *client_data) noexcept
 {
 	auto *i = (FlacInput *)client_data;
 
@@ -136,7 +135,7 @@ FlacInput::Length([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
 
 FLAC__bool
 FlacInput::Eof([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
-	       void *client_data)
+	       void *client_data) noexcept
 {
 	auto *i = (FlacInput *)client_data;
 
@@ -145,7 +144,8 @@ FlacInput::Eof([[maybe_unused]] const FLAC__StreamDecoder *flac_decoder,
 
 void
 FlacInput::Error([[maybe_unused]] const FLAC__StreamDecoder *decoder,
-		 FLAC__StreamDecoderErrorStatus status, void *client_data)
+		 FLAC__StreamDecoderErrorStatus status,
+		 void *client_data) noexcept
 {
 	auto *i = (FlacInput *)client_data;
 

src/decoder/plugins/FlacInput.hxx

@@ -48,36 +48,38 @@ public:
 	}
 
 protected:
-	FLAC__StreamDecoderReadStatus Read(FLAC__byte buffer[], size_t *bytes);
+	FLAC__StreamDecoderReadStatus Read(FLAC__byte buffer[], size_t *bytes) noexcept;
-	FLAC__StreamDecoderSeekStatus Seek(FLAC__uint64 absolute_byte_offset);
+	FLAC__StreamDecoderSeekStatus Seek(FLAC__uint64 absolute_byte_offset) noexcept;
-	FLAC__StreamDecoderTellStatus Tell(FLAC__uint64 *absolute_byte_offset);
+	FLAC__StreamDecoderTellStatus Tell(FLAC__uint64 *absolute_byte_offset) noexcept;
-	FLAC__StreamDecoderLengthStatus Length(FLAC__uint64 *stream_length);
+	FLAC__StreamDecoderLengthStatus Length(FLAC__uint64 *stream_length) noexcept;
-	FLAC__bool Eof();
+	FLAC__bool Eof() noexcept;
-	void Error(FLAC__StreamDecoderErrorStatus status);
+	void Error(FLAC__StreamDecoderErrorStatus status) noexcept;
 
 public:
 	static FLAC__StreamDecoderReadStatus
 	Read(const FLAC__StreamDecoder *flac_decoder,
-	     FLAC__byte buffer[], size_t *bytes, void *client_data);
+	     FLAC__byte buffer[], size_t *bytes, void *client_data) noexcept;
 
 	static FLAC__StreamDecoderSeekStatus
 	Seek(const FLAC__StreamDecoder *flac_decoder,
-	     FLAC__uint64 absolute_byte_offset, void *client_data);
+	     FLAC__uint64 absolute_byte_offset, void *client_data) noexcept;
 
 	static FLAC__StreamDecoderTellStatus
 	Tell(const FLAC__StreamDecoder *flac_decoder,
-	     FLAC__uint64 *absolute_byte_offset, void *client_data);
+	     FLAC__uint64 *absolute_byte_offset, void *client_data) noexcept;
 
 	static FLAC__StreamDecoderLengthStatus
 	Length(const FLAC__StreamDecoder *flac_decoder,
-	       FLAC__uint64 *stream_length, void *client_data);
+	       FLAC__uint64 *stream_length, void *client_data) noexcept;
 
 	static FLAC__bool
-	Eof(const FLAC__StreamDecoder *flac_decoder, void *client_data);
+	Eof(const FLAC__StreamDecoder *flac_decoder,
+	    void *client_data) noexcept;
 
 	static void
 	Error(const FLAC__StreamDecoder *decoder,
-	      FLAC__StreamDecoderErrorStatus status, void *client_data);
+	      FLAC__StreamDecoderErrorStatus status,
+	      void *client_data) noexcept;
 };
 
 #endif

src/decoder/plugins/FlacPcm.cxx

@@ -39,7 +39,8 @@ FlacPcmImport::Open(unsigned sample_rate, unsigned bits_per_sample,
 
 template<typename T>
 static void
-FlacImportStereo(T *dest, const FLAC__int32 *const src[], size_t n_frames)
+FlacImportStereo(T *dest, const FLAC__int32 *const src[],
+		 size_t n_frames) noexcept
 {
 	for (size_t i = 0; i != n_frames; ++i) {
 		*dest++ = (T)src[0][i];
@@ -50,7 +51,7 @@ FlacImportStereo(T *dest, const FLAC__int32 *const src[], size_t n_frames)
 template<typename T>
 static void
 FlacImportAny(T *dest, const FLAC__int32 *const src[], size_t n_frames,
-	      unsigned n_channels)
+	      unsigned n_channels) noexcept
 {
 	for (size_t i = 0; i != n_frames; ++i)
 		for (unsigned c = 0; c != n_channels; ++c)
@@ -60,7 +61,7 @@ FlacImportAny(T *dest, const FLAC__int32 *const src[], size_t n_frames,
 template<typename T>
 static void
 FlacImport(T *dest, const FLAC__int32 *const src[], size_t n_frames,
-	   unsigned n_channels)
+	   unsigned n_channels) noexcept
 {
 	if (n_channels == 2)
 		FlacImportStereo(dest, src, n_frames);
@@ -71,7 +72,7 @@ FlacImport(T *dest, const FLAC__int32 *const src[], size_t n_frames,
 template<typename T>
 static ConstBuffer<void>
 FlacImport(PcmBuffer &buffer, const FLAC__int32 *const src[], size_t n_frames,
-	   unsigned n_channels)
+	   unsigned n_channels) noexcept
 {
 	size_t n_samples = n_frames * n_channels;
 	size_t dest_size = n_samples * sizeof(T);

src/decoder/plugins/FlacPcm.hxx

@@ -43,7 +43,7 @@ public:
 	void Open(unsigned sample_rate, unsigned bits_per_sample,
 		  unsigned channels);
 
-	const AudioFormat &GetAudioFormat() const {
+	const AudioFormat &GetAudioFormat() const noexcept {
 		return audio_format;
 	}
 

src/decoder/plugins/GmeDecoderPlugin.cxx

@@ -56,20 +56,17 @@ struct GmeContainerPath {
 	unsigned track;
 };
 
-#if GME_VERSION >= 0x000600
 static int gme_accuracy;
-#endif
 static unsigned gme_default_fade;
 
 static bool
 gme_plugin_init([[maybe_unused]] const ConfigBlock &block)
 {
-#if GME_VERSION >= 0x000600
 	auto accuracy = block.GetBlockParam("accuracy");
 	gme_accuracy = accuracy != nullptr
 		? (int)accuracy->GetBoolValue()
 		: -1;
-#endif
+
 	auto fade = block.GetBlockParam("default_fade");
 	gme_default_fade = fade != nullptr
 		? fade->GetUnsignedValue() * 1000
@@ -163,10 +160,8 @@ gme_file_decode(DecoderClient &client, Path path_fs)
 	FmtDebug(gme_domain, "emulator type '{}'",
 		 gme_type_system(gme_type(emu)));
 
-#if GME_VERSION >= 0x000600
 	if (gme_accuracy >= 0)
 		gme_enable_accuracy(emu, gme_accuracy);
-#endif
 
 	gme_info_t *ti;
 	const char *gme_err = gme_track_info(emu, &ti, container.track);

src/decoder/plugins/MadDecoderPlugin.cxx

@@ -562,7 +562,21 @@ parse_lame(struct lame *lame, struct mad_bitptr *ptr, int *bitlen) noexcept
 
 	mad_bit_skip(ptr, 16);
 
-	lame->peak = MAD_F(mad_bit_read(ptr, 32) << 5); /* peak */
+	/* The lame peak value is a float multiplied by 2^23 and stored as an
+	 * unsigned integer (it is always positive). MAD's fixed-point format uses
+	 * 28 bits for the fractional part, so shift the 23 bit fraction up before
+	 * converting to a float.
+	 */
+	unsigned long peak_int = mad_bit_read(ptr, 32);
+
+#define LAME_PEAK_FRACBITS 23
+#if MAD_F_FRACBITS > LAME_PEAK_FRACBITS
+	peak_int <<= (MAD_F_FRACBITS - LAME_PEAK_FRACBITS);
+#elif LAME_PEAK_FRACBITS > MAD_F_FRACBITS
+	peak_int >>= (LAME_PEAK_FRACBITS - MAD_F_FRACBITS);
+#endif
+
+	lame->peak = mad_f_todouble(peak_int); /* peak */
 	FmtDebug(mad_domain, "LAME peak found: {}", lame->peak);
 
 	lame->track_gain = 0;
@@ -798,6 +812,8 @@ MadDecoder::UpdateTimerNextFrame() noexcept
 DecoderCommand
 MadDecoder::SubmitPCM(size_t i, size_t pcm_length) noexcept
 {
+	assert(i <= pcm_length);
+
 	size_t num_samples = pcm_length - i;
 
 	mad_fixed_to_24_buffer(output_buffer, synth.pcm,
@@ -843,7 +859,7 @@ MadDecoder::SynthAndSubmit() noexcept
 	size_t pcm_length = synth.pcm.length;
 	if (drop_end_samples &&
 	    current_frame == max_frames - drop_end_frames - 1) {
-		if (drop_end_samples >= pcm_length)
+		if (i + drop_end_samples >= pcm_length)
 			return DecoderCommand::STOP;
 
 		pcm_length -= drop_end_samples;

src/decoder/plugins/meson.build

@@ -81,7 +81,7 @@ if libfaad_dep.found()
   decoder_plugins_sources += 'FaadDecoderPlugin.cxx'
 endif
 
-libgme_dep = c_compiler.find_library('gme', required: get_option('gme'))
+libgme_dep = dependency('libgme', version: '>= 0.6', required: get_option('gme'))
 decoder_features.set('ENABLE_GME', libgme_dep.found())
 if libgme_dep.found()
   decoder_plugins_sources += 'GmeDecoderPlugin.cxx'

src/event/Loop.cxx

@@ -272,9 +272,8 @@ EventLoop::Run() noexcept
 #endif
 
 	assert(IsInside());
-	assert(!quit);
 #ifdef HAVE_THREADED_EVENT_LOOP
-	assert(alive);
+	assert(alive || quit);
 	assert(busy);
 
 	wake_event.Schedule(SocketEvent::READ);
@@ -299,7 +298,7 @@ EventLoop::Run() noexcept
 
 	steady_clock_cache.flush();
 
-	do {
+	while (!quit) {
 		again = false;
 
 		/* invoke timers */
@@ -361,7 +360,7 @@ EventLoop::Run() noexcept
 
 			socket_event.Dispatch();
 		}
-	} while (!quit);
+	}
 
 #ifdef HAVE_THREADED_EVENT_LOOP
 #ifndef NDEBUG

src/fs/Charset.cxx

@@ -20,7 +20,6 @@
 #include "Charset.hxx"
 #include "Features.hxx"
 #include "Domain.hxx"
-#include "Log.hxx"
 #include "lib/icu/Converter.hxx"
 #include "util/AllocatedString.hxx"
 #include "config.h"
@@ -45,11 +44,9 @@ SetFSCharset(const char *charset)
 	assert(charset != nullptr);
 	assert(fs_converter == nullptr);
 
+	fs_charset = charset;
 	fs_converter = IcuConverter::Create(charset);
 	assert(fs_converter != nullptr);
-
-	FmtDebug(path_domain,
-		 "SetFSCharset: fs charset is {}", fs_charset);
 }
 
 #endif

src/fs/FileSystem.hxx

@@ -67,6 +67,16 @@ StatFile(Path file, struct stat &buf, bool follow_symlinks = true)
 
 #endif
 
+static inline bool
+CreateDirectoryNoThrow(Path path) noexcept
+{
+#ifdef _WIN32
+	return CreateDirectory(path.c_str(), nullptr);
+#else
+	return mkdir(path.c_str(), 0777);
+#endif
+}
+
 /**
  * Truncate a file that exists already.  Throws std::system_error on
  * error.

src/fs/StandardDirectory.cxx

@@ -34,7 +34,6 @@
 #include <shlobj.h>
 #else
 #include <stdlib.h>
-#include <unistd.h>
 #include <pwd.h>
 #endif
 
@@ -53,6 +52,12 @@
 #include "Main.hxx"
 #endif
 
+#ifdef USE_XDG
+#include "Version.h" // for PACKAGE_NAME
+#define APP_FILENAME PATH_LITERAL(PACKAGE_NAME)
+static constexpr Path app_filename = Path::FromFS(APP_FILENAME);
+#endif
+
 #if !defined(_WIN32) && !defined(ANDROID)
 class PasswdEntry
 {
@@ -74,15 +79,6 @@ public:
 		return result != nullptr;
 	}
 
-	bool ReadByUid(uid_t uid) {
-#ifdef HAVE_GETPWUID_R
-		getpwuid_r(uid, &pw, buf.data(), buf.size(), &result);
-#else
-		result = getpwuid(uid);
-#endif
-		return result != nullptr;
-	}
-
 	const passwd *operator->() {
 		assert(result != nullptr);
 		return result;
@@ -284,6 +280,24 @@ GetUserCacheDir() noexcept
 #endif
 }
 
+AllocatedPath
+GetAppCacheDir() noexcept
+{
+#ifdef USE_XDG
+	if (const auto user_dir = GetUserCacheDir(); !user_dir.IsNull()) {
+		auto dir = user_dir / app_filename;
+		CreateDirectoryNoThrow(dir);
+		return dir;
+	}
+
+	return nullptr;
+#elif defined(ANDROID)
+	return context->GetCacheDir(Java::GetEnv());
+#else
+	return nullptr;
+#endif
+}
+
 AllocatedPath
 GetUserRuntimeDir() noexcept
 {
@@ -297,7 +311,7 @@ GetUserRuntimeDir() noexcept
 AllocatedPath
 GetAppRuntimeDir() noexcept
 {
-#ifdef __linux__
+#if defined(__linux__) && !defined(ANDROID)
 	/* systemd specific; see systemd.exec(5) */
 	if (const char *runtime_directory = getenv("RUNTIME_DIRECTORY"))
 		if (auto dir = StringView{runtime_directory}.Split(':').first;
@@ -307,8 +321,8 @@ GetAppRuntimeDir() noexcept
 
 #ifdef USE_XDG
 	if (const auto user_dir = GetUserRuntimeDir(); !user_dir.IsNull()) {
-		auto dir = user_dir / Path::FromFS("mpd");
+		auto dir = user_dir / app_filename;
-		mkdir(dir.c_str(), 0700);
+		CreateDirectoryNoThrow(dir);
 		return dir;
 	}
 #endif
@@ -351,10 +365,8 @@ GetHomeDir() noexcept
 	if (const auto home = getenv("HOME");
 	    IsValidPathString(home) && IsValidDir(home))
 		return AllocatedPath::FromFS(home);
-
-	if (PasswdEntry pw; pw.ReadByUid(getuid()))
-		return SafePathFromFS(pw->pw_dir);
 #endif
+
 	return nullptr;
 }
 

src/fs/StandardDirectory.hxx

@@ -43,6 +43,13 @@ GetUserMusicDir() noexcept;
 AllocatedPath
 GetUserCacheDir() noexcept;
 
+/**
+ * Obtains cache directory for this application.
+ */
+[[gnu::const]]
+AllocatedPath
+GetAppCacheDir() noexcept;
+
 /**
  * Obtains the runtime directory for the current user.
  */

src/input/AsyncInputStream.cxx

@@ -101,9 +101,17 @@ AsyncInputStream::Seek(std::unique_lock<Mutex> &lock,
 	assert(IsReady());
 	assert(seek_state == SeekState::NONE);
 
-	if (new_offset == offset)
+	if (new_offset == offset) {
-		/* no-op */
+		/* no-op, but if the stream is not open anymore (maybe
+		   because it has failed), nothing can be read, so we
+		   should check for errors here instead of pretending
+		   everything's fine */
+
+		if (!open)
+			Check();
+
 		return;
+	}
 
 	if (!IsSeekable())
 		throw std::runtime_error("Not seekable");

src/input/plugins/CurlInputPlugin.cxx

@@ -417,7 +417,6 @@ CurlInputStream::InitEasy()
 	request->SetOption(CURLOPT_HTTP200ALIASES, http_200_aliases);
 	request->SetOption(CURLOPT_FOLLOWLOCATION, 1L);
 	request->SetOption(CURLOPT_MAXREDIRS, 5L);
-	request->SetOption(CURLOPT_FAILONERROR, 1L);
 
 	/* this option eliminates the probe request when
 	   username/password are specified */
@@ -439,8 +438,14 @@ CurlInputStream::InitEasy()
 	request->SetVerifyPeer(verify_peer);
 	request->SetVerifyHost(verify_host);
 	request->SetOption(CURLOPT_HTTPHEADER, request_headers.Get());
-	request->SetProxyVerifyPeer(verify_peer);
+
-	request->SetProxyVerifyHost(verify_host);
+	try {
+		request->SetProxyVerifyPeer(verify_peer);
+		request->SetProxyVerifyHost(verify_host);
+	} catch (...) {
+		/* these methods fail if libCURL was compiled with
+		   CURL_DISABLE_PROXY; ignore silently */
+	}
 }
 
 void

src/io/FileReader.hxx

@@ -42,6 +42,8 @@
 #include "io/UniqueFileDescriptor.hxx"
 #endif
 
+#include <cstdint>
+
 class Path;
 class FileInfo;
 

src/lib/crypto/meson.build

@@ -18,13 +18,13 @@ endif
 
 conf.set('HAVE_MD5', crypto_md5_dep.found())
 
-if libavutil_dep.found()
+if ffmpeg_util_dep.found()
   crypto_base64 = static_library(
     'crypto_base64',
     'Base64.cxx',
     include_directories: inc,
     dependencies: [
-      libavutil_dep,
+      ffmpeg_util_dep,
     ],
   )
 

src/lib/curl/Easy.hxx

@@ -186,10 +186,6 @@ public:
 		SetOption(CURLOPT_POSTFIELDSIZE, (long)size);
 	}
 
-	void SetHttpPost(const struct curl_httppost *post) {
-		SetOption(CURLOPT_HTTPPOST, post);
-	}
-
 	template<typename T>
 	bool GetInfo(CURLINFO info, T value_r) const noexcept {
 		return ::curl_easy_getinfo(handle, info, value_r) == CURLE_OK;
@@ -199,10 +195,10 @@ public:
 	 * Returns the response body's size, or -1 if that is unknown.
 	 */
 	[[gnu::pure]]
-	int64_t GetContentLength() const noexcept {
+	curl_off_t GetContentLength() const noexcept {
-		double value;
+		curl_off_t value;
-		return GetInfo(CURLINFO_CONTENT_LENGTH_DOWNLOAD, &value)
+		return GetInfo(CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, &value)
-			? (int64_t)value
+			? value
 			: -1;
 	}
 

src/lib/curl/meson.build

@@ -1,4 +1,4 @@
-curl_dep = dependency('libcurl', version: '>= 7.33', required: get_option('curl'))
+curl_dep = dependency('libcurl', version: '>= 7.55', required: get_option('curl'))
 conf.set('ENABLE_CURL', curl_dep.found())
 if not curl_dep.found()
   subdir_done()

src/lib/dbus/AppendIter.hxx

@@ -36,6 +36,7 @@
 #include "Iter.hxx"
 #include "Values.hxx"
 
+#include <cstdint>
 #include <stdexcept>
 
 namespace ODBus {

src/lib/ffmpeg/LogError.cxx

@@ -1,42 +0,0 @@
-/*
- * Copyright 2003-2021 The Music Player Daemon Project
- * http://www.musicpd.org
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- */
-
-#include "LogError.hxx"
-#include "Domain.hxx"
-#include "Log.hxx"
-
-extern "C" {
-#include <libavutil/error.h>
-}
-
-void
-LogFfmpegError(int errnum)
-{
-	char msg[256];
-	av_strerror(errnum, msg, sizeof(msg));
-	LogError(ffmpeg_domain, msg);
-}
-
-void
-LogFfmpegError(int errnum, const char *prefix)
-{
-	char msg[256];
-	av_strerror(errnum, msg, sizeof(msg));
-	FmtError(ffmpeg_domain, "{}: {}", prefix, msg);
-}

src/lib/ffmpeg/LogError.hxx

@@ -1,29 +0,0 @@
-/*
- * Copyright 2003-2021 The Music Player Daemon Project
- * http://www.musicpd.org
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
- */
-
-#ifndef MPD_FFMPEG_LOG_ERROR_HXX
-#define MPD_FFMPEG_LOG_ERROR_HXX
-
-void
-LogFfmpegError(int errnum);
-
-void
-LogFfmpegError(int errnum, const char *prefix);
-
-#endif

src/lib/ffmpeg/meson.build

@@ -13,6 +13,29 @@ else
 endif
 conf.set('HAVE_LIBAVFILTER', libavfilter_dep.found())
 
+if not libavutil_dep.found()
+  ffmpeg_util_dep = dependency('', required: false)
+  ffmpeg_dep = dependency('', required: false)
+  subdir_done()
+endif
+
+ffmpeg_util = static_library(
+  'ffmpeg_util',
+  'Interleave.cxx',
+  'Error.cxx',
+  include_directories: inc,
+  dependencies: [
+    libavutil_dep,
+  ],
+)
+
+ffmpeg_util_dep = declare_dependency(
+  link_with: ffmpeg_util,
+  dependencies: [
+    libavutil_dep,
+  ],
+)
+
 if not enable_ffmpeg
   ffmpeg_dep = dependency('', required: false)
   subdir_done()
@@ -30,17 +53,16 @@ ffmpeg = static_library(
   'ffmpeg',
   'Init.cxx',
   'Interleave.cxx',
-  'LogError.cxx',
   'LogCallback.cxx',
   'Error.cxx',
   'Domain.cxx',
   ffmpeg_sources,
   include_directories: inc,
   dependencies: [
+    ffmpeg_util_dep,
     libavformat_dep,
     libavcodec_dep,
     libavfilter_dep,
-    libavutil_dep,
     log_dep,
   ],
 )
@@ -48,9 +70,9 @@ ffmpeg = static_library(
 ffmpeg_dep = declare_dependency(
   link_with: ffmpeg,
   dependencies: [
+    ffmpeg_util_dep,
     libavformat_dep,
     libavcodec_dep,
     libavfilter_dep,
-    libavutil_dep,
   ],
 )

src/lib/modplug/patches/no_register

@@ -0,0 +1,22 @@
+Index: libmodplug-0.8.9.0/src/fastmix.cpp
+===================================================================
+--- libmodplug-0.8.9.0.orig/src/fastmix.cpp
++++ libmodplug-0.8.9.0/src/fastmix.cpp
+@@ -288,7 +288,7 @@ CzWINDOWEDFIR sfir;
+ // MIXING MACROS
+ // ----------------------------------------------------------------------------
+ #define SNDMIX_BEGINSAMPLELOOP8\
+-	register MODCHANNEL * const pChn = pChannel;\
++	MODCHANNEL * const pChn = pChannel;\
+ 	nPos = pChn->nPosLo;\
+ 	const signed char *p = (signed char *)(pChn->pCurrentSample+pChn->nPos);\
+ 	if (pChn->dwFlags & CHN_STEREO) p += pChn->nPos;\
+@@ -296,7 +296,7 @@ CzWINDOWEDFIR sfir;
+ 	do {
+ 
+ #define SNDMIX_BEGINSAMPLELOOP16\
+-	register MODCHANNEL * const pChn = pChannel;\
++	MODCHANNEL * const pChn = pChannel;\
+ 	nPos = pChn->nPosLo;\
+ 	const signed short *p = (signed short *)(pChn->pCurrentSample+(pChn->nPos*2));\
+ 	if (pChn->dwFlags & CHN_STEREO) p += pChn->nPos;\

src/lib/modplug/patches/series

@@ -0,0 +1 @@
+no_register

src/output/plugins/OSXOutputPlugin.cxx

@@ -627,7 +627,7 @@ osx_render(void *vdata,
 {
 	OSXOutput *od = (OSXOutput *) vdata;
 
-	int count = in_number_frames * od->asbd.mBytesPerFrame;
+	std::size_t count = in_number_frames * od->asbd.mBytesPerFrame;
 	buffer_list->mBuffers[0].mDataByteSize =
 		od->ring_buffer->pop((uint8_t *)buffer_list->mBuffers[0].mData,
 				     count);

src/output/plugins/PipeWireOutputPlugin.cxx

@@ -523,7 +523,13 @@ PipeWireOutput::Open(AudioFormat &audio_format)
 		pw_properties_setf(props, PW_KEY_REMOTE_NAME, "%s", remote);
 
 	if (target != nullptr && target_id == PW_ID_ANY)
-		pw_properties_setf(props, PW_KEY_NODE_TARGET, "%s", target);
+		pw_properties_setf(props,
+#if PW_CHECK_VERSION(0, 3, 64)
+				   PW_KEY_TARGET_OBJECT,
+#else
+				   PW_KEY_NODE_TARGET,
+#endif
+				   "%s", target);
 
 #ifdef PW_KEY_NODE_RATE
 	/* ask PipeWire to change the graph sample rate to ours
@@ -967,6 +973,8 @@ PipeWireOutput::SendTag(const Tag &tag)
 
 	struct spa_dict dict = SPA_DICT_INIT(items, n_items);
 
+	const PipeWire::ThreadLoopLock lock(thread_loop);
+
 	auto rc = pw_stream_update_properties(stream, &dict);
 	if (rc < 0)
 		LogWarning(pipewire_output_domain, "Error updating properties");

src/output/plugins/wasapi/WasapiOutputPlugin.cxx

@@ -1026,7 +1026,7 @@ WasapiOutput::EnumerateDevices(IMMDeviceEnumerator &enumerator)
 			continue;
 
 		FmtNotice(wasapi_output_domain,
-			  "Device \"{}\" \"{}\"", i, name);
+			  "Device \"{}\" \"{}\"", i, name.c_str());
 	}
 }
 

src/storage/meson.build

@@ -17,7 +17,6 @@ storage_glue = static_library(
   'CompositeStorage.cxx',
   'MemoryDirectoryReader.cxx',
   'Configured.cxx',
-  'StorageState.cxx',
   include_directories: inc,
   dependencies: [
     boost_dep,
@@ -31,4 +30,3 @@ storage_glue_dep = declare_dependency(
     storage_plugins_dep,
   ],
 )
-

src/storage/plugins/CurlStorage.cxx

@@ -22,6 +22,7 @@
 #include "storage/StorageInterface.hxx"
 #include "storage/FileInfo.hxx"
 #include "storage/MemoryDirectoryReader.hxx"
+#include "lib/curl/Error.hxx"
 #include "lib/curl/Init.hxx"
 #include "lib/curl/Global.hxx"
 #include "lib/curl/Slist.hxx"
@@ -300,8 +301,9 @@ private:
 	/* virtual methods from CurlResponseHandler */
 	void OnHeaders(unsigned status, Curl::Headers &&headers) final {
 		if (status != 207)
-			throw FormatRuntimeError("Status %d from WebDAV server; expected \"207 Multi-Status\"",
+			throw HttpStatusError(status,
-						 status);
+					      StringFormat<80>("Status %u from WebDAV server; expected \"207 Multi-Status\"",
+							       status).c_str());
 
 		if (!IsXmlContentType(headers))
 			throw std::runtime_error("Unexpected Content-Type from WebDAV server");

src/system/Error.hxx

@@ -70,8 +70,11 @@ FormatLastError(DWORD code, const char *fmt, Args&&... args) noexcept
 {
 	char buffer[512];
 	const auto end = buffer + sizeof(buffer);
-	size_t length = snprintf(buffer, sizeof(buffer) - 128,
+	constexpr std::size_t max_prefix = sizeof(buffer) - 128;
+	size_t length = snprintf(buffer, max_prefix,
 				 fmt, std::forward<Args>(args)...);
+	if (length >= max_prefix)
+		length = max_prefix - 1;
 	char *p = buffer + length;
 	*p++ = ':';
 	*p++ = ' ';

src/tag/Builder.cxx

@@ -263,8 +263,14 @@ TagBuilder::RemoveAll() noexcept
 void
 TagBuilder::RemoveType(TagType type) noexcept
 {
+	if (items.empty())
+		/* don't acquire the tag_pool_lock if we're not going
+		   to call tag_pool_put_item() anyway */
+		return;
+
 	const auto begin = items.begin(), end = items.end();
 
+	const std::scoped_lock<Mutex> protect(tag_pool_lock);
 	items.erase(std::remove_if(begin, end,
 				   [type](TagItem *item) {
 					   if (item->type != type)

src/tag/Mask.hxx

@@ -26,6 +26,11 @@
 
 class TagMask {
 	typedef uint_least32_t mask_t;
+
+	/* the mask must have enough bits to represent all tags
+	   supported by MPD */
+	static_assert(TAG_NUM_OF_ITEM_TYPES <= sizeof(mask_t) * 8);
+
 	mask_t value;
 
 	explicit constexpr TagMask(uint_least32_t _value) noexcept

src/thread/WindowsFuture.hxx

@@ -130,7 +130,7 @@ public:
 
 	void set_value(const T &value) {
 		std::unique_lock<CriticalSection> lock(mutex);
-		if (!std::holds_alternative<std::monostate>(&result)) {
+		if (!std::holds_alternative<std::monostate>(result)) {
 			throw WinFutureError(WinFutureErrc::promise_already_satisfied);
 		}
 		result.template emplace<T>(value);

src/unix/SignalHandlers.cxx

@@ -30,6 +30,10 @@
 
 #include <csignal>
 
+#ifdef __linux__
+#include <sys/prctl.h>
+#endif
+
 static constexpr Domain signal_handlers_domain("signal_handlers");
 
 static void
@@ -60,7 +64,7 @@ handle_reload_event(void *ctx) noexcept
 #endif
 
 void
-SignalHandlersInit(Instance &instance)
+SignalHandlersInit(Instance &instance, bool daemon)
 {
 	auto &loop = instance.event_loop;
 
@@ -79,6 +83,14 @@ SignalHandlersInit(Instance &instance)
 
 	SignalMonitorRegister(SIGHUP, {&instance, handle_reload_event});
 #endif
+
+	if (!daemon) {
+#ifdef __linux__
+		/* if MPD was not daemonized, shut it down when the
+		   parent process dies */
+		prctl(PR_SET_PDEATHSIG, SIGTERM);
+#endif
+	}
 }
 
 void

src/unix/SignalHandlers.hxx

@@ -23,15 +23,15 @@
 struct Instance;
 
 void
-SignalHandlersInit(Instance &instance);
+SignalHandlersInit(Instance &instance, bool daemon);
 
 void
 SignalHandlersFinish() noexcept;
 
 class ScopeSignalHandlersInit {
 public:
-	ScopeSignalHandlersInit(Instance &instance) {
+	ScopeSignalHandlersInit(Instance &instance, bool daemon) {
-		SignalHandlersInit(instance);
+		SignalHandlersInit(instance, daemon);
 	}
 
 	~ScopeSignalHandlersInit() noexcept {

src/util/ScopeExit.hxx

@@ -40,14 +40,17 @@ class ScopeExitGuard : F {
 	bool enabled = true;
 
 public:
-	explicit ScopeExitGuard(F &&f):F(std::forward<F>(f)) {}
+	explicit ScopeExitGuard(F &&f) noexcept:F(std::forward<F>(f)) {}
 
-	ScopeExitGuard(ScopeExitGuard &&src)
+	ScopeExitGuard(ScopeExitGuard &&src) noexcept
-		:F(std::move(src)), enabled(src.enabled) {
+		:F(std::move(src)),
-		src.enabled = false;
+		 enabled(std::exchange(src.enabled, false)) {}
-	}
 
-	~ScopeExitGuard() {
+	/* destructors are "noexcept" by default; this explicit
+	   "noexcept" declaration allows the destructor to throw if
+	   the function can throw; without this, a throwing function
+	   would std::terminate() */
+	~ScopeExitGuard() noexcept(noexcept(std::declval<F>()())) {
 		if (enabled)
 			F::operator()();
 	}
@@ -64,7 +67,7 @@ struct ScopeExitTag {
 	   parantheses at the end of the expression AtScopeExit()
 	   call */
 	template<typename F>
-	ScopeExitGuard<F> operator+(F &&f) {
+	ScopeExitGuard<F> operator+(F &&f) noexcept {
 		return ScopeExitGuard<F>(std::forward<F>(f));
 	}
 };

src/win32/ComWorker.hxx

@@ -52,17 +52,17 @@ public:
 		using R = std::invoke_result_t<std::decay_t<Function>>;
 		auto promise = std::make_shared<Promise<R>>();
 		auto future = promise->get_future();
-		Push([function = std::forward<Function>(function),
+		Push([func = std::forward<Function>(function),
-			      promise = std::move(promise)]() mutable {
+			      prom = std::move(promise)]() mutable {
 			try {
 				if constexpr (std::is_void_v<R>) {
-					std::invoke(std::forward<Function>(function));
+					std::invoke(std::forward<Function>(func));
-					promise->set_value();
+					prom->set_value();
 				} else {
-					promise->set_value(std::invoke(std::forward<Function>(function)));
+					prom->set_value(std::invoke(std::forward<Function>(func)));
 				}
 			} catch (...) {
-				promise->set_exception(std::current_exception());
+				prom->set_exception(std::current_exception());
 			}
 		});
 		return future;

subprojects/expat.wrap

@@ -1,12 +1,13 @@
 [wrap-file]
-directory = expat-2.4.9
+directory = expat-2.5.0
-source_url = https://github.com/libexpat/libexpat/releases/download/R_2_4_9/expat-2.4.9.tar.xz
+source_url = https://github.com/libexpat/libexpat/releases/download/R_2_5_0/expat-2.5.0.tar.xz
-source_filename = expat-2.4.9.tar.bz2
+source_filename = expat-2.5.0.tar.bz2
-source_hash = 6e8c0728fe5c7cd3f93a6acce43046c5e4736c7b4b68e032e9350daa0efc0354
+source_hash = ef2420f0232c087801abf705e89ae65f6257df6b7931d37846a193ef2e8cdcbe
-patch_filename = expat_2.4.9-1_patch.zip
+patch_filename = expat_2.5.0-2_patch.zip
-patch_url = https://wrapdb.mesonbuild.com/v2/expat_2.4.9-1/get_patch
+patch_url = https://wrapdb.mesonbuild.com/v2/expat_2.5.0-2/get_patch
-patch_hash = 51b42d935008552f9d6c4d3e7511b84690a2a0c9d90165d1d192fc892f0a4787
+patch_hash = f6cc5ff0d909a2f51a907cc6ca655fb18517a0f58bbe67e4a9c621f1549560c9
-wrapdb_version = 2.4.9-1
+source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/expat_2.5.0-2/expat-2.5.0.tar.bz2
+wrapdb_version = 2.5.0-2
 
 [provide]
 expat = expat_dep

subprojects/fmt.wrap

@@ -1,12 +1,12 @@
 [wrap-file]
-directory = fmt-9.0.0
+directory = fmt-9.1.0
-source_url = https://github.com/fmtlib/fmt/archive/9.0.0.tar.gz
+source_url = https://github.com/fmtlib/fmt/archive/9.1.0.tar.gz
-source_filename = fmt-9.0.0.tar.gz
+source_filename = fmt-9.1.0.tar.gz
-source_hash = 9a1e0e9e843a356d65c7604e2c8bf9402b50fe294c355de0095ebd42fb9bd2c5
+source_hash = 5dea48d1fcddc3ec571ce2058e13910a0d4a6bab4cc09a809d8b1dd1c88ae6f2
-patch_filename = fmt_9.0.0-1_patch.zip
+patch_filename = fmt_9.1.0-1_patch.zip
-patch_url = https://wrapdb.mesonbuild.com/v2/fmt_9.0.0-1/get_patch
+patch_url = https://wrapdb.mesonbuild.com/v2/fmt_9.1.0-1/get_patch
-patch_hash = 5f12924065e0fe7ccae40593d256a082955c273cb2880b3e3de05df9d8d10697
+patch_hash = 4557b9ba87b3eb63694ed9b21d1a2117d4a97ca56b91085b10288e9a5294adf8
-wrapdb_version = 9.0.0-1
+wrapdb_version = 9.1.0-1
 
 [provide]
 fmt = fmt_dep

subprojects/sqlite3.wrap

@@ -1,12 +1,13 @@
 [wrap-file]
-directory = sqlite-amalgamation-3390300
+directory = sqlite-amalgamation-3410200
-source_url = https://sqlite.org/2022/sqlite-amalgamation-3390300.zip
+source_url = https://www.sqlite.org/2023/sqlite-amalgamation-3410200.zip
-source_filename = sqlite-amalgamation-3390300.zip
+source_filename = sqlite-amalgamation-3410200.zip
-source_hash = a89db3030d229d860ae56a8bac50ac9761434047ae886e47e7c8f9f428fa98ad
+source_hash = 01df06a84803c1ab4d62c64e995b151b2dbcf5dbc93bbc5eee213cb18225d987
-patch_filename = sqlite3_3.39.3-1_patch.zip
+patch_filename = sqlite3_3.41.2-2_patch.zip
-patch_url = https://wrapdb.mesonbuild.com/v2/sqlite3_3.39.3-1/get_patch
+patch_url = https://wrapdb.mesonbuild.com/v2/sqlite3_3.41.2-2/get_patch
-patch_hash = f5c41ff7b3da1108ed221b9a820b41188550cafb8a6c3d247bb40bd598775050
+patch_hash = 246681dfb731a14bfa61bcde651d5581a7e1c7d14851bfb57a941fac540a6810
-wrapdb_version = 3.39.3-1
+source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/sqlite3_3.41.2-2/sqlite-amalgamation-3410200.zip
+wrapdb_version = 3.41.2-2
 
 [provide]
 sqlite3 = sqlite3_dep

systemd/system/meson.build

@@ -1,4 +1,13 @@
 systemd_system_unit_dir = get_option('systemd_system_unit_dir')
+if systemd_system_unit_dir == ''
+  systemd = dependency('systemd', required: false)
+  if systemd.found()
+      systemd_system_unit_dir = systemd.get_variable(
+        pkgconfig: 'systemdsystemunitdir',
+        pkgconfig_define: ['rootprefix', get_option('prefix')],
+      )
+  endif
+endif
 if systemd_system_unit_dir == ''
   systemd_system_unit_dir = join_paths(get_option('prefix'), 'lib', 'systemd', 'system')
 endif

systemd/user/meson.build

@@ -1,4 +1,13 @@
 systemd_user_unit_dir = get_option('systemd_user_unit_dir')
+if systemd_user_unit_dir == ''
+  systemd = dependency('systemd', required: false)
+  if systemd.found()
+    systemd_user_unit_dir = systemd.get_variable(
+      pkgconfig: 'systemduserunitdir',
+      pkgconfig_define: ['prefix', get_option('prefix')],
+    )
+  endif
+endif
 if systemd_user_unit_dir == ''
   systemd_user_unit_dir = join_paths(get_option('prefix'), 'lib', 'systemd', 'user')
 endif

test/meson.build

@@ -288,7 +288,8 @@ if enable_database
       dependencies: [
         log_dep,
         tag_dep,
-        storage_glue_dep,
+        fs_dep,
+        storage_plugins_dep,
         gtest_dep,
       ],
     ),

test/test_translate_song.cxx

@@ -14,6 +14,7 @@
 #include "ls.hxx"
 #include "Log.hxx"
 #include "db/DatabaseSong.hxx"
+#include "storage/Registry.hxx"
 #include "storage/StorageInterface.hxx"
 #include "storage/plugins/LocalStorage.hxx"
 #include "Mapper.hxx"
@@ -36,6 +37,13 @@ uri_supported_scheme(const char *uri) noexcept
 	return strncmp(uri, "http://", 7) == 0;
 }
 
+const StoragePlugin *
+GetStoragePluginByUri(const char *) noexcept
+{
+	// dummy symbol
+	return nullptr;
+}
+
 static constexpr auto music_directory = PATH_LITERAL("/music");
 static Storage *storage;
 

win32/build.py

@@ -29,65 +29,12 @@ sys.path[0] = os.path.join(mpd_path, 'python')
 
 # output directories
 from build.dirs import lib_path, tarball_path, src_path
+from build.toolchain import MingwToolchain
 
 arch_path = os.path.join(lib_path, host_arch)
 build_path = os.path.join(arch_path, 'build')
 root_path = os.path.join(arch_path, 'root')
 
-class CrossGccToolchain:
-    def __init__(self, toolchain_path, arch,
-                 tarball_path, src_path, build_path, install_prefix):
-        self.arch = arch
-        self.actual_arch = arch
-        self.tarball_path = tarball_path
-        self.src_path = src_path
-        self.build_path = build_path
-        self.install_prefix = install_prefix
-
-        toolchain_bin = os.path.join(toolchain_path, 'bin')
-        self.cc = os.path.join(toolchain_bin, arch + '-gcc')
-        self.cxx = os.path.join(toolchain_bin, arch + '-g++')
-        self.ar = os.path.join(toolchain_bin, arch + '-ar')
-        self.ranlib = os.path.join(toolchain_bin, arch + '-ranlib')
-        self.nm = os.path.join(toolchain_bin, arch + '-nm')
-        self.strip = os.path.join(toolchain_bin, arch + '-strip')
-        self.windres = os.path.join(toolchain_bin, arch + '-windres')
-
-        common_flags = '-O2 -g'
-
-        if not x64:
-            # enable SSE support which is required for LAME
-            common_flags += ' -march=pentium3'
-
-        self.cflags = common_flags
-        self.cxxflags = common_flags
-        self.cppflags = '-isystem ' + os.path.join(install_prefix, 'include') + \
-                        ' -DWINVER=0x0600 -D_WIN32_WINNT=0x0600'
-        self.ldflags = '-L' + os.path.join(install_prefix, 'lib') + \
-                       ' -static-libstdc++ -static-libgcc'
-        self.libs = ''
-
-        # Explicitly disable _FORTIFY_SOURCE because it is broken with
-        # mingw.  This prevents some libraries such as libFLAC to
-        # enable it.
-        self.cppflags += ' -D_FORTIFY_SOURCE=0'
-
-        self.is_arm = arch.startswith('arm')
-        self.is_armv7 = self.is_arm and 'armv7' in self.cflags
-        self.is_aarch64 = arch == 'aarch64'
-        self.is_windows = 'mingw32' in arch
-
-        self.env = dict(os.environ)
-
-        # redirect pkg-config to use our root directory instead of the
-        # default one on the build host
-        import shutil
-        bin_dir = os.path.join(install_prefix, 'bin')
-        os.makedirs(bin_dir, exist_ok=True)
-        self.pkg_config = shutil.copy(os.path.join(mpd_path, 'build', 'pkg-config.sh'),
-                                      os.path.join(bin_dir, 'pkg-config'))
-        self.env['PKG_CONFIG'] = self.pkg_config
-
 # a list of third-party libraries to be used by MPD on Android
 from build.libs import *
 thirdparty_libs = [
@@ -110,8 +57,9 @@ thirdparty_libs = [
 ]
 
 # build the third-party libraries
-toolchain = CrossGccToolchain('/usr', host_arch,
+toolchain = MingwToolchain(mpd_path,
-                              tarball_path, src_path, build_path, root_path)
+                           '/usr', host_arch, x64,
+                           tarball_path, src_path, build_path, root_path)
 
 for x in thirdparty_libs:
     if not x.is_installed(toolchain):