release v0.21.21

raise default "max_connections" value to 100
Documentation says the limit is 5, but it was really 10 (at least since 2004). But since MPD wants to promote using many small clients idling around, and these clients consume only very few resources, it seems reasonable to raise this limit's default value.
2020-03-19 15:22:28 +01:00 · 2020-03-19 13:30:46 +01:00 · 2020-03-12 21:07:37 +01:00 · 2020-03-12 20:42:16 +01:00 · 2020-03-12 20:40:18 +01:00 · 2020-03-12 08:02:58 +01:00
33 changed files with 281 additions and 138 deletions
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,6 @@
 language: cpp

-matrix:
+jobs:
  include:
    # Ubuntu Bionic (18.04) with GCC 7
    - os: linux
@@ -17,9 +17,53 @@ matrix:
            - ninja-build
      before_install:
        - wget https://bootstrap.pypa.io/get-pip.py
-        - /usr/bin/python3.6 get-pip.py --user
+        - /usr/bin/python3.6 get-pip.py --user --no-cache-dir
      install:
-        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson
+        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson --no-cache-dir
+      env:
+        - MATRIX_EVAL="export PATH=\$HOME/.local/bin:\$PATH"
+
+    # Ubuntu Bionic (18.04) with GCC 7 on big-endian
+    - os: linux
+      arch: s390x
+      dist: bionic
+      addons:
+        apt:
+          sources:
+            - sourceline: 'ppa:deadsnakes/ppa' # for Python 3.7 (required by Meson)
+          packages:
+            - libgtest-dev
+            - libboost-dev
+            - python3.6
+            - python3-urllib3
+            - ninja-build
+      before_install:
+        - wget https://bootstrap.pypa.io/get-pip.py
+        - /usr/bin/python3.6 get-pip.py --user --no-cache-dir
+      install:
+        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson --no-cache-dir
+      env:
+        - MATRIX_EVAL="export PATH=\$HOME/.local/bin:\$PATH"
+
+    # Ubuntu Bionic (18.04) with GCC 7 on ARM64
+    - os: linux
+      arch: arm64
+      dist: bionic
+      addons:
+        apt:
+          sources:
+            - sourceline: 'ppa:deadsnakes/ppa' # for Python 3.7 (required by Meson)
+          packages:
+            - libgtest-dev
+            - libboost-dev
+            - python3.6
+            - python3-urllib3
+            - ninja-build
+      before_install:
+        - wget https://bootstrap.pypa.io/get-pip.py
+        - /usr/bin/python3.6 get-pip.py --user --no-cache-dir
+      install:
+        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson --no-cache-dir
      env:
        - MATRIX_EVAL="export PATH=\$HOME/.local/bin:\$PATH"

@@ -42,9 +86,9 @@ matrix:
            - ninja-build
      before_install:
        - wget https://bootstrap.pypa.io/get-pip.py
-        - /usr/bin/python3.6 get-pip.py --user
+        - /usr/bin/python3.6 get-pip.py --user --no-cache-dir
      install:
-        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson
+        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson --no-cache-dir
      env:
        # use gold as workaround for https://sourceware.org/bugzilla/show_bug.cgi?id=17068
        - MATRIX_EVAL="export CC='ccache gcc-6' CXX='ccache g++-6' LDFLAGS=-fuse-ld=gold PATH=\$HOME/.local/bin:\$PATH"
@@ -68,9 +112,9 @@ matrix:
            - ninja-build
      before_install:
        - wget https://bootstrap.pypa.io/get-pip.py
-        - /usr/bin/python3.6 get-pip.py --user
+        - /usr/bin/python3.6 get-pip.py --user --no-cache-dir
      install:
-        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson
+        - /usr/bin/python3.6 $HOME/.local/bin/pip install --user meson --no-cache-dir
      env:
        # use gold as workaround for https://sourceware.org/bugzilla/show_bug.cgi?id=17068
        - MATRIX_EVAL="export CC='ccache gcc-8' CXX='ccache g++-8' LDFLAGS=-fuse-ld=gold PATH=\$HOME/.local/bin:\$PATH"
@@ -82,6 +126,7 @@ matrix:
          packages:
            - ccache
            - meson
+          update: true
      env:
        - MATRIX_EVAL="export PATH=/usr/local/opt/ccache/libexec:$PATH HOMEBREW_NO_ANALYTICS=1"

@@ -104,7 +149,7 @@ install:
  # belonging to nss. You can unlink it" during gtest install
  - test "$TRAVIS_OS_NAME" != "osx" || brew unlink nss

-  - test "$TRAVIS_OS_NAME" != "osx" || brew install --HEAD https://gist.githubusercontent.com/Kronuz/96ac10fbd8472eb1e7566d740c4034f8/raw/gtest.rb
+  - test "$TRAVIS_OS_NAME" != "osx" || brew install https://gist.githubusercontent.com/Kronuz/96ac10fbd8472eb1e7566d740c4034f8/raw/gtest.rb

 before_script:
  - ccache -s
--- a/28
+++ b/28
@@ -1,3 +1,31 @@
+ver 0.21.21 (2020/03/19)
+* configuration
+  - fix bug in "metadata_to_use" setting
+* playlist
+  - asx, xspf: fix corrupt tags in the presence of XML entities
+* archive
+  - iso9660: skip empty file names to work around libcdio bug
+* decoder
+  - gme: ignore empty tags
+* output
+  - solaris: port to NetBSD
+* raise default "max_connections" value to 100
+
+ver 0.21.20 (2020/02/16)
+* decoder
+  - audiofile, ffmpeg, sndfile: handle MIME type "audio/wav"
+  - ffmpeg: fix playback of AIFF and TTA
+  - vorbis, opus: fix seeking in small files
+* fix backwards seeking on ARM (and other non-x86 CPUs)
+
+ver 0.21.19 (2020/01/17)
+* configuration
+  - allow overriding top-level settings in includes
+* output
+  - pulse: obey Pulse's maximum sample rate (fixes DSD128 playback)
+* fix build failure with clang 10
+* fix build failure with Android NDK r20
+
 ver 0.21.18 (2019/12/24)
 * protocol
  - work around Mac OS X bug in the ISO 8601 parser
--- a/android/AndroidManifest.xml
+++ b/android/AndroidManifest.xml
@@ -2,10 +2,10 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
          package="org.musicpd"
          android:installLocation="auto"
-          android:versionCode="41"
-          android:versionName="0.21.18">
+          android:versionCode="44"
+          android:versionName="0.21.21">

-  <uses-sdk android:minSdkVersion="21" android:targetSdkVersion="26"/>
+  <uses-sdk android:minSdkVersion="21" android:targetSdkVersion="28"/>

  <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
  <uses-permission android:name="android.permission.WAKE_LOCK"/>
--- a/android/build.py
+++ b/android/build.py
@@ -25,16 +25,15 @@ android_abis = {
        'arch': 'arm-linux-androideabi',
        'ndk_arch': 'arm',
        'toolchain_arch': 'arm-linux-androideabi',
-        'llvm_triple': 'armv7-none-linux-androideabi',
+        'llvm_triple': 'armv7-linux-androideabi',
        'cflags': '-march=armv7-a -mfpu=vfp -mfloat-abi=softfp',
    },

    'arm64-v8a': {
-        'android_api_level': '21',
        'arch': 'aarch64-linux-android',
        'ndk_arch': 'arm64',
        'toolchain_arch': 'aarch64-linux-android',
-        'llvm_triple': 'aarch64-none-linux-android',
+        'llvm_triple': 'aarch64-linux-android',
        'cflags': '',
    },

@@ -42,9 +41,17 @@ android_abis = {
        'arch': 'i686-linux-android',
        'ndk_arch': 'x86',
        'toolchain_arch': 'x86',
-        'llvm_triple': 'i686-none-linux-android',
+        'llvm_triple': 'i686-linux-android',
        'cflags': '-march=i686 -mtune=intel -mssse3 -mfpmath=sse -m32',
    },
+
+    'x86_64': {
+        'arch': 'x86_64-linux-android',
+        'ndk_arch': 'x86_64',
+        'toolchain_arch': 'x86_64',
+        'llvm_triple': 'x86_64-linux-android',
+        'cflags': '-m64',
+    },
 }

 # select the NDK target
@@ -76,24 +83,18 @@ class AndroidNdkToolchain:

        ndk_arch = abi_info['ndk_arch']
        android_api_level = '21'
-        ndk_platform = 'android-' + android_api_level

        # select the NDK compiler
        gcc_version = '4.9'

-        ndk_platform_path = os.path.join(ndk_path, 'platforms', ndk_platform)
-        sysroot = os.path.join(ndk_path, 'sysroot')
-        target_root = os.path.join(ndk_platform_path, 'arch-' + ndk_arch)
-
        install_prefix = os.path.join(arch_path, 'root')

        self.arch = arch
        self.install_prefix = install_prefix
-        self.sysroot = sysroot

        toolchain_path = os.path.join(ndk_path, 'toolchains', abi_info['toolchain_arch'] + '-' + gcc_version, 'prebuilt', build_arch)
        llvm_path = os.path.join(ndk_path, 'toolchains', 'llvm', 'prebuilt', build_arch)
-        llvm_triple = abi_info['llvm_triple']
+        llvm_triple = abi_info['llvm_triple'] + android_api_level

        common_flags = '-Os -g'
        common_flags += ' -fPIC'
@@ -107,6 +108,9 @@ class AndroidNdkToolchain:

        common_flags += ' -fvisibility=hidden -fdata-sections -ffunction-sections'

+        # required flags from https://android.googlesource.com/platform/ndk/+/ndk-release-r20/docs/BuildSystemMaintainers.md#additional-required-arguments
+        common_flags += ' -fno-addrsig'
+
        self.ar = os.path.join(toolchain_bin, arch + '-ar')
        self.ranlib = os.path.join(toolchain_bin, arch + '-ranlib')
        self.nm = os.path.join(toolchain_bin, arch + '-nm')
@@ -114,15 +118,11 @@ class AndroidNdkToolchain:

        self.cflags = common_flags
        self.cxxflags = common_flags
-        self.cppflags = '--sysroot=' + sysroot + \
-            ' -isystem ' + os.path.join(install_prefix, 'include') + \
-            ' -isystem ' + os.path.join(sysroot, 'usr', 'include', arch) + \
-            ' -D__ANDROID_API__=' + android_api_level
-        self.ldflags = '--sysroot=' + sysroot + \
-            ' -L' + os.path.join(install_prefix, 'lib') + \
-            ' -L' + os.path.join(target_root, 'usr', 'lib') + \
-            ' -B' + os.path.join(target_root, 'usr', 'lib') + \
+        self.cppflags = ' -isystem ' + os.path.join(install_prefix, 'include')
+        self.ldflags = ' -L' + os.path.join(install_prefix, 'lib') + \
+            ' -Wl,--exclude-libs=ALL' + \
            ' ' + common_flags
+        self.ldflags = common_flags
        self.libs = ''

        self.is_arm = ndk_arch == 'arm'
@@ -130,13 +130,10 @@ class AndroidNdkToolchain:
        self.is_aarch64 = ndk_arch == 'arm64'
        self.is_windows = False

-        libcxx_path = os.path.join(ndk_path, 'sources/cxx-stl/llvm-libc++')
-        libcxx_libs_path = os.path.join(libcxx_path, 'libs', android_abi)
-
        libstdcxx_flags = ''
-        libstdcxx_cxxflags = libstdcxx_flags + ' -isystem ' + os.path.join(libcxx_path, 'include') + ' -isystem ' + os.path.join(ndk_path, 'sources/android/support/include')
-        libstdcxx_ldflags = libstdcxx_flags + ' -L' + libcxx_libs_path
-        libstdcxx_libs = '-lc++_static -lc++abi'
+        libstdcxx_cxxflags = ''
+        libstdcxx_ldflags = ''
+        libstdcxx_libs = '-static-libstdc++'

        if self.is_armv7:
            # On 32 bit ARM, clang generates no ".eh_frame" section;
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -38,7 +38,7 @@ author = 'Max Kellermann'
 # built documents.
 #
 # The short X.Y version.
-version = '0.21.18'
+version = '0.21.21'
 # The full version, including alpha/beta/rc tags.
 release = version

--- a/doc/user.rst
+++ b/doc/user.rst
@@ -695,7 +695,7 @@ These settings are various limitations to prevent :program:`MPD` from using too
   * - **connection_timeout SECONDS**
     - If a client does not send any new data in this time period, the connection is closed. Clients waiting in "idle" mode are excluded from this. Default is 60.
   * - **max_connections NUMBER**
-     - This specifies the maximum number of clients that can be connected to :program:`MPD` at the same time. Default is 5.
+     - This specifies the maximum number of clients that can be connected to :program:`MPD` at the same time. Default is 100.
   * - **max_playlist_length NUMBER**
     - The maximum number of songs that can be in the playlist. Default is 16384.
   * - **max_command_list_size KBYTES**
--- a/meson.build
+++ b/meson.build
@@ -1,7 +1,7 @@
 project(
  'mpd',
  ['c', 'cpp'],
-  version: '0.21.18',
+  version: '0.21.21',
  meson_version: '>= 0.49.0',
  default_options: [
    'c_std=c99',
@@ -88,6 +88,10 @@ test_ldflags = [
 ]

 if get_option('buildtype') != 'debug'
+  test_cxxflags += [
+    '-ffunction-sections',
+    '-fdata-sections',
+  ]
  test_cflags += [
    '-ffunction-sections',
    '-fdata-sections',
--- a/python/build/libs.py
+++ b/python/build/libs.py
@@ -9,8 +9,8 @@ from build.ffmpeg import FfmpegProject
 from build.boost import BoostProject

 libmpdclient = MesonProject(
-    'https://www.musicpd.org/download/libmpdclient/2/libmpdclient-2.16.tar.xz',
-    'fa6bdab67c0e0490302b38f00c27b4959735c3ec8aef7a88327adb1407654464',
+    'https://www.musicpd.org/download/libmpdclient/2/libmpdclient-2.17.tar.xz',
+    'ee9b8f1c7e95b65c8f18a354daf7b16bfcd455fc52a0f3b5abe402316bce3559',
    'lib/libmpdclient.a',
 )

@@ -52,8 +52,8 @@ opus = AutotoolsProject(
 )

 flac = AutotoolsProject(
-    'http://downloads.xiph.org/releases/flac/flac-1.3.2.tar.xz',
-    '91cfc3ed61dc40f47f050a109b08610667d73477af6ef36dcad31c31a4a8d53f',
+    'http://downloads.xiph.org/releases/flac/flac-1.3.3.tar.xz',
+    '213e82bd716c9de6db2f98bcadbc4c24c7e2efe8c75939a1a84e28539c4e1748',
    'lib/libFLAC.a',
    [
        '--disable-shared', '--enable-static',
@@ -112,8 +112,8 @@ liblame = AutotoolsProject(
 )

 ffmpeg = FfmpegProject(
-    'http://ffmpeg.org/releases/ffmpeg-4.2.1.tar.xz',
-    'cec7c87e9b60d174509e263ac4011b522385fd0775292e1670ecc1180c9bb6d4',
+    'http://ffmpeg.org/releases/ffmpeg-4.2.2.tar.xz',
+    'cb754255ab0ee2ea5f66f8850e1bd6ad5cac1cd855d0a2f4990fb8c668b0d29c',
    'lib/libavcodec.a',
    [
        '--disable-shared', '--enable-static',
@@ -341,8 +341,8 @@ ffmpeg = FfmpegProject(
 )

 curl = AutotoolsProject(
-    'http://curl.haxx.se/download/curl-7.66.0.tar.xz',
-    'dbb48088193016d079b97c5c3efde8efa56ada2ebf336e8a97d04eb8e2ed98c1',
+    'http://curl.haxx.se/download/curl-7.68.0.tar.xz',
+    'b724240722276a27f6e770b952121a3afd097129d8c9fe18e6272dc34192035a',
    'lib/libcurl.a',
    [
        '--disable-shared', '--enable-static',
@@ -358,6 +358,11 @@ curl = AutotoolsProject(
        '--disable-manual',
        '--disable-threaded-resolver', '--disable-verbose', '--disable-sspi',
        '--disable-crypto-auth', '--disable-ntlm-wb', '--disable-tls-srp', '--disable-cookies',
+        '--disable-doh',
+        '--disable-mime',
+        '--disable-netrc',
+        '--disable-progress-meter',
+        '--disable-alt-svc',
        '--without-ssl', '--without-gnutls', '--without-nss', '--without-libssh2',
    ],

@@ -365,8 +370,8 @@ curl = AutotoolsProject(
 )

 libexpat = AutotoolsProject(
-    'https://github.com/libexpat/libexpat/releases/download/R_2_2_7/expat-2.2.7.tar.bz2',
-    'cbc9102f4a31a8dafd42d642e9a3aa31e79a0aedaa1f6efd2795ebc83174ec18',
+    'https://github.com/libexpat/libexpat/releases/download/R_2_2_9/expat-2.2.9.tar.bz2',
+    'f1063084dc4302a427dabcca499c8312b3a32a29b7d2506653ecc8f950a9a237',
    'lib/libexpat.a',
    [
        '--disable-shared', '--enable-static',
@@ -392,7 +397,7 @@ libnfs = AutotoolsProject(
 )

 boost = BoostProject(
-    'https://dl.bintray.com/boostorg/release/1.71.0/source/boost_1_71_0.tar.bz2',
-    'd73a8da01e8bf8c7eda40b4c84915071a8c8a0df4a6734537ddde4a8580524ee',
+    'https://dl.bintray.com/boostorg/release/1.72.0/source/boost_1_72_0.tar.bz2',
+    '59c9b274bc451cf91a9ba1dd2c7fdcaf5d60b1b3aa83f2c9fa143417cc660722',
    'include/boost/version.hpp',
 )
--- a/src/Main.cxx
+++ b/src/Main.cxx
@@ -460,7 +460,7 @@ MainOrThrow(int argc, char *argv[])
 #endif

 	const unsigned max_clients =
-		raw_config.GetPositive(ConfigOption::MAX_CONN, 10);
+		raw_config.GetPositive(ConfigOption::MAX_CONN, 100);
 	instance->client_list = new ClientList(max_clients);

 	initialize_decoder_and_player(raw_config, config.replay_gain);
--- a/src/archive/plugins/Iso9660ArchivePlugin.cxx
+++ b/src/archive/plugins/Iso9660ArchivePlugin.cxx
@@ -28,6 +28,7 @@
 #include "input/InputStream.hxx"
 #include "fs/Path.hxx"
 #include "util/RuntimeError.hxx"
+#include "util/StringCompare.hxx"

 #include <cdio/iso9660.h>

@@ -93,7 +94,10 @@ Iso9660ArchiveFile::Visit(char *path, size_t length, size_t capacity,
 		auto *statbuf = (iso9660_stat_t *)
 			_cdio_list_node_data(entnode);
 		const char *filename = statbuf->filename;
-		if (strcmp(filename, ".") == 0 || strcmp(filename, "..") == 0)
+		if (StringIsEmpty(filename) ||
+		    PathTraitsUTF8::IsSpecialFilename(filename))
+			/* skip empty names (libcdio bug?) */
+			/* skip special names like "." and ".." */
 			continue;

 		size_t filename_length = strlen(filename);
--- a/src/config/File.cxx
+++ b/src/config/File.cxx
@@ -153,11 +153,9 @@ ReadConfigParam(ConfigData &config_data, BufferedReader &reader,
 			      name, reader.GetLineNumber());

 	if (!option.repeatable)
-		if (const auto *param = config_data.GetParam(o))
-			throw FormatRuntimeError("config parameter \"%s\" is first defined "
-						 "on line %d and redefined on line %u\n",
-						 name, param->line,
-						 reader.GetLineNumber());
+		/* if the option is not repeatable, override the old
+		   value by removing it first */
+		config_data.GetParamList(o).clear();

 	/* now parse the block or the value */

--- a/src/db/update/InotifyUpdate.cxx
+++ b/src/db/update/InotifyUpdate.cxx
@@ -24,6 +24,7 @@
 #include "storage/StorageInterface.hxx"
 #include "fs/AllocatedPath.hxx"
 #include "fs/FileInfo.hxx"
+#include "fs/Traits.hxx"
 #include "Log.hxx"

 #include <string>
@@ -146,8 +147,7 @@ WatchDirectory::GetUriFS() const noexcept
 /* we don't look at "." / ".." nor files with newlines in their name */
 static bool skip_path(const char *path)
 {
-	return (path[0] == '.' && path[1] == 0) ||
-		(path[0] == '.' && path[1] == '.' && path[2] == 0) ||
+	return PathTraitsFS::IsSpecialFilename(path) ||
 		strchr(path, '\n') != nullptr;
 }

--- a/src/db/update/Walk.cxx
+++ b/src/db/update/Walk.cxx
@@ -237,7 +237,7 @@ try {
 	LogError(std::current_exception());
 }

-/* we don't look at "." / ".." nor files with newlines in their name */
+/* we don't look at files with newlines in their name */
 gcc_pure
 static bool
 skip_path(const char *name_utf8) noexcept
--- a/src/decoder/plugins/AudiofileDecoderPlugin.cxx
+++ b/src/decoder/plugins/AudiofileDecoderPlugin.cxx
@@ -269,6 +269,8 @@ static const char *const audiofile_suffixes[] = {
 };

 static const char *const audiofile_mime_types[] = {
+	"audio/wav",
+	"audio/aiff",
 	"audio/x-wav",
 	"audio/x-aiff",
 	nullptr
--- a/src/decoder/plugins/FfmpegDecoderPlugin.cxx
+++ b/src/decoder/plugins/FfmpegDecoderPlugin.cxx
@@ -762,7 +762,7 @@ static const char *const ffmpeg_mime_types[] = {
 	"audio/aac",
 	"audio/aacp",
 	"audio/ac3",
-	"audio/aiff"
+	"audio/aiff",
 	"audio/amr",
 	"audio/basic",
 	"audio/flac",
@@ -775,12 +775,13 @@ static const char *const ffmpeg_mime_types[] = {
 	"audio/qcelp",
 	"audio/vorbis",
 	"audio/vorbis+ogg",
+	"audio/wav",
 	"audio/x-8svx",
 	"audio/x-16sv",
 	"audio/x-aac",
 	"audio/x-ac3",
 	"audio/x-adx",
-	"audio/x-aiff"
+	"audio/x-aiff",
 	"audio/x-alaw",
 	"audio/x-au",
 	"audio/x-dca",
@@ -800,7 +801,7 @@ static const char *const ffmpeg_mime_types[] = {
 	"audio/x-pn-realaudio",
 	"audio/x-pn-multirate-realaudio",
 	"audio/x-speex",
-	"audio/x-tta"
+	"audio/x-tta",
 	"audio/x-voc",
 	"audio/x-wav",
 	"audio/x-wma",
--- a/src/decoder/plugins/GmeDecoderPlugin.cxx
+++ b/src/decoder/plugins/GmeDecoderPlugin.cxx
@@ -28,6 +28,7 @@
 #include "fs/AllocatedPath.hxx"
 #include "fs/FileSystem.hxx"
 #include "util/ScopeExit.hxx"
+#include "util/StringCompare.hxx"
 #include "util/StringFormat.hxx"
 #include "util/UriUtil.hxx"
 #include "util/Domain.hxx"
@@ -222,7 +223,7 @@ ScanGmeInfo(const gme_info_t &info, unsigned song_num, int track_count,
 	if (track_count > 1)
 		handler.OnTag(TAG_TRACK, StringFormat<16>("%u", song_num + 1));

-	if (info.song != nullptr) {
+	if (!StringIsEmpty(info.song)) {
 		if (track_count > 1) {
 			/* start numbering subtunes from 1 */
 			const auto tag_title =
@@ -234,16 +235,16 @@ ScanGmeInfo(const gme_info_t &info, unsigned song_num, int track_count,
 			handler.OnTag(TAG_TITLE, info.song);
 	}

-	if (info.author != nullptr)
+	if (!StringIsEmpty(info.author))
 		handler.OnTag(TAG_ARTIST, info.author);

-	if (info.game != nullptr)
+	if (!StringIsEmpty(info.game))
 		handler.OnTag(TAG_ALBUM, info.game);

-	if (info.comment != nullptr)
+	if (!StringIsEmpty(info.comment))
 		handler.OnTag(TAG_COMMENT, info.comment);

-	if (info.copyright != nullptr)
+	if (!StringIsEmpty(info.copyright))
 		handler.OnTag(TAG_DATE, info.copyright);
 }

--- a/src/decoder/plugins/MadDecoderPlugin.cxx
+++ b/src/decoder/plugins/MadDecoderPlugin.cxx
@@ -793,7 +793,7 @@ MadDecoder::DecodeFirstFrame(Tag *tag) noexcept

 	if (max_frames > 8 * 1024 * 1024) {
 		FormatWarning(mad_domain,
-			      "mp3 file header indicates too many frames: %lu",
+			      "mp3 file header indicates too many frames: %zu",
 			      max_frames);
 		return false;
 	}
--- a/src/decoder/plugins/OggDecoder.cxx
+++ b/src/decoder/plugins/OggDecoder.cxx
@@ -47,8 +47,12 @@ OggDecoder::LoadEndPacket(ogg_packet &packet) const
 		DecoderReader reader(client, input_stream);
 		OggSyncState sync2(reader);
 		OggStreamState stream2(GetSerialNo());
+
+		/* passing synced=false because we're inside an
+		   OggVisitor callback, and our InputStream may be in
+		   the middle of an Ogg packet */
 		result = OggSeekFindEOS(sync2, stream2, packet,
-					input_stream);
+					input_stream, false);
 	}

 	/* restore the previous file position */
--- a/src/decoder/plugins/SndfileDecoderPlugin.cxx
+++ b/src/decoder/plugins/SndfileDecoderPlugin.cxx
@@ -322,6 +322,8 @@ static const char *const sndfile_suffixes[] = {
 };

 static const char *const sndfile_mime_types[] = {
+	"audio/wav",
+	"audio/aiff",
 	"audio/x-wav",
 	"audio/x-aiff",

--- a/src/fs/Traits.hxx
+++ b/src/fs/Traits.hxx
@@ -108,6 +108,12 @@ struct PathTraitsFS {
 		return IsSeparator(*p);
 	}

+	gcc_pure gcc_nonnull_all
+	static bool IsSpecialFilename(const_pointer_type name) noexcept {
+		return (name[0] == '.' && name[1] == 0) ||
+			(name[0] == '.' && name[1] == '.' && name[2] == 0);
+	}
+
 	gcc_pure gcc_nonnull_all
 	static size_t GetLength(const_pointer_type p) noexcept {
 		return StringLength(p);
@@ -216,6 +222,12 @@ struct PathTraitsUTF8 {
 		return IsSeparator(*p);
 	}

+	gcc_pure gcc_nonnull_all
+	static bool IsSpecialFilename(const_pointer_type name) noexcept {
+		return (name[0] == '.' && name[1] == 0) ||
+			(name[0] == '.' && name[1] == '.' && name[2] == 0);
+	}
+
 	gcc_pure gcc_nonnull_all
 	static size_t GetLength(const_pointer_type p) noexcept {
 		return StringLength(p);
--- a/src/lib/xiph/OggFind.cxx
+++ b/src/lib/xiph/OggFind.cxx
@@ -57,13 +57,14 @@ OggSeekPageAtOffset(OggSyncState &oy, ogg_stream_state &os, InputStream &is,

 bool
 OggSeekFindEOS(OggSyncState &oy, ogg_stream_state &os, ogg_packet &packet,
-	       InputStream &is)
+	       InputStream &is, bool synced)
 {
 	if (!is.KnownSize())
 		return false;

 	if (is.GetRest() < 65536)
-		return OggFindEOS(oy, os, packet);
+		return (synced || oy.ExpectPageSeekIn(os)) &&
+			OggFindEOS(oy, os, packet);

 	if (!is.CheapSeeking())
 		return false;
--- a/src/lib/xiph/OggFind.hxx
+++ b/src/lib/xiph/OggFind.hxx
@@ -47,10 +47,13 @@ OggSeekPageAtOffset(OggSyncState &oy, ogg_stream_state &os, InputStream &is,
 * Try to find the end-of-stream (EOS) packet.  Seek to the end of the
 * file if necessary.
 *
+ * @param synced is the #OggSyncState currently synced?  If not, then
+ * we need to use ogg_sync_pageseek() instead of ogg_sync_pageout(),
+ * which is more expensive
 * @return true if the EOS packet was found
 */
 bool
 OggSeekFindEOS(OggSyncState &oy, ogg_stream_state &os, ogg_packet &packet,
-	       InputStream &is);
+	       InputStream &is, bool synced=true);

 #endif
--- a/src/output/plugins/PulseOutputPlugin.cxx
+++ b/src/output/plugins/PulseOutputPlugin.cxx
@@ -650,7 +650,7 @@ PulseOutput::Open(AudioFormat &audio_format)
 		break;
 	}

-	ss.rate = audio_format.sample_rate;
+	ss.rate = std::min(audio_format.sample_rate, PA_RATE_MAX);
 	ss.channels = audio_format.channels;

 	/* create a stream .. */
--- a/src/output/plugins/SolarisOutputPlugin.cxx
+++ b/src/output/plugins/SolarisOutputPlugin.cxx
@@ -22,22 +22,23 @@
 #include "system/FileDescriptor.hxx"
 #include "system/Error.hxx"

+#include <sys/ioctl.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <unistd.h>
 #include <fcntl.h>
 #include <errno.h>

-#ifdef __sun
+#if defined(__sun)
 #include <sys/audio.h>
 #include <sys/stropts.h>
+#elif defined(__NetBSD__)
+#include <sys/audioio.h>
 #else

 /* some fake declarations that allow build this plugin on systems
   other than Solaris, just to see if it compiles */

-#include <sys/ioctl.h>
-
 #ifndef I_FLUSH
 #define I_FLUSH 0
 #endif
@@ -147,7 +148,11 @@ SolarisOutput::Play(const void *chunk, size_t size)
 void
 SolarisOutput::Cancel() noexcept
 {
+#if defined(AUDIO_FLUSH)
+	ioctl(fd.Get(), AUDIO_FLUSH);
+#elif defined(I_FLUSH)
 	ioctl(fd.Get(), I_FLUSH);
+#endif
 }

 const struct AudioOutputPlugin solaris_output_plugin = {
--- a/src/playlist/plugins/AsxPlaylistPlugin.cxx
+++ b/src/playlist/plugins/AsxPlaylistPlugin.cxx
@@ -21,6 +21,7 @@
 #include "../PlaylistPlugin.hxx"
 #include "../MemorySongEnumerator.hxx"
 #include "tag/Builder.hxx"
+#include "tag/Table.hxx"
 #include "util/ASCII.hxx"
 #include "util/StringView.hxx"
 #include "lib/expat/ExpatParser.hxx"
@@ -41,6 +42,7 @@ struct AsxParser {
 	 */
 	enum {
 		ROOT, ENTRY,
+		TAG,
 	} state;

 	/**
@@ -57,23 +59,33 @@ struct AsxParser {

 	TagBuilder tag_builder;

+	std::string value;
+
 	AsxParser()
 		:state(ROOT) {}

 };

+static constexpr struct tag_table asx_tag_elements[] = {
+	/* is that correct?  or should it be COMPOSER or PERFORMER? */
+	{ "author", TAG_ARTIST },
+
+	{ "title", TAG_TITLE },
+	{ nullptr, TAG_NUM_OF_ITEM_TYPES }
+};
+
 static void XMLCALL
 asx_start_element(void *user_data, const XML_Char *element_name,
 		  const XML_Char **atts)
 {
 	AsxParser *parser = (AsxParser *)user_data;
+	parser->value.clear();

 	switch (parser->state) {
 	case AsxParser::ROOT:
 		if (StringEqualsCaseASCII(element_name, "entry")) {
 			parser->state = AsxParser::ENTRY;
 			parser->location.clear();
-			parser->tag_type = TAG_NUM_OF_ITEM_TYPES;
 		}

 		break;
@@ -84,14 +96,17 @@ asx_start_element(void *user_data, const XML_Char *element_name,
 				ExpatParser::GetAttributeCase(atts, "href");
 			if (href != nullptr)
 				parser->location = href;
-		} else if (StringEqualsCaseASCII(element_name, "author"))
-			/* is that correct?  or should it be COMPOSER
-			   or PERFORMER? */
-			parser->tag_type = TAG_ARTIST;
-		else if (StringEqualsCaseASCII(element_name, "title"))
-			parser->tag_type = TAG_TITLE;
+		} else {
+			parser->tag_type = tag_table_lookup_i(asx_tag_elements,
+							      element_name);
+			if (parser->tag_type != TAG_NUM_OF_ITEM_TYPES)
+				parser->state = AsxParser::TAG;
+		}

 		break;
+
+	case AsxParser::TAG:
+		break;
 	}
 }

@@ -111,11 +126,20 @@ asx_end_element(void *user_data, const XML_Char *element_name)
 							    parser->tag_builder.Commit());

 			parser->state = AsxParser::ROOT;
-		} else
-			parser->tag_type = TAG_NUM_OF_ITEM_TYPES;
+		}

 		break;
+
+	case AsxParser::TAG:
+		if (!parser->value.empty())
+			parser->tag_builder.AddItem(parser->tag_type,
+						    StringView(parser->value.data(),
+							       parser->value.length()));
+		parser->state = AsxParser::ENTRY;
+		break;
 	}
+
+	parser->value.clear();
 }

 static void XMLCALL
@@ -125,13 +149,11 @@ asx_char_data(void *user_data, const XML_Char *s, int len)

 	switch (parser->state) {
 	case AsxParser::ROOT:
+	case AsxParser::ENTRY:
 		break;

-	case AsxParser::ENTRY:
-		if (parser->tag_type != TAG_NUM_OF_ITEM_TYPES)
-			parser->tag_builder.AddItem(parser->tag_type,
-						    StringView(s, len));
-
+	case AsxParser::TAG:
+		parser->value.append(s, len);
 		break;
 	}
 }
--- a/src/playlist/plugins/XspfPlaylistPlugin.cxx
+++ b/src/playlist/plugins/XspfPlaylistPlugin.cxx
@@ -23,6 +23,7 @@
 #include "song/DetachedSong.hxx"
 #include "input/InputStream.hxx"
 #include "tag/Builder.hxx"
+#include "tag/Table.hxx"
 #include "util/StringView.hxx"
 #include "lib/expat/ExpatParser.hxx"
 #include "Log.hxx"
@@ -44,8 +45,8 @@ struct XspfParser {
 	 */
 	enum {
 		ROOT, PLAYLIST, TRACKLIST, TRACK,
-		LOCATION,
-	} state;
+		TAG, LOCATION,
+	} state = ROOT;

 	/**
 	 * The current tag within the "track" element.  This is only
@@ -61,8 +62,20 @@ struct XspfParser {

 	TagBuilder tag_builder;

-	XspfParser()
-		:state(ROOT) {}
+	std::string value;
+};
+
+static constexpr struct tag_table xspf_tag_elements[] = {
+	{ "title", TAG_TITLE },
+
+	/* TAG_COMPOSER would be more correct according to the XSPF
+	   spec */
+	{ "creator", TAG_ARTIST },
+
+	{ "annotation", TAG_COMMENT },
+	{ "album", TAG_ALBUM },
+	{ "trackNum", TAG_TRACK },
+	{ nullptr, TAG_NUM_OF_ITEM_TYPES }
 };

 static void XMLCALL
@@ -70,6 +83,7 @@ xspf_start_element(void *user_data, const XML_Char *element_name,
 		   gcc_unused const XML_Char **atts)
 {
 	XspfParser *parser = (XspfParser *)user_data;
+	parser->value.clear();

 	switch (parser->state) {
 	case XspfParser::ROOT:
@@ -88,7 +102,6 @@ xspf_start_element(void *user_data, const XML_Char *element_name,
 		if (strcmp(element_name, "track") == 0) {
 			parser->state = XspfParser::TRACK;
 			parser->location.clear();
-			parser->tag_type = TAG_NUM_OF_ITEM_TYPES;
 		}

 		break;
@@ -96,21 +109,16 @@ xspf_start_element(void *user_data, const XML_Char *element_name,
 	case XspfParser::TRACK:
 		if (strcmp(element_name, "location") == 0)
 			parser->state = XspfParser::LOCATION;
-		else if (strcmp(element_name, "title") == 0)
-			parser->tag_type = TAG_TITLE;
-		else if (strcmp(element_name, "creator") == 0)
-			/* TAG_COMPOSER would be more correct
-			   according to the XSPF spec */
-			parser->tag_type = TAG_ARTIST;
-		else if (strcmp(element_name, "annotation") == 0)
-			parser->tag_type = TAG_COMMENT;
-		else if (strcmp(element_name, "album") == 0)
-			parser->tag_type = TAG_ALBUM;
-		else if (strcmp(element_name, "trackNum") == 0)
-			parser->tag_type = TAG_TRACK;
+		else if (!parser->location.empty()) {
+			parser->tag_type = tag_table_lookup(xspf_tag_elements,
+							    element_name);
+			if (parser->tag_type != TAG_NUM_OF_ITEM_TYPES)
+				parser->state = XspfParser::TAG;
+		}

 		break;

+	case XspfParser::TAG:
 	case XspfParser::LOCATION:
 		break;
 	}
@@ -144,15 +152,26 @@ xspf_end_element(void *user_data, const XML_Char *element_name)
 							    parser->tag_builder.Commit());

 			parser->state = XspfParser::TRACKLIST;
-		} else
-			parser->tag_type = TAG_NUM_OF_ITEM_TYPES;
+		}

 		break;

+	case XspfParser::TAG:
+		if (!parser->value.empty())
+			parser->tag_builder.AddItem(parser->tag_type,
+						    StringView(parser->value.data(),
+							       parser->value.length()));
+
+		parser->state = XspfParser::TRACK;
+		break;
+
 	case XspfParser::LOCATION:
+		parser->location = std::move(parser->value);
 		parser->state = XspfParser::TRACK;
 		break;
 	}
+
+	parser->value.clear();
 }

 static void XMLCALL
@@ -164,19 +183,12 @@ xspf_char_data(void *user_data, const XML_Char *s, int len)
 	case XspfParser::ROOT:
 	case XspfParser::PLAYLIST:
 	case XspfParser::TRACKLIST:
-		break;
-
 	case XspfParser::TRACK:
-		if (!parser->location.empty() &&
-		    parser->tag_type != TAG_NUM_OF_ITEM_TYPES)
-			parser->tag_builder.AddItem(parser->tag_type,
-						    StringView(s, len));
-
 		break;

+	case XspfParser::TAG:
 	case XspfParser::LOCATION:
-		parser->location.assign(s, len);
-
+		parser->value.append(s, len);
 		break;
 	}
 }
--- a/src/protocol/ArgParser.cxx
+++ b/src/protocol/ArgParser.cxx
@@ -175,5 +175,5 @@ SignedSongTime
 ParseCommandArgSignedSongTime(const char *s)
 {
 	auto value = ParseCommandArgFloat(s);
-	return SongTime::FromS(value);
+	return SignedSongTime::FromS(value);
 }
--- a/src/storage/plugins/LocalStorage.cxx
+++ b/src/storage/plugins/LocalStorage.cxx
@@ -144,21 +144,12 @@ LocalStorage::OpenDirectory(const char *uri_utf8)
 	return std::make_unique<LocalDirectoryReader>(MapFSOrThrow(uri_utf8));
 }

-gcc_pure
-static bool
-SkipNameFS(PathTraitsFS::const_pointer_type name_fs) noexcept
-{
-	return name_fs[0] == '.' &&
-		(name_fs[1] == 0 ||
-		 (name_fs[1] == '.' && name_fs[2] == 0));
-}
-
 const char *
 LocalDirectoryReader::Read() noexcept
 {
 	while (reader.ReadEntry()) {
 		const Path name_fs = reader.GetEntry();
-		if (SkipNameFS(name_fs.c_str()))
+		if (PathTraitsFS::IsSpecialFilename(name_fs.c_str()))
 			continue;

 		try {
--- a/src/tag/Mask.hxx
+++ b/src/tag/Mask.hxx
@@ -89,7 +89,7 @@ public:
 	}

 	void Unset(TagType tag) {
-		*this |= ~TagMask(tag);
+		*this &= ~TagMask(tag);
 	}
 };

--- a/src/time/ISO8601.cxx
+++ b/src/time/ISO8601.cxx
@@ -37,6 +37,7 @@
 #include <stdexcept>

 #include <assert.h>
+#include <stdlib.h>

 StringBuffer<64>
 FormatISO8601(const struct tm &tm) noexcept
--- a/src/util/Compiler.h
+++ b/src/util/Compiler.h
@@ -145,7 +145,7 @@

 #if GCC_CHECK_VERSION(7,0)
 #define gcc_fallthrough __attribute__((fallthrough))
-#elif CLANG_CHECK_VERSION(10,0)
+#elif CLANG_CHECK_VERSION(10,0) && defined(__cplusplus)
 #define gcc_fallthrough [[fallthrough]]
 #else
 #define gcc_fallthrough
--- a/test/DumpDecoderClient.cxx
+++ b/test/DumpDecoderClient.cxx
@@ -28,15 +28,15 @@

 void
 DumpDecoderClient::Ready(const AudioFormat audio_format,
-			 gcc_unused bool seekable,
+			 bool seekable,
 			 SignedSongTime duration)
 {
 	assert(!initialized);
 	assert(audio_format.IsValid());

-	fprintf(stderr, "audio_format=%s duration=%f\n",
+	fprintf(stderr, "audio_format=%s duration=%f seekable=%d\n",
 		ToString(audio_format).c_str(),
-		duration.ToDoubleS());
+		duration.ToDoubleS(), seekable);

 	initialized = true;
 }
--- a/test/meson.build
+++ b/test/meson.build
@@ -7,9 +7,14 @@ if compiler.get_id() == 'gcc'
    '-Wno-suggest-attribute=format',
    '-Wno-suggest-attribute=noreturn',
    '-Wno-missing-declarations',
+  ]
+endif

-    # needed on Jessie for gtest's IsNullLiteralHelper
-    '-Wno-conversion-null',
+if compiler.get_id() == 'clang' and compiler.version().version_compare('>=9')
+  gtest_compile_args += [
+    # work around clang warning caused by GTest's wrong "-lpthread"
+    # compiler flag
+    '-Wno-unused-command-line-argument',
  ]
 endif
Author	SHA1	Message	Date
Max Kellermann	c560ec8ea6	release v0.21.21	2020-03-19 15:22:28 +01:00
Max Kellermann	56c234b410	raise default "max_connections" value to 100 Documentation says the limit is 5, but it was really 10 (at least since 2004). But since MPD wants to promote using many small clients idling around, and these clients consume only very few resources, it seems reasonable to raise this limit's default value.	2020-03-19 13:30:46 +01:00
Max Kellermann	82743dfd02	playlist/asx: concatenate multiple CharacterData fragments Similar to `c45f113856`	2020-03-12 21:07:37 +01:00
Max Kellermann	33694642bd	playlist/asx: add State::TAG	2020-03-12 20:42:16 +01:00
Max Kellermann	c71242d743	playlist/asx: use tag_table to convert element name to TagType	2020-03-12 20:40:18 +01:00
Max Kellermann	c45f113856	playlist/xspf: concatenate multiple CharacterData fragments Closes https://github.com/MusicPlayerDaemon/MPD/issues/781	2020-03-12 08:02:58 +01:00
Max Kellermann	e0a8fd398c	playlist/xspf: add State::TAG	2020-03-12 08:00:54 +01:00
Max Kellermann	3e97058151	playlist/xspf: move location.empty() check to _start_element()	2020-03-11 20:54:53 +01:00
Max Kellermann	51b1dd8672	playlist/xspf: use tag_table to convert element name to TagType	2020-03-11 20:51:47 +01:00
Max Kellermann	98a7d8da6c	playlist/xspf: use C++11 initializer	2020-03-11 20:51:10 +01:00
Max Kellermann	acb29f792f	tag/Mask: fix yet another typo, this time in Unset() Similar to commits `e8f2f98048` and `ff1ff1e54a` Closes https://github.com/MusicPlayerDaemon/MPD/issues/783	2020-03-11 20:34:02 +01:00
Max Kellermann	cd364023ae	.travis.yml: rename "matrix" to "jobs" Travis has changed the canonical name for this a while ago. (Now really. The last commit for this was empty.)	2020-03-07 09:31:46 +01:00
Max Kellermann	8d34a1cfc6	archive/iso9660: skip empty filenames Aparently, libcdio sometimes returns empty filenames, causing MPD crashes. This shouldn't really happen, and I consider this a libcdio bug - but if it happens, people blame MPD, so let's add a check. Closes https://github.com/MusicPlayerDaemon/MPD/issues/776	2020-03-07 09:30:56 +01:00
Max Kellermann	73a1f078a6	archive/iso9660: use IsSpecialFilename()	2020-03-07 09:30:56 +01:00
Max Kellermann	b7ce452308	fs/Traits: add IsSpecialFilename() Merge some duplicate code in a central library.	2020-03-07 09:30:56 +01:00
Max Kellermann	5faf76051d	.travis.yml: force updating homebrew on OSX Workaround for Travis failures as described in https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/18	2020-03-07 09:30:56 +01:00
Max Kellermann	5fe70a3417	.travis.yml: rename "matrix" to "jobs" Travis has changed the canonical name for this a while ago.	2020-03-07 09:30:56 +01:00
Thomas Klausner	7a68b1e71f	Adapt SolarisOutputPlugin.cxx to be usable on NetBSD.	2020-02-29 10:05:29 +01:00
Thomas Klausner	d5468dfe89	Add missing header. Fixes ../src/time/ISO8601.cxx:67:24: error: use of undeclared identifier 'strtoul' unsigned long value = strtoul(s, &endptr, 10); ^ ../src/time/ISO8601.cxx:77:14: error: use of undeclared identifier 'strtoul' minutes = strtoul(s, &endptr, 10); ^ on NetBSD with clang 9.0.0.	2020-02-29 10:04:54 +01:00
John Regan	976372ff63	gme: check for empty metadata strings instead of nullptr Using libgme 0.6.2 on macOS, it appears that gme_info_t strings can be empty, which creates weird track titles: (001/050) This adds an additional check for an empty string.	2020-02-25 20:12:08 +01:00
Max Kellermann	9abb686eeb	increment version number to 0.21.21	2020-02-16 20:48:46 +01:00
Max Kellermann	f24bcc7f42	release v0.21.20	2020-02-16 20:43:35 +01:00
Max Kellermann	89800324cb	.travis.yml: use GTest 1.8.0 instead of HEAD Fixes strange C++11 compatibility problems during GTest installation: /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1249:1: error: unknown type name 'constexpr' constexpr bool TypedTestCaseIsDeprecated() { return true; } /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1249:11: error: expected unqualified-id constexpr bool TypedTestCaseIsDeprecated() { return true; } /tmp/gtest-20200216-20679-mu1044/googletest/include/gtest/internal/gtest-internal.h:1254:1: error: unknown type name 'constexpr' constexpr bool RegisterTypedTestCase_P_IsDeprecated() { return true; }	2020-02-16 20:33:15 +01:00
Rosen Penev	050e30418c	Fix travis pip is bugged on arm64 and s390x. Add --no-cache-dir to fix. For consistency, it doesn't hurt to add everywhere.	2020-02-16 19:29:30 +01:00
Max Kellermann	5397d18ed9	protocol/ArgParser: cast seek offset to SignedSongTime "The issue is that ParseCommandArgSignedSongTime parses with SongTime::FromS, not SignedSongTime::FromS, before casting back to a SignedSongTime for the return. With x86 overflow rules this doesn't matter, but on ARM the first cast turns negative values to zero." Closes https://github.com/MusicPlayerDaemon/MPD/issues/757	2020-02-10 09:18:37 +01:00
Max Kellermann	42eb69f46f	test/meson.build: restore -Wno-missing-declarations for GTest This is still needed for GTest 1.8.0 (Travis / Ubuntu Bionic).	2020-02-04 22:06:51 +01:00
Max Kellermann	f1ad21d2bf	test/meson.build: add -Wno-unused-command-line-argument for clang 9+	2020-02-04 16:35:44 +01:00
Max Kellermann	535a099a27	test/meson.build: drop obsolete gtest warning suppressions	2020-02-04 16:32:13 +01:00
Max Kellermann	50003f6ad2	decoder/ffmpeg: add two more missing commas	2020-02-04 16:30:05 +01:00
Rosen Penev	0914644d2b	add missing comma Found with bugprone-suspicious-missing-comma Signed-off-by: Rosen Penev <rosenp@gmail.com>	2020-02-04 16:29:23 +01:00
Max Kellermann	5ad6e7fec5	decoder/{audio,snd}file: handle MIME type "audio/wav"	2020-02-01 11:26:57 +01:00
Rosen Penev	0bb943ba3e	FfmpegDecoderPlugin: add WAV support	2020-02-01 11:24:51 +01:00
Rosen Penev	80a0cf694f	MadDecoderPlugin: fix bad printf format max_frames is size_t, not unsigned long. Fixes GCC warning.	2020-01-31 21:21:39 +01:00
Max Kellermann	0c9e25b3c4	NEWS: add missing line	2020-01-25 20:09:16 +01:00
Max Kellermann	943a67c805	decoder/ogg: need to sync small files while looking for EOS When calling OggSeekFindEOS() from inside a OggVisitor callback, then the #InputStream may be in the middle of an Ogg packet, and the newly initialized #ogg_sync_state will not be able to load it without the help of ogg_sync_pageseek(). By passing "synced=false" to OggSeekFindEOS(), we force the use of ogg_sync_pageseek() even when not actually seeking. Closes https://github.com/MusicPlayerDaemon/MPD/issues/719	2020-01-25 20:07:11 +01:00
Max Kellermann	881d91f86b	lib/xiph/OggFind: add parameter "synced"	2020-01-25 20:07:10 +01:00
Max Kellermann	54d57fdcc2	test/DumpDecoderClient: dump the `seekable` flag	2020-01-25 20:07:09 +01:00
Max Kellermann	f6f30d6d64	increment version number to 0.21.20	2020-01-25 20:06:58 +01:00
Max Kellermann	4013fa15b9	release v0.21.19	2020-01-17 15:49:02 +01:00
Max Kellermann	ac1b844c15	android/AndroidManifest.xml: increase targetSdkVersion to 28 Google Play refuses uploads with a lower targetSdkVersion.	2020-01-17 15:48:43 +01:00
Max Kellermann	b8614048d4	python/build/libs.py: update Boost to 1.72.0	2020-01-17 15:33:13 +01:00
Max Kellermann	aed0d13591	python/build/libs.py: update expat to 2.2.9	2020-01-17 15:33:13 +01:00
Max Kellermann	9d02103ebe	python/build/libs.py: disable various CURL features we don't use	2020-01-17 15:33:13 +01:00
Max Kellermann	61784c2144	python/build/libs.py: update CURL to 7.68.0	2020-01-17 15:19:46 +01:00
Max Kellermann	7059215795	python/build/libs.py: update FFmpeg to 4.2.2	2020-01-17 15:19:00 +01:00
Max Kellermann	2190cc7927	python/build/libs.py: update FLAC to 1.3.3	2020-01-17 15:17:21 +01:00
Max Kellermann	75dc9506c2	python/build/libs.py: update libmpdclient to 2.17	2020-01-17 15:16:20 +01:00
Max Kellermann	4f11fa0d41	config/File: allow overriding top-level settings in includes Remove the error message and instead erase the old setting if the "repeatable" flag is not set. https://github.com/MusicPlayerDaemon/MPD/issues/684	2020-01-17 14:58:40 +01:00
Max Kellermann	ce7ec2b3f5	meson.build: add -f{function,data}-sections to C++ as well By accident, this was only enabled for C.	2020-01-14 17:48:48 +01:00
Max Kellermann	fada4aa529	NEWS: mention the Android build fix	2020-01-12 13:08:37 +01:00
Max Kellermann	aa0e121ade	android/build.py: support x86_64 builds	2020-01-12 13:03:18 +01:00
Max Kellermann	b4700039fd	android/build.py: drop -lmstackrealign This flag doesn't appear to work, and since we never had a problem without the flag, implementing Google's recommendation is useless.	2020-01-12 13:03:18 +01:00
Max Kellermann	ab41c16eb5	android/build.py: add -Wl,--exclude-libs=ALL Don't export the symbols of all those static libraries. Most importantly, don't export the whole libc++ ABI.	2020-01-12 12:47:40 +01:00
Max Kellermann	04101f37b8	android/build.py: add -fno-faddrsig and -lmstackrealign	2020-01-12 12:41:37 +01:00
Max Kellermann	8c31370534	android/build.py: drop --sysroot, -isystem, -L, ... These appear to be no longer necessary (tested with NDK r20b). Closes https://github.com/android/ndk/issues/951	2020-01-12 12:11:09 +01:00
Max Kellermann	2306b0d78c	android/build.py: append API level to LLVM triple This implicitly defines __ANDROID_API__, which means we can drop the "-D__ANDROID_API__=" parameter. This is recommended on https://android.googlesource.com/platform/ndk/+/ndk-release-r20/docs/BuildSystemMaintainers.md	2020-01-12 12:02:12 +01:00
Max Kellermann	cb1a9045e6	android/build.py: drop "-none" from llvm_triple It's not mentioned on https://developer.android.com/ndk/guides/other_build_systems	2020-01-12 11:51:20 +01:00
Max Kellermann	e92af06664	android/build.py: remove obsolete dict key android_api_level	2020-01-12 11:49:10 +01:00
Max Kellermann	af20a1c994	pulse: obey Pulse's maximum sample rate (fixes DSD128 playback) Closes https://github.com/MusicPlayerDaemon/MPD/issues/708	2020-01-12 07:58:17 +01:00
Max Kellermann	756560eac3	.travis.yml: add ARM64 build (for NEON optimizations)	2020-01-01 18:36:59 +01:00
Jacob Vosmaer	dca0519336	Clang: only use [[fallthrough]] in C++ files It appears that [[fallthrough]] is valid in C++ but not in C. And in some Clang versions (e.g. Clang 11 on macOS), Clang is pedantic about this and considers it an error to use [[fallthrough]] in a .c file such as src/util/format.c. This changes makes gcc_fallthrough a no-op under Clang in C files.	2019-12-31 13:54:09 +01:00
Max Kellermann	b9a7f30443	.travis.yml: add s390x build (big-endian)	2019-12-24 16:47:07 +01:00
Max Kellermann	32a17a997a	increment version number to 0.21.19	2019-12-24 16:41:13 +01:00