f319f88df4
[cppcheck] use const for several variables
...
Found with constVariable
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-23 21:03:22 -07:00
637840264a
util/WStringCompare: reorder functions to relocate API docs
2020-03-22 19:20:29 +01:00
3888bafc1f
util/StringCompare: add API documentation
2020-03-22 19:15:55 +01:00
adad4c7298
util/StringCompare: add missing include
2020-03-22 19:12:02 +01:00
d54acbcffd
Merge branch 'sles-assert-fix' of git://github.com/tguillem/MPD-1
2020-03-22 10:51:28 +01:00
86613af37e
output/sles: fix invalid assert
...
Regression from 973c87b351
2020-03-21 22:34:04 +01:00
ba3ff10ccd
remove false ifdef
...
The entire section falls under the else path of #ifdef _WIN32. Checking
for it makes no sense. Probably some refactoring mistake.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-20 17:56:33 -07:00
1ec283d213
util/Exception: include cleanup
2020-03-19 20:13:04 +01:00
2261bcb5d3
android/Environment: remove another extra semicolon
2020-03-19 20:13:04 +01:00
0e17629445
android/Environment: remove extra semicolon
2020-03-19 15:27:43 +01:00
0da6344726
Merge tag 'v0.21.21'
...
release v0.21.21
2020-03-19 15:26:27 +01:00
c560ec8ea6
release v0.21.21
2020-03-19 15:22:28 +01:00
cade4e71c4
[clang-tidy] add [[nodiscard]]
...
Found with modernize-use-nodiscard
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-19 13:38:40 +01:00
403612c666
[clang-tidy] run through performance checks
...
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-19 13:38:40 +01:00
7fe49cf24d
[clang-tidy] use default member init
...
Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-19 13:38:40 +01:00
d2115e908a
[clang-tidy] remove redundant access specifiers
...
Found with readability-redundant-access-specifiers
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-19 13:38:40 +01:00
56c234b410
raise default "max_connections" value to 100
...
Documentation says the limit is 5, but it was really 10 (at least
since 2004). But since MPD wants to promote using many small clients
idling around, and these clients consume only very few resources, it
seems reasonable to raise this limit's default value.
2020-03-19 13:30:46 +01:00
61b5ab2663
thread/CriticalSection: remove extra semicolons
2020-03-17 16:57:57 +01:00
84f71cec2c
add two extra noreturn that clang picked up
...
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 23:02:35 -07:00
a5b136c420
test: fix double promotion
...
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 22:56:30 -07:00
c7144ed5c7
add recently fixed warnings to warning list
...
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 22:56:29 -07:00
00b9f69c90
remove some more extra semicolons
...
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 13:37:13 -07:00
6d91b5c7b2
fix double promotions
...
Found with -Wdouble-promotion
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 12:43:24 -07:00
fd71514068
Merge remote-tracking branch 'neheb/h'
2020-03-16 17:29:05 +01:00
256cfc545d
Merge remote-tracking branches 'neheb/fwhfggwe', 'neheb/nvm2', 'neheb/nvm22', 'neheb/bvm' and 'neheb/cl2'
2020-03-16 17:25:50 +01:00
77c6c3fabf
remove unreachable code
...
Found with -Wunreachable-code-break
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:14:13 -07:00
e25a3d17e7
remove extra semicolon
...
Found with -Wextra-semi
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:13:20 -07:00
7f10e7a610
fix implicit-fallthrough warnings under clang
...
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:12:38 -07:00
88d56c01e7
fix missing overrides
...
Found with clang's -Winconsistent-missing-destructor-override
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:11:15 -07:00
97425d56e7
remove gcc_unused
...
[[maybe_unused]] (introduced in C++17) is standard C++.
https://clang.llvm.org/docs/AttributeReference.html#maybe-unused-unused
says that this is equivalent to the GNU unused attribute.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:08:21 -07:00
0afb156a5b
remove gcc_warn_unused
...
[[nodiscard] (introduced in C++17) can be used instead.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:08:21 -07:00
a192e7b29b
remove gcc_deprecated
...
[[deprecated]] (introduced in C++14) may be used instead.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:08:21 -07:00
591f51f3d3
replace noreturn attribute with standard C++ version
...
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-16 00:08:18 -07:00
5e4b7e2fb7
[clang-tidy] fix incorrect rounding
...
Found with bugprone-incorrect-roundings
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-15 20:22:08 -07:00
177371a003
treewide: get rid of C math function usage
...
Boost does not seem to offer an overload for lrint.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-15 20:22:07 -07:00
a78841d6a9
volume_mapping: get rid of exp10 workaround
...
exp10 is a GNU function, is not part of C++, and is not available
everywhere.
pow(10,x) is an alternative that works just as well. It is used in musl as
the implementation of exp10.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-15 20:17:31 -07:00
3ec9fcfc44
treewide: use boost::lround when std::round is unavailable
...
This is the case with uClibc-ng currently.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2020-03-15 20:17:31 -07:00
b5d1a09010
util/StringUtil: pass std::string_view to StringArrayContainsCase()
2020-03-13 20:38:40 +01:00
85b072b3d3
util/StringCompare: add StringIsEqual() with string_view
2020-03-13 20:36:48 +01:00
8a1f1fbe06
util/ASCII: migrate to std::string_view
2020-03-13 20:17:53 +01:00
45b60b3d38
fs/Traits: GetParent() returns std::string_view
2020-03-13 20:01:10 +01:00
cefc773992
playlist/PlaylistSong: pass std::string_view
2020-03-13 19:58:36 +01:00
a885bdba4c
fs/Traits: pass string_view to Build()
2020-03-13 19:55:28 +01:00
b6b15afb5a
fs/Path: make constructor explicit
2020-03-13 19:55:25 +01:00
1d560c8f0f
fs/AllocatedPath: add string_view constructor
2020-03-13 19:46:29 +01:00
189f6eaa6f
fs/Traits: add string_view
2020-03-13 19:43:39 +01:00
87f78b9c39
fs/Traits: use {} notation for return values
2020-03-13 19:43:23 +01:00
aa722bd8ac
fs/Traits: use auto
2020-03-13 19:43:23 +01:00
58c7ec07a4
fs: use using instead of typedef
2020-03-13 19:43:23 +01:00
3796247d6d
util/Stringview: use const_pointer instead of hard-coding const char *
...
Fixes Windows build failure.
2020-03-13 19:43:23 +01:00
