e1349ccadc
player/Thread: ProcessCommand() returns bool
...
Allows signalling a failed seek, and replaces several redundant
command checks after the ProcessCommand() call.
2017-12-28 08:30:01 +01:00
8838bdc1e3
player/Thread: move CommandFinished() call out of SeekDecoder(SongTime)
...
Decouple this function from player command execution.
2017-12-27 14:28:56 +01:00
d6386bc80f
player/Thread: update code comment
2017-12-27 14:26:14 +01:00
6439727afc
player/Thread: use std::lock_guard in RunThread()
2017-12-22 09:35:31 +01:00
27b0a581a6
player/Thread: even more fine-grained unlocking
...
Use one single std::lock_guard in Run(), and replace the manual
Lock()/Unlock() calls.
2017-12-22 08:09:16 +01:00
15a54230f1
player/Thread: move unlock call down
...
Eliminate more unlock/lock transitions, making the code more robust.
2017-12-22 01:14:51 +01:00
f0d184884a
player/Thread: remove obsolete commented code
2017-12-22 01:14:39 +01:00
8fca04f140
player/Thread: add missing lock for StartDecoder()
...
Regression from commit 0772e571b7
2017-12-22 01:12:15 +01:00
3b2b5edd26
player/Thread: move mutex lock out of SeekDecoder()
2017-12-22 01:07:13 +01:00
5bd1fbb0d6
player/Thread: merge four mutex locks in SeekDecoder()
2017-12-22 01:04:44 +01:00
0772e571b7
player/Thread: move mutex lock out of StartDecoder()
2017-12-22 01:03:12 +01:00
910496cea9
decoder/Control: caller must lock mutex for Start()
2017-12-22 01:03:01 +01:00
739e1da279
player/Thread: move mutex lock out of ActivateDecoder()
2017-12-22 00:58:57 +01:00
08b4a7aaf2
player/Thread: eliminate LockWaitDecoderStartup()
2017-12-22 00:58:42 +01:00
1f0770ca55
player/Thread: move code to SeekDecoder(SongTime)
2017-12-22 00:49:21 +01:00
505d0bfa51
player/Thread: move mutex lock out of StopDecoder()
2017-12-22 00:48:19 +01:00
860d13c7d8
decoder/Control: caller must lock mutex for Stop()
2017-12-22 00:48:12 +01:00
76d77af0f0
player/Thread: use std::lock_guard once more
2017-12-22 00:47:36 +01:00
ea8ab4ddf2
player/Thread: merge two mutex locks
2017-12-22 00:42:10 +01:00
4bcc38c749
player/Thread: move mutex lock out of WaitDecoderStartup()
2017-12-22 00:41:05 +01:00
5becffbba5
player/Thread: merge two mutex locks
2017-12-22 00:39:54 +01:00
d0194a6fb3
decoder/Control: caller must lock mutex for Seek()
2017-12-22 00:37:25 +01:00
e45d13d469
player/Thread: add missing mutex lock around PlayerControl::SetError()
2017-12-22 00:35:18 +01:00
a431274b32
player/Control: add "occupied" flag to skip REFRESH
...
Reduces main thread contention. Avoids blocking the main thread in
"status" commands.
2017-12-21 10:25:40 +01:00
994c9a01e3
player/Control: reorder attributes to reduce padding
2017-12-21 10:25:38 +01:00
b2670eaba5
player/Thread: move start_time variable into the scope
2017-12-20 19:15:28 +01:00
54aff33118
player/Thread: reorder attributes to reduce padding
2017-12-20 18:43:56 +01:00
25fa3ccade
MusicChunk, player/Thread: use std::unique_ptr<Tag>
2017-12-20 15:02:14 +01:00
4286f55c52
player/Thread: use C++11 initializers
2017-12-20 13:35:07 +01:00
0a7cad9074
player/Thread: add "noexcept"
2017-12-20 13:32:38 +01:00
069a7fe71e
player/Thread: more API documentation
2017-12-20 13:27:13 +01:00
9c8a45854a
player/Control: add SEEK documentation
2017-12-20 12:20:11 +01:00
7d035edf9d
player/Control, ...: remove API documentation references to the obsolete Error class
2017-12-20 12:20:09 +01:00
914df18bf9
Main, ...: catch any exception, not just std::runtime_error
2017-12-19 10:56:23 +01:00
fbc4bb29dc
Merge branch 'v0.20.x'
2017-12-03 16:22:08 +01:00
de90d401d2
MusicChunk: add magic value IGNORE_REPLAY_GAIN
...
This fixes spurious replay gain logs when the player inserts silence
chunks, because those silence chunks had no replay gain attached,
resetting the ReplayGainFilter state, flipping it forth and back.
2017-12-03 11:39:12 +01:00
396defaea9
MusicChunk: initialize replay_gain_serial on demand
2017-12-03 11:39:07 +01:00
18f350cd04
player/Thread: initialize MusicChunk::bit_rate in SendSilence()
...
This attribute is not particularly important, but it was
uninitialized.
2017-12-03 10:54:14 +01:00
520c520512
player/Listener: add "noexcept"
2017-11-26 12:39:09 +01:00
28fdf1e9ed
decoder/Control: wrap DetachedSong* in std::unique_ptr
2017-11-26 12:16:53 +01:00
b13b023c6b
player/Control: wrap DetachedSong* in std::unique_ptr
2017-11-26 12:06:38 +01:00
624e679e35
player/Control: add "noexcept"
2017-11-26 12:02:08 +01:00
523051132d
Merge branch 'v0.20.x'
2017-11-05 17:48:41 +01:00
28e864e096
player/Thread: log message when decoder is too slow
2017-10-25 20:26:09 +02:00
0b93f52ba4
Merge tag 'v0.20.10'
...
release v0.20.10
2017-08-24 09:35:34 +02:00
a00d412008
player/Thread: initialize play_audio_format, fixes assertion
...
This fixes an assertion failure caused by resuming playback before the
decoder has finished startup.
2017-08-23 17:43:49 +02:00
979f1b6c39
Merge tag 'v0.20.9'
...
release v0.20.9
2017-06-04 12:57:05 +02:00
a057b4f6d8
*: add lost of "noexcept" specifications
2017-06-04 12:46:48 +02:00
4faef28cc5
Merge tag 'v0.20.7'
...
release v0.20.7
2017-05-15 23:01:49 +02:00
71f0ed8b74
*: add "noexcept" to many, many function prototypes
...
This eliminates some overhead, because the compiler doesn't need to
consider these functions throwing.
2017-05-08 14:44:49 +02:00
Max Kellermann