oysteikt
/
mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
15,232 Commits 1 Branch 144 Tags 56 MiB
Commit Graph

15232 Commits

Author SHA1 Message Date
Max Kellermann e0edf0b206 meson.build: move VERSION and others to Version.h 2020-05-05 15:12:11 +02:00
Max Kellermann 4e9fa36176 meson.build: remove unused macro PACKAGE_VERSION 2020-05-05 15:08:39 +02:00
Max Kellermann 8f178401e4 */plugins/meson.build: define feature macros in Features.h 
This makes ccache more efficient when recompiling with different
plugins.
 2020-05-05 15:06:50 +02:00
Max Kellermann 8c1d78873d system/KernelVersion: new library 2020-05-05 14:30:56 +02:00
Max Kellermann 9815d10137 system/FileDescriptor: move to io/ 2020-05-05 14:27:03 +02:00
Max Kellermann 97f7270aa8 fs/FileSystem: remove unused function FOpen() 2020-05-05 14:19:29 +02:00
Max Kellermann 1787aa5e00 decoder/sidplay: drop support for libsidplayfp < 1.8 2020-05-05 13:53:10 +02:00
skidoo23 e251fd0053 Add info about new song length format 2020-04-30 13:35:29 +02:00
skidoo23 a485c4856c decoder/sidplay: support new song length format with libsidplayfp 2.0 2020-04-29 16:27:54 +02:00
Sören Tempel 3c955639a7 doc: Document required order of currentsong response 
The parser implemented in libmpdclient requires the first key-value pair
of the server response to be the file pair. This is due to the fact that
libmpdclient scan pairs sequentially and first attempts to extract the
file pair before parsing the currentsong response further. See:

	5c751a761e/src/song.c (L559-L563)

Meta data encoded as pairs in the currentsong response will be ignored
if they are placed before the file pair in the response.
 2020-04-27 17:47:24 +02:00
Max Kellermann bca9678683 tag/FixString: use IsNonPrintableASCII() 
Fixes breakage of non-ASCII characters, regression from commit
cc72ceb368

Fixes https://github.com/MusicPlayerDaemon/MPD/issues/842
 2020-04-27 14:01:54 +02:00
Max Kellermann 814b2a218d util/CharUtil: add IsNonPrintableASCII() 
Prepare to fix cc72ceb368
 2020-04-27 14:01:54 +02:00
John Regan 6423670eae gme: use song-reported fade-out time when available 2020-04-26 09:24:34 -04:00
John Regan 90a2109fd1 gme: add configurable fade-out time 
Also include fade-out time in song length.
 2020-04-26 09:21:57 -04:00
Max Kellermann 464b90210c tag/GenParseName: include stdlib.h for EXIT_SUCCESS 
Closes https://github.com/MusicPlayerDaemon/MPD/issues/838
 2020-04-24 20:39:24 +02:00
Max Kellermann fa45a8adfa tag/ParseName: generate an optimized tag_name_parse() at build time 2020-04-24 16:28:29 +02:00
Max Kellermann 1532983fb5 tag/Pool: use strncmp() without strlen() to compare strings 2020-04-24 16:16:19 +02:00
Max Kellermann ae5b2643da tag/Builder: reserve room in std::vector in default constructor 
This reduces resource waste for resizing the std::vector in most
cases.
 2020-04-24 16:16:19 +02:00
Max Kellermann 02556ffce9 tag/Tag: use class DereferenceIterator 2020-04-24 16:02:36 +02:00
Max Kellermann 18ca734819 util/DereferenceIterator: new utility class 2020-04-24 16:02:31 +02:00
Max Kellermann 8a28f7b0a1 tag/FixString: add optimistic quick check 
Optimizes a few nanoseconds from the common code path.
 2020-04-24 15:57:40 +02:00
Max Kellermann cc72ceb368 tag/FixString: use IsPrintableASCII() 2020-04-24 15:42:09 +02:00
Naglis Jonaitis c021efced1
Fix typo in documentation 2020-04-24 00:36:46 +03:00
Max Kellermann 0b3acc3eec release v0.21.23 
-----BEGIN PGP SIGNATURE-----
 
 iQJEBAABCgAuFiEEA5IzWngIOJSkMBxDI26KWMbbRRIFAl6huEwQHG1heEBtdXNp
 Y3BkLm9yZwAKCRAjbopYxttFEgcrD/9jLUkiszNc+QWbUGj+RiTaD6fMxA1M8itn
 nB7MKI/g/3ggryWMWNhG51O+8wFNs/4PmJJPGxKoU6i6wmS3YFhTAcs0ryilDGAU
 1FumnMg/2qIyi2E6K2BMbi0YwZiJhBPWwD4JSt1KGvwPes/qQPFgHAi7ZWhP3tar
 fHmgmjwDZ/Kgpl5/Bn7nVNgVuzk/MpBOSwxX9tFtRxqE9wdpm9idve7SVDT7MTvk
 vdONWbAe8jXl/A8JHWaUsws0l7fyK5ZKSOXvdeSbzd67I8Rz3aqJMqUh2k/rDuv/
 GrDyeEtLV5cXZsL4B3/34kCTKac2ZJmRbSh+buKeDc1Gf0clWnvRMdsMbSoRBY4F
 lTWJbjndfq2+iHHBRfaqRjombv52R11yLT+O0aMLEm6l7xPm/rHZXJIcYSmCafd7
 FR1qMaVKP5s+M+MqGePxzCUJSWJ+1bjZwjLaHrYXYPUoXSg3mSaeDE5g7BjQhm1E
 2Hcfui9lvqR55UNo0NvDBjRT5FBGBUdjF6DjYplUGApw7xFtdahXlEvG7yfyg3ae
 pZ3FQ1MZ4dESAw7EhTEBwajsVRQ9DhGQenYTxxCnGVdCucZRPQ9Abhas0U4iFHUA
 wGj7j4WKPi+OUSyiT0j4nGuwEVtCkBFv34DqPMLjx8jqtJ8YgCt4iJD4dFwhk1zz
 uoQBhq27Gg==
 =sR2r
 -----END PGP SIGNATURE-----

Merge tag 'v0.21.23'

release v0.21.23
 2020-04-23 18:01:23 +02:00
Max Kellermann 6c240f667c release v0.21.23 2020-04-23 17:46:20 +02:00
Max Kellermann 3040ddb5ec lib/nfs/FileReader: use `struct stat64` on Windows 32-bit 
libnfs is compiled with `-D_FILE_OFFSET_BITS=64`, but Meson decides
not to enable this mode.  We could force this mode, but then again,
these days, nobody should be using 32-bit Windows ... so this is a
kludge only for debugging with 32-bit WINE.
 2020-04-23 17:32:34 +02:00
Max Kellermann fdb28eb0c4 fs/NarrowPath: preserve nullptr in Path operator 
Fixes Path::IsNull() checks on Windows.
 2020-04-23 17:10:28 +02:00
Max Kellermann 7ded244a61 lib/nfs/Connection: pass POLLHUP and POLLERR to nfs_service() 2020-04-23 16:58:53 +02:00
Max Kellermann 8ed533acf3 event/SocketMonitor: handle epoll_ctl()=EBADF/ENOENT in Schedule() 
This fixes a freeze bug in the NFS input/storage plugins: when libnfs
auto-reconnets after a failure, it installs the new socket on the same
file descriptor number.  MPD's attempt to unregister the old socket by
calling SocketMonitor::Steal() from NfsConnection::ScheduleSocket()
fails because the new/old socket number is not registered in epoll, so
epoll_ctl() returns ENOENT.  The problem is that it left
`scheduled_flags`, and so subsequent Schedule() calls will use
`EPOLL_CTL_MOD`, which will fail again and again.  Instead, we need to
use `EPOLL_CTL_ADD` to register the new socket.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/806

Closes https://github.com/MusicPlayerDaemon/MPD/issues/756
 2020-04-23 16:58:26 +02:00
Max Kellermann a27580d0cc lib/nfs/Connection: don't pass HANGUP to Schedule() 
This flag is output-only.
 2020-04-23 15:21:04 +02:00
Max Kellermann 905db05cf9 zeroconf/AvahiPoll: don't pass ERROR|HANGUP to Schedule() 
These flags are output-only.
 2020-04-23 15:19:24 +02:00
Max Kellermann 4242aee21e event/SocketMonitor: remove HANGUP|ERROR from ScheduleRead() 
These flags are output-only.  Using them here is misleading.
 2020-04-23 15:18:18 +02:00
Max Kellermann e71bd2a08b event/PollGroupWinSelect: make EVENT_{READ,WRITE} `static` 2020-04-23 15:10:57 +02:00
Max Kellermann e53a4d0a9e lib/nfs/FileReader: reset `state` in OnNfsCallback() 
The object's state is `IDLE` when OnNfsCallback() gets invoked, so
let's use the start of the method to reset the `state` field.
 2020-04-23 14:54:52 +02:00
Max Kellermann 159389164a lib/nfs/FileReader: set `state=IDLE` before invoking callback 
Fixes assertion failure if the callback fails.
 2020-04-23 14:51:43 +02:00
geneticdrift 0a92fbc18e tag/Fallback: add tag fallback for AlbumSort 
Closes https://github.com/MusicPlayerDaemon/MPD/issues/832
 2020-04-22 22:00:38 +02:00
Max Kellermann 138c29320b gme: adapt to API change in the upcoming version 0.7.0 
Closes https://github.com/MusicPlayerDaemon/MPD/issues/833
 2020-04-22 21:53:00 +02:00
Max Kellermann 8f00dbea45 lib/icu/Compare: add Windows implementation 
Using CompareStringEx() and FindNLSStringEx().

Implements a missing piece for
https://github.com/MusicPlayerDaemon/MPD/issues/820
 2020-04-22 21:42:12 +02:00
Max Kellermann f3fd2eb618 lib/icu/Compare: use AllocatedString::Clone() 2020-04-22 21:39:13 +02:00
Max Kellermann fc92db83cf lib/icu/Collate: use NORM_IGNORECASE instead of LINGUISTIC_IGNORECASE 
LINGUISTIC_IGNORECASE is unimplemented on Wine, but since we don't
have any locale support (yet), and we're using LOCALE_NAME_INVARIANT,
NORM_IGNORECASE should essentially be the same, so why bother.
 2020-04-22 21:39:13 +02:00
Max Kellermann 3b0f8d5516 lib/icu/CaseFold: remove Windows implementation 
Reverts commit fb3564fbe7

LCMapStringEx() doesn't do what I imagined it would do 5 years ago.
D'oh!

Closes https://github.com/MusicPlayerDaemon/MPD/issues/820
 2020-04-22 19:32:36 +02:00
Rosen Penev a5273d6992 Fix unsafe float comparison. 
Switching == to >= should be safe here since the next if is the opposite.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-22 18:21:40 +02:00
Rosen Penev 6979be008c [clang-tidy] use auto 
Found with modernize-use-auto.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-22 18:21:07 +02:00
Rosen Penev 71792ffd43 [clang-tidy] use raw string 
Found with modernize-raw-string-literal

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-22 18:21:00 +02:00
Rosen Penev 3c145c0f49 [clang-tidy] add nodiscard 
Found with modernize-use-nodiscard

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-22 18:20:51 +02:00
Thomas Guillem b18074f899 storage/curl: fix path comparison when the server escapes differently 
Unescape the base path and the path coming from the server (href) to fix the
comparison when the server uses different escaped characters.

The outputted name need to be unescaped. Doing that before or after the
HrefToEscapedName() call should not change the current behavior.
 2020-04-15 13:50:12 +02:00
Thomas Guillem 3d8067a041 storage/curl: fix href when file has a '&' char 
If the file name is "Hello & bye", 3 CharacterData events will be sent with the
State::HREF state:
 - "Hello%20"
 - "&"
 - "%20bye"

Reproduced with files hosted on an apache2 DAV server: 2.4.38-3+deb10u3.
 2020-04-15 13:18:16 +02:00
Florian Heese f6fe001fa9 Added missing channel order setups for ALSA 2020-04-15 13:13:09 +02:00
Max Kellermann 55b8f2c533 NEWS: add line about Solaris change 2020-04-14 16:11:18 +02:00
Max Kellermann 32a5bf043b player/Thread: drain outputs at end of song in "single" mode 
Without this, the Pause() call would drop the ring buffers and would
skip a considerable portion of the end of the song.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/824
 2020-04-14 16:07:03 +02:00