de8f2739c2
decoder/mikmod: fix memory leak
...
The return value of Player_LoadTitle() is allocated with malloc(), and
must be freed by the caller.
2010-05-31 10:24:08 +02:00
2c1c588868
decoder/mikmod: duplicate the path only once
2010-05-31 10:22:08 +02:00
e271f69a34
decoder/mikdmod: moved local variable declarations in tag_dup()
2010-05-31 10:16:09 +02:00
39105f2119
decoder/wildmidi: moved local variable declarations in tag_dup()
2010-05-31 10:14:48 +02:00
4e080a9b06
decoder/gme: replace macro GME_BUF_SIZE
...
Added macros with better names: GME_BUFFER_FRAMES, GME_BUFFER_SAMPLES
(the former only used to calculate the latter).
2010-05-31 10:03:43 +02:00
d55740808d
decoder/gme: added constants for sample rate and channels
...
Move into enums.
2010-05-31 10:02:43 +02:00
6566038df9
decoder/gme: pass the whole buffer to decoder_data()
...
Pass sizeof(buf) to decoder_data(), not the number of samples (which
is half the size). At the same time, pass GME_BUF_SIZE to gme_play()
- libgme really wants to get the number of samples, not the number of
stereo frames. Previously, this plugin had been using only the first
half of the buffer.
2010-05-31 09:57:15 +02:00
f0faf00320
decoder/gme: allocate tag later, fixes memory leak
...
Allocate the "tag" object after the file has been opened successfully.
2010-05-31 09:43:25 +02:00
51c7577c8f
decoder/mp4ff: rename and move local variable
...
Allocate the "tag" object after the file has been checked. That
removes one tag_free() call in an error handler.
2010-05-31 09:35:49 +02:00
be308c6657
decoder/mp4ff: merge code into mp4ff_input_stream_open()
2010-05-31 09:29:45 +02:00
1729a0b437
decoder/mp4ff: move mp4ff_callback_t into mp4ff_input_stream
...
Allocate only one item on the stack.
2010-05-31 09:23:27 +02:00
1b2fc2ae19
decoder/mp4ff: rename mp4_context to mp4ff_input_stream
2010-05-31 09:22:42 +02:00
58a75f0b78
decoder/mp4ff: remove duplicate entries in the tag name table
...
Reuse the function tag_name_parse_i().
2010-05-31 08:48:41 +02:00
daf6e2b5da
decoder/mp4ff: moved code to mp4ff_tag_name_parse()
2010-05-31 08:47:59 +02:00
71da5b026c
tag_ape: remove duplicate entries in the tag name table
...
Reuse the function tag_name_parse_i().
2010-05-31 08:24:05 +02:00
2f68ea635b
tag_ape: move code to tag_ape_name_parse()
2010-05-31 08:22:53 +02:00
ca08c4dbf4
decoder/vorbis: rename local variable "ret"
2010-05-31 00:06:37 +02:00
8af52fa205
decoder/vorbis: implement method stream_tag()
...
This allows tags in archive files.
2010-05-31 00:02:57 +02:00
3b0bf856c4
decoder/vorbis: move code to vorbis_open_stream()
2010-05-31 00:00:04 +02:00
28f5803d34
decoder/vorbis: use single global ov_callbacks constant
...
Initialize the ov_callbacks struct at compile time.
2010-05-30 23:59:36 +02:00
0b72299857
decoder/vorbis: rename struct vorbis_decoder_data to vorbis_is
2010-05-30 23:57:58 +02:00
4a2302c2ed
inotify_update: follow symlinks
...
This is probably unsafe, and doesn't protect against symlink loops,
but we will eventually add this when we bring update*.c and inotify*.c
closer together.
2010-05-30 23:45:47 +02:00
980201a665
inotify_update: fix assertion failure when music dir is deleted
...
This shouldn't really happen, but insane users might delete/rename the
music directory while MPD runs. What was even more insane was that
MPD crashed due to this. This is a workaround - there is currently
nothing useful we can do in this case; except maybe poll for the music
directory to reappear, but that's too much trouble for a user error.
2010-05-30 23:45:46 +02:00
d60bcd2869
test: added debug program "run_inotify"
2010-05-30 23:30:43 +02:00
017d61a1aa
decoder/mp4ff: support tags "albumartist", "band"
...
I'm not sure if mapping "band" to TAG_PERFORMER is correct, but it
might be better than nothing.
2010-05-30 22:55:02 +02:00
4028d03a6e
decoder/mp4ff: use tag_table.h to parse tag names
...
Convert if/else/else/... to a loop.
2010-05-30 22:52:45 +02:00
44b771aca1
decoder/mp4ff: rename plugin "mp4" to "mp4ff"
...
The underlying library is named "libmp4ff". To reduce confusion,
rename the plugin to a more specific name.
2010-05-30 22:52:44 +02:00
8c581eca4d
tag_ape: move table lookup to tag_table.h
...
Allow code sharing.
2010-05-30 22:52:19 +02:00
8e815bec9f
tag_ape: support album artist, MusicBrainz tags
...
I took these tag names from a MusePack sample file I got from a user.
These are not documented in the APE specification:
http://wiki.hydrogenaudio.org/index.php?title=APE_key
People seem to be using undocumented extensions to the specification
anyway, and the best we can do is attempt to support them.
2010-05-30 22:29:48 +02:00
9dda53e1d2
Merge release 0.15.10 from branch 'v0.15.x'
...
Conflicts:
NEWS
configure.ac
src/input/mms_input_plugin.c
2010-05-30 18:26:33 +02:00
57e95ea6f4
mpd version 0.15.10
2010-05-30 08:59:00 -07:00
442d2e74e3
decoder/mad: fix buffer variable name on !HAVE_ID3TAG
2010-05-30 17:27:03 +02:00
e8310211e2
filter/replay_gain: added option "replaygain_limit"
2010-05-30 17:06:08 +02:00
3709b9aa11
configure: Surround statements with brackets to prevent being treated as args.
2010-05-26 12:38:03 -07:00
c5a291ad74
configure.ac: Add sqlite results to the pretty print.
2010-05-25 22:01:28 -07:00
894573657d
cmdline: Add default config paths for win32.
2010-05-20 06:56:43 -07:00
9cce1d749a
output/win32: new output plugin for Windows Wave
2010-05-20 09:33:05 +02:00
ed0b48040c
pcm_buffer: 8 kB alignment instead of 64 kB
...
Reduce the overhead. Most buffers used by MPD are around 2 to 4 kB.
8 kB seems large enough to keep heap fragmentation low.
Additionally, this patch fixes an off-by-one error in the alignment
formula.
2010-05-20 09:31:51 +02:00
9aeed06964
test: enable binary mode on stdin/stdout
...
Declaring the global variable _CRT_fmode is a documented hack. What
an ugly platform!
2010-05-20 09:20:30 +02:00
eda46bc07f
tag_{id3,ape}: explicitly open files in binary mode
...
Add the flag "b" to fopen(). Windows compatibility.
2010-05-20 09:14:11 +02:00
c727e86980
input/file, output/{fifo,recorder}: add O_BINARY to open() flags
...
Windows compatibility.
2010-05-20 09:13:39 +02:00
57b4013306
client: use sprintf() on WIN32
...
On mingw32, snprintf() expects a 64 bit integer instead of a "long
int" for "%li" - this is not consistent with our expectation, so we're
using plain sprintf().
2010-05-19 13:12:37 +02:00
fc5a7a8774
Makefile.am: disable test/read_mixer unless HAVE_ALSA
2010-05-19 11:47:55 +02:00
8248f498b2
event_pipe: use g_io_channel_read_chars() to drain the pipe
...
For some unknown reason, read() blocks on WIN32, even though it was
invoked inside the G_IO_IN callback. By switching to GIOChannel
functions, this problem is solved, and it works on both Linux and
Windows.
2010-05-19 11:37:39 +02:00
22f3ffb099
event_pipe: call g_io_channel_win32_new_fd()
...
On WIN32, use g_io_channel_win32_new_fd() instead of
g_io_channel_unix_new(). There doesn't seem to be a practical
difference, but it seems more correct.
2010-05-19 11:37:22 +02:00
81bd8ef73c
update_walk: don't check recursive symlinks on WIN32
...
inode numbers don't work on WIN32, and very few WIN32 users actually
use symlinks - seems ok to disable that check.
2010-05-19 11:36:07 +02:00
bedc172eab
crossfade: emulate strtok_r() on WIN32 with a function
...
Not a CPP macro. This adds the "unused" attribute to "saveptr", which
eliminates one gcc warning.
2010-05-18 23:56:53 +02:00
0a9b0dd070
command: fallback strftime() formats on WIN32
...
On WIN32, "%F" and "%T" are not implemented.
2010-05-18 23:54:12 +02:00
6aa0f61e15
socket_util: fix setsockopt() argument type on WIN32
...
In the winsock headers, the setsockopt() argument is declared as
"const char *", not "const void *".
2010-05-18 23:13:05 +02:00
4461c3d5d1
daemon: include glib.h on WIN32 for g_error()
2010-05-18 23:13:05 +02:00
Max Kellermann