oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
4,324 Commits 1 Branch 144 Tags 56 MiB
b1e95b1fa8
Commit Graph

104 Commits

Author SHA1 Message Date
Eric Wong
90847fc881 Replace strdup and {c,re,m}alloc with x* variants to check for OOM errors 
I'm checking for zero-size allocations and assert()-ing them,
so we can more easily get backtraces and debug problems, but we'll
also allow -DNDEBUG people to live on the edge if they wish.

We do not rely on errno when checking for OOM errors because
some implementations of malloc do not set it, and malloc
is commonly overridden by userspace wrappers.

I've spent some time looking through the source and didn't find any
obvious places where we would explicitly allocate 0 bytes, so we
shouldn't trip any of those assertions.

We also avoid allocating zero bytes because C libraries don't
handle this consistently (some return NULL, some not); and it's
dangerous either way.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4690 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-08-26 06:25:57 +00:00
Avuton Olrich
f79a70d1b9 Fix warnings for -Wmissing-prototypes 
Add -Wmissing-prototypes if compiling with gcc
Static where possible

git-svn-id: https://svn.musicpd.org/mpd/trunk@4657 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-08-20 00:50:44 +00:00
Avuton Olrich
ca7fdaa929 Spelling & Grammar 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4612 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-08-11 21:50:56 +00:00
Warren Dukes
8e53406774 renamce cstrtok to buffer2array. please don't rename functions; especially to names that look extremely std-lib-ish. also, don't use isspace, apparently it's local dependent and potentially consideres ' ' or '\t' not to be a space, or considers other characters to be a space. 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4574 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-08-06 13:53:53 +00:00
Eric Wong
a80168a15b gcc signedness and sparse fixes 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4489 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-30 08:56:55 +00:00
Eric Wong
4d5b8509eb conf.c: bugfix: print out the number, not the address 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4482 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-30 03:43:34 +00:00
Eric Wong
f08342c11f replace buffer2array() with cstrtok() from mpd-ke 
This modifies the string in place, and does not allocate any memory from
the heap.  This is considerably smaller than the function it replaces,
and will be instrumental in getting the commands/conf malloc reductions
done.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4481 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-29 18:55:00 +00:00
J. Alexander Treuman
ce2fa2e846 conf.[ch] whitespace cleanup 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4477 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-27 19:10:08 +00:00
J. Alexander Treuman
22b16884a2 Use AudioCompress for volume normalization 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4474 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-27 00:50:59 +00:00
J. Alexander Treuman
cf90f8194f Adding on the fly volume normalization support. Code originally from mplayer, ported by syscrash, cleaned up by avuton, and further cleaned up by me (jat). 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4424 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-22 00:53:37 +00:00
J. Alexander Treuman
6dbacc71c7 Make getBoolConfigParam and save_absolute_paths_in_playlist less stupid 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4419 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-21 17:20:38 +00:00
J. Alexander Treuman
b892028b96 Add a getBoolConfigParam function 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4417 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-21 17:06:20 +00:00
Avuton Olrich
29a25b9933 Add mpd-indent.sh 
Indent the entire tree, hopefully we can keep
it indented.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4410 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-20 16:02:40 +00:00
Eric Wong
a234780aab sparse: ANSI-fy function declarations 
These are just warnings from sparse, but it makes the output
easier to read.  I ran this through a quick perl script, but
of course verified the output by looking at the diff and making
sure the thing still compiles.

here's the quick perl script I wrote to generate this patch:
----------- 8< -----------
use Tie::File;
defined(my $pid = open my $fh, '-|') or die $!;
if (!$pid) {
open STDERR, '>&STDOUT' or die $!;
exec 'sparse', @ARGV or die $!;
}
my $na = 'warning: non-ANSI function declaration of function';
while (<$fh>) {
print STDERR $_;
if (/^(.+?\.[ch]):(\d+):(\d+): $na '(\w+)'/o) {
my ($f, $l, $pos, $func) = ($1, $2, $3, $4);
$l--;
tie my @x, 'Tie::File', $f or die "$!: $f";
print '-', $x[$l], "\n";
$x[$l] =~ s/\b($func\s*)\(\s*\)/$1(void)/;
print '+', $x[$l], "\n";
untie @x;
}
}

git-svn-id: https://svn.musicpd.org/mpd/trunk@4378 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-17 00:15:34 +00:00
J. Alexander Treuman
2fa7125cce Change shank's email address 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4333 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-14 19:37:45 +00:00
Avuton Olrich
2a65e8667d [CLEANUP] Remove function from header, static 
it in the source

git-svn-id: https://svn.musicpd.org/mpd/trunk@4332 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-14 19:33:52 +00:00
Avuton Olrich
a37348a74f Huge header update, update the copyright and add 
the GPL header where necessary

git-svn-id: https://svn.musicpd.org/mpd/trunk@4317 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-13 19:20:34 +00:00
Avuton Olrich
82d0d4f51f Remove forceGetConfigParamValue, it's unused and even 
if it wasn't it'd probably be better to add a argument to
getConfigParamValue()

git-svn-id: https://svn.musicpd.org/mpd/trunk@4313 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-07-13 18:27:02 +00:00
J. Alexander Treuman
18306dfbd3 Add back the id3v1_encoding option. Now it really will convert id3v1 only. 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4282 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-06-21 20:52:51 +00:00
Qball Cow
8aca530b86 Remove unused config value 
git-svn-id: https://svn.musicpd.org/mpd/trunk@4130 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-04-30 18:29:02 +00:00
Eric Wong
e0439446b7 conf.c: correctly parse "~username/file" in config files 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3922 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-03-16 05:51:46 +00:00
Eric Wong
7e1bb85c1a conf.c: speling fickses 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3920 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2006-03-15 07:12:57 +00:00
Eric Wong
f8597ccf25 remove C++ style comments 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3689 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-11-19 10:52:47 +00:00
Qball Cow
4b00c62587 DJWLindenaar's fix race condition and some memory leaks patch 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3681 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-11-18 12:09:05 +00:00
Warren Dukes
75a967014f removed the id3v1_encoding config option, there's no way to guarantee that we actually got a given field from the v1 and not the v2 tag 
git-svn-id: https://svn.musicpd.org/mpd/trunk@3052 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-03-11 02:59:26 +00:00
Warren Dukes
4c7c6ca4a6 *) add support for pid files 
*) we now require pid_file to specified in the config
*) new prefered method for killing mpd: mpd --kill
*) cleaned up some nastiness with decode_pid handling

git-svn-id: https://svn.musicpd.org/mpd/trunk@3042 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-03-09 03:13:33 +00:00
Warren Dukes
586a21688f config file change! now 'port' is optional and 'db_file' is required! 
also, should have better error reporting when failing to open playlist or
music directory's, or writing the db, etc

git-svn-id: https://svn.musicpd.org/mpd/trunk@3027 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2005-03-06 19:00:58 +00:00
Warren Dukes
6e0c4369c3 fix a few memory leaks in conf.c 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2603 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-11 03:20:49 +00:00
Warren Dukes
d6a87f538d ok, now song->url is only the filename, not the full path to the song 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2602 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-11 02:59:16 +00:00
Warren Dukes
c5d27d8eaa merge changes from metadata-rewrite branch 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2589 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-10 21:58:27 +00:00
Warren Dukes
bc3019dc69 make http buffer and prebuffer size configurable 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2479 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-02 18:53:38 +00:00
Warren Dukes
1d939538eb a few extra strerror()'s sprinkled in the code 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2467 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-02 05:29:22 +00:00
Warren Dukes
2bb238cde9 does this make you happy normalperson, is this the way you like it, do you like it like this? 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2465 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-11-02 03:25:23 +00:00
Warren Dukes
fab2bef87a fix a config file error 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2435 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-10-31 15:54:21 +00:00
Warren Dukes
58dbe4bb5d merge shank-rewrite-config changes 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2375 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-10-28 05:14:55 +00:00
Warren Dukes
12597322a2 configure shout encoding quality and audio format 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2307 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-10-23 01:04:58 +00:00
Warren Dukes
cc66392570 apply dottemag's id3v1 encodings patch 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2163 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-10-05 17:16:26 +00:00
Warren Dukes
8810eafb82 add configuration variables for shout stuff 
git-svn-id: https://svn.musicpd.org/mpd/trunk@2099 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-09-02 18:16:00 +00:00
Warren Dukes
ab0b6ce56f for improperly config file lines, print the line number 
also, in myFgets, chop off '\r' at the end of the line (thanx mr gates)

git-svn-id: https://svn.musicpd.org/mpd/trunk@2000 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-08-10 16:03:03 +00:00
Warren Dukes
efda73c74d add replaygain preamp 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1873 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-07-17 14:54:22 +00:00
Warren Dukes
a0227e8062 deal with user and ~ in config file more nicely 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1871 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-07-15 20:15:26 +00:00
Warren Dukes
d8dbd29c2d add http proxy config options (no http proxy code yet) 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1584 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-20 14:00:34 +00:00
Warren Dukes
b7e0d34b9e update mpd manpage and sample config file with replaygain and 
audio_output_format options

git-svn-id: https://svn.musicpd.org/mpd/trunk@1453 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-12 21:27:15 +00:00
Warren Dukes
c2c34f78dd new command, plchanges, and also add Num: to songinfo of playlistinfo 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1339 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-06-05 01:14:37 +00:00
Warren Dukes
cd3180c701 stuff for configuring the audio output format (sampling rate, channels, bits) 
git-svn-id: https://svn.musicpd.org/mpd/trunk@967 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-10 02:20:15 +00:00
Warren Dukes
04fdc209d9 add replayGain stuff for flac from AliasMrJones 
git-svn-id: https://svn.musicpd.org/mpd/trunk@943 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-05-07 22:42:54 +00:00
Warren Dukes
549344d38a add vim shiznit to end of all source files 
git-svn-id: https://svn.musicpd.org/mpd/trunk@750 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-14 14:53:41 +00:00
Warren Dukes
b1d12ba0f6 make default max playlist length be 16384. bumped up from 4096 
git-svn-id: https://svn.musicpd.org/mpd/trunk@602 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-04 07:08:00 +00:00
Warren Dukes
785cdb0114 use EXIT_SUCCESS and EXIT_FAILURE 
git-svn-id: https://svn.musicpd.org/mpd/trunk@591 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-04-02 23:34:16 +00:00
Warren Dukes
7874a003e9 fix bug where accidently setting default mixer to NULL instead of SOFTWARE 
git-svn-id: https://svn.musicpd.org/mpd/trunk@413 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-23 02:46:18 +00:00
Warren Dukes
4aec92fd6e rewrite error message for wrong number of config args 
git-svn-id: https://svn.musicpd.org/mpd/trunk@171 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-03-02 20:55:00 +00:00
Warren Dukes
8edc416344 some more cleanups 
git-svn-id: https://svn.musicpd.org/mpd/trunk@60 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-02-25 21:10:56 +00:00
Warren Dukes
068d307a71 make ~ work for paths 
git-svn-id: https://svn.musicpd.org/mpd/trunk@37 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-02-24 21:20:16 +00:00
Warren Dukes
d35747a40c import from SF CVS 
git-svn-id: https://svn.musicpd.org/mpd/trunk@1 09075e82-0dd4-0310-85a5-a0d7c8717e4f
 2004-02-23 23:41:20 +00:00