oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity
4,003 Commits 1 Branch 144 Tags 56 MiB
6e72755204
Commit Graph

32 Commits

Author SHA1 Message Date
Max Kellermann
75c2029b1c tag: no CamelCase 
Renamed numOfItems to num_items.
 2009-02-27 09:01:55 +01:00
Max Kellermann
ec926539a3 output_plugin: report errors with GError 
Use GLib's GError library for reporting output device failures.

Note that some init() methods don't clean up properly after a failure,
but that's ok for now, because the MPD core will abort anyway.
 2009-02-26 22:04:59 +01:00
Max Kellermann
bcc3a9debf shout: use config_get_block_unsigned() 
Eliminated manual integer parsing.
 2009-02-26 19:34:00 +01:00
Max Kellermann
dcd84c19cd output_plugin: don't pass audio_output object to method init() 
audio_output_get_name() has been removed, which was the only function
left in output_api.h.  The output plugin doesn't need the audio_output
object at all, remove the parameter from the init() method.
 2009-02-25 18:34:02 +01:00
Max Kellermann
a4dfab2aee output: pass the music chunk pointer as void*, not char* 
The meaning of the chunk depends on the audio format; don't suggest a
specific format by declaring the pointer as "char*", pass "void*"
instead.
 2009-02-23 09:34:26 +01:00
Max Kellermann
5a898c15e7 output_api: play() returns a length 
The old API required an output plugin to not return until all data
passed to the play() method is consumed.  Some output plugins have to
loop to fulfill that requirement, and may block during that.  Simplify
these, by letting them consume only part of the buffer: make play()
return the length of the consumed data.
 2009-02-23 09:29:56 +01:00
Max Kellermann
d50a3d513e shout: removed shout_plugin.h 
There are no plugins left which require shout_plugin.h.  Moved the
struct declaration to shout_plugin.c.
 2009-02-22 17:52:37 +01:00
Max Kellermann
1c56edd1c8 shout: removed shout_encoder_plugins 
This array is empty, and is not used anymore.
 2009-02-22 17:51:12 +01:00
Max Kellermann
f6e5c00726 shout: use the new encoder API 
Removed shout's encoder plugin API in favor of the new generic encoder
plugin API.
 2009-02-22 17:18:28 +01:00
Max Kellermann
e79a82ba3a shout: merged open_shout_conn() into my_shout_open_device() 
The method implementation my_shout_open_device() consists of only one
line, the call to open_shout_conn().  Merge both functions into one.
 2009-02-22 15:24:41 +01:00
Max Kellermann
cece6c00f4 shout: bool return values instead of int 
Return true/false instead of 0/-1.
 2009-02-22 15:18:58 +01:00
Max Kellermann
1ac328b553 shout: clear buffer before calling the encoder 
Always assume the buffer is empty before calling the encoder.  Always
flush the buffer immediately after there has been added something.
This reduces the risk of buffer overruns, because there will never be
a "rest" in the current buffer.
 2009-02-09 16:38:25 +01:00
Max Kellermann
7fc25ad567 shout: don't postpone metadata 
Don't duplicate the tag received by the send_metadata() method - send
it to the shout server directly.
 2009-02-09 16:38:22 +01:00
Max Kellermann
f5c43889c3 shout: use libshout's synchronization 
Removed the manual timer synchronization from the shout plugin.
libshout's shout_sync() function does it for us.
 2009-02-09 16:38:20 +01:00
Max Kellermann
f6455d5f79 shout: switch to blocking mode 
The non-blocking mode of libshout is sparsely documented, and MPD's
implementation had several bugs.  Also removed connect throttling
code, that is done by the MPD core since 0.14.
 2009-02-09 16:38:03 +01:00
Max Kellermann
cf94008b27 shout: removed shout_data.tag_to_send 
When shout_data.tag!=NULL, there is a "tag to send".  The tag_to_send
flag is redundant.
 2009-02-09 16:37:16 +01:00
Max Kellermann
044f2561ce shout: removed shout_data.shout_error 
That variable is set in handle_shout_error(), but is never read.
 2009-02-09 16:37:12 +01:00
Max Kellermann
231636b9eb output_api: moved the command check out of method pause() 
Move the "while" loop which checks for commands to the caller
ao_pause().  This simplifies the pause() method, and lets us remove
audio_output_is_pending().
 2009-01-30 20:12:38 +01:00
Max Kellermann
a45922cd66 use g_free() instead of free() 
On some platforms, g_free() must be used for memory allocated by
GLib.  This patch intends to correct a lot of occurrences, but is
probably not complete.
 2009-01-25 18:47:21 +01:00
Max Kellermann
5f77910097 conf: const pointers in block get functions 
All config_get_block_*() functions should accept constant config_param
pointers.
 2009-01-25 16:03:49 +01:00
Max Kellermann
65f2386b39 conf: added config_get_block_unsigned() 
Eliminate some more getBlockParam() invocations.
 2009-01-18 19:45:51 +01:00
Max Kellermann
a531a1e650 conf: added config_get_block_string() 
This replaces lots of getBlockParam() invocations.
 2009-01-18 19:37:27 +01:00
Max Kellermann
7acc62366c conf: replaced getBoolBlockParam() with config_get_block_bool() 
No "force" parameter, pass a default value instead.
 2009-01-17 20:23:56 +01:00
Max Kellermann
4d472c265e conf: no CamelCase, part I 
Renamed functions, types, variables.
 2009-01-17 20:23:27 +01:00
Max Kellermann
5e93d3682f added missing explicit config.h includes 2009-01-08 21:37:02 +01:00
Viliam Mateicka
d96cda95a1 shout: fixed bad error message printout 2008-12-23 18:05:25 +01:00
Max Kellermann
be60ff83f7 shout: use GLib instead of utils.h/log.h 2008-11-25 17:25:41 +01:00
Max Kellermann
125dad7119 shout: don't check HAVE_SHOUT 
If the shout plugin is disabled, shout_plugin.c isn't compiled at all,
no need to check the macro definition.
 2008-11-25 17:19:42 +01:00
Alam Arias
78f60c9c6d removed unneed check for protocol in shout plugin, will assume icecast2 protocol if not exist in config 2008-10-31 12:20:49 +01:00
Max Kellermann
2f76db4c78 output: close device on play error 
When an output plugin fails to play a chunk, close it.  This replaces
various manual close() calls in nearly all plugins.
 2008-10-29 20:40:33 +01:00
Max Kellermann
58c5bee9f0 output: use bool for return values and flags 
Don't return 0/-1 on success/error, but true/false.  Instead of int,
use bool for storing flags.
 2008-10-29 20:40:27 +01:00
Max Kellermann
ece8c1347c renamed src/audioOutputs/ to src/output/ 
Again, no CamelCase in the directory name.
 2008-10-26 11:29:44 +01:00