oysteikt/mpd
0
0
Fork 0
Code Issues Pull Requests Releases Activity

tag_ape: removed redundant length check

Browse Source 
Extend the tagLen check after reading it.  Removed the second
(redundant) check after the subtraction.
This commit is contained in:
Max Kellermann 2009-07-19 17:37:02 +02:00
parent a988b9b025
commit e3ff0ab6d1
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/tag_ape.c
View File

@ -22,6 +22,7 @@
#include <glib.h>
#include <assert.h>
#include <stdio.h>
struct tag *
@ -86,15 +87,15 @@ tag_ape_load(const char *file)
/* find beginning of ape tag */
tagLen = GUINT32_FROM_LE(footer.length);
if (tagLen < sizeof(footer))
if (tagLen <= sizeof(footer) + 10)
goto fail;
if (fseek(fp, size - tagLen, SEEK_SET))
goto fail;
/* read tag into buffer */
tagLen -= sizeof(footer);
if (tagLen <= 0)
goto fail;
assert(tagLen > 10);
buffer = g_malloc(tagLen);
if (fread(buffer, 1, tagLen, fp) != tagLen)
goto fail;